From patchwork Sun Sep 7 21:06:05 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 4859311 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 71002C0338 for ; Sun, 7 Sep 2014 21:09:13 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B030220120 for ; Sun, 7 Sep 2014 21:09:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E43F320117 for ; Sun, 7 Sep 2014 21:09:11 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1XQjfY-0002oq-Tx; Sun, 07 Sep 2014 21:06:44 +0000 Received: from mout.kundenserver.de ([212.227.17.10]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XQjfV-0002nC-7z for linux-arm-kernel@lists.infradead.org; Sun, 07 Sep 2014 21:06:41 +0000 Received: from wuerfel.localnet (HSI-KBW-134-3-133-35.hsi14.kabel-badenwuerttemberg.de [134.3.133.35]) by mrelayeu.kundenserver.de (node=mreue103) with ESMTP (Nemesis) id 0LzYuY-1YV80A3dII-014h2o; Sun, 07 Sep 2014 23:06:09 +0200 From: Arnd Bergmann To: Robert Jarzmik Subject: Re: [PATCH ] ARM: pxa: fix section mismatch warning for pxa_timer_nodt_init Date: Sun, 07 Sep 2014 23:06:05 +0200 Message-ID: <3188925.pjYA4K7kjn@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <12220413.BdRleC0Xf5@wuerfel> References: <1405356724-32207-1-git-send-email-robert.jarzmik@free.fr> <87oawivarv.fsf@free.fr> <12220413.BdRleC0Xf5@wuerfel> MIME-Version: 1.0 X-Provags-ID: V02:K0:+g/6DcdkH2ICxbdH8vv4tkWzTVfnjIy8tnqElAqfRQC snOaNufC8GAFc7LcPEfE4f9JLWj2zgR06twru1peo+ofIx1YNY GI9s70dVacGMqjyryW/9F+K2xvuDMuxb+i7vRDNYG5/n82kBV2 iyvsJwj0qNckmDahColCe2vbJWMyvgGkci9SXoiOayu2NZJApY stBlkcka27xEd8bnvOHwx5mA6Qs1toJFwRlCsJgEB4F1CNwCYi lg8EBX1X8kv4HNsMmivfHlM76O3wgYLkACeshiZWxPJniDRhy3 qYff1Z66FanlubPrCFpUW42NbDDZTS6xGaqtcpYXELyFxmjtxk QnmvbgxHhJfcnrk+CzFQ= X-UI-Out-Filterresults: notjunk:1; X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140907_140641_645274_57722E5F X-CRM114-Status: GOOD ( 10.43 ) X-Spam-Score: -0.2 (/) Cc: devicetree@vger.kernel.org, Daniel Lezcano , linux-kernel@vger.kernel.org, Haojian Zhuang , arm@kernel.org, Thomas Gleixner , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Saturday 26 July 2014 20:50:36 Arnd Bergmann wrote: > commit a38b1f60b5245a3 ("ARM: pxa: Add non device-tree timer link to > clocksource") introduced a harmless section mismatch warning for > all pxa platforms, by introducing a new pxa_timer_init() function > that is not marked __init but that calls pxa_timer_nodt_init(), > which is. The function is only called at init time, so it is safe > to also annotate it this way. > > Signed-off-by: Arnd Bergmann > Apparently this is not merged yet, should we take it through arm-soc? diff --git a/arch/arm/mach-pxa/generic.c b/arch/arm/mach-pxa/generic.c index 630fa916bbc6..04b013fbc98f 100644 --- a/arch/arm/mach-pxa/generic.c +++ b/arch/arm/mach-pxa/generic.c @@ -61,7 +61,7 @@ EXPORT_SYMBOL(get_clock_tick_rate); /* * For non device-tree builds, keep legacy timer init */ -void pxa_timer_init(void) +void __init pxa_timer_init(void) { pxa_timer_nodt_init(IRQ_OST0, io_p2v(0x40a00000), get_clock_tick_rate());