| Message ID | 32b39396-d514-524f-a85c-3bc627454ba7@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v3] crypto: arm64/aes-neonbs - add return value of skcipher_walk_done() in __xts_crypt() | expand |
On Thu, 31 Oct 2019 at 08:02, Yunfeng Ye <yeyunfeng@huawei.com> wrote: > > A warning is found by the static code analysis tool: > "Identical condition 'err', second condition is always false" > > Fix this by adding return value of skcipher_walk_done(). > > Fixes: 67cfa5d3b721 ("crypto: arm64/aes-neonbs - implement ciphertext stealing for XTS") > Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com> > Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Please don't send the exact same patch twice, and when you feel the need to do so, just ask instead whether your patch was received or not. I'm sure Herbert will pick it up shortly. > --- > v2 -> v3: > - add "Acked-by:" > > v1 -> v2: > - update the subject and comment > - add return value of skcipher_walk_done() > > arch/arm64/crypto/aes-neonbs-glue.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/crypto/aes-neonbs-glue.c b/arch/arm64/crypto/aes-neonbs-glue.c > index ea873b8904c4..e3e27349a9fe 100644 > --- a/arch/arm64/crypto/aes-neonbs-glue.c > +++ b/arch/arm64/crypto/aes-neonbs-glue.c > @@ -384,7 +384,7 @@ static int __xts_crypt(struct skcipher_request *req, bool encrypt, > goto xts_tail; > > kernel_neon_end(); > - skcipher_walk_done(&walk, nbytes); > + err = skcipher_walk_done(&walk, nbytes); > } > > if (err || likely(!tail)) > -- > 2.7.4.3 > >
On 2019/10/31 16:13, Ard Biesheuvel wrote: > On Thu, 31 Oct 2019 at 08:02, Yunfeng Ye <yeyunfeng@huawei.com> wrote: >> >> A warning is found by the static code analysis tool: >> "Identical condition 'err', second condition is always false" >> >> Fix this by adding return value of skcipher_walk_done(). >> >> Fixes: 67cfa5d3b721 ("crypto: arm64/aes-neonbs - implement ciphertext stealing for XTS") >> Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com> >> Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > Please don't send the exact same patch twice, and when you feel the > need to do so, just ask instead whether your patch was received or > not. > ok, thanks. > I'm sure Herbert will pick it up shortly. > >> --- >> v2 -> v3: >> - add "Acked-by:" >> >> v1 -> v2: >> - update the subject and comment >> - add return value of skcipher_walk_done() >> >> arch/arm64/crypto/aes-neonbs-glue.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm64/crypto/aes-neonbs-glue.c b/arch/arm64/crypto/aes-neonbs-glue.c >> index ea873b8904c4..e3e27349a9fe 100644 >> --- a/arch/arm64/crypto/aes-neonbs-glue.c >> +++ b/arch/arm64/crypto/aes-neonbs-glue.c >> @@ -384,7 +384,7 @@ static int __xts_crypt(struct skcipher_request *req, bool encrypt, >> goto xts_tail; >> >> kernel_neon_end(); >> - skcipher_walk_done(&walk, nbytes); >> + err = skcipher_walk_done(&walk, nbytes); >> } >> >> if (err || likely(!tail)) >> -- >> 2.7.4.3 >> >> > > . >
diff --git a/arch/arm64/crypto/aes-neonbs-glue.c b/arch/arm64/crypto/aes-neonbs-glue.c index ea873b8904c4..e3e27349a9fe 100644 --- a/arch/arm64/crypto/aes-neonbs-glue.c +++ b/arch/arm64/crypto/aes-neonbs-glue.c @@ -384,7 +384,7 @@ static int __xts_crypt(struct skcipher_request *req, bool encrypt, goto xts_tail; kernel_neon_end(); - skcipher_walk_done(&walk, nbytes); + err = skcipher_walk_done(&walk, nbytes); } if (err || likely(!tail))
A warning is found by the static code analysis tool: "Identical condition 'err', second condition is always false" Fix this by adding return value of skcipher_walk_done(). Fixes: 67cfa5d3b721 ("crypto: arm64/aes-neonbs - implement ciphertext stealing for XTS") Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com> Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> --- v2 -> v3: - add "Acked-by:" v1 -> v2: - update the subject and comment - add return value of skcipher_walk_done() arch/arm64/crypto/aes-neonbs-glue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)