From patchwork Wed Jan 8 08:20:10 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 3452501 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id C2BA89F374 for ; Wed, 8 Jan 2014 08:21:09 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id ACF8820109 for ; Wed, 8 Jan 2014 08:21:08 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B519320103 for ; Wed, 8 Jan 2014 08:21:07 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1W0oNc-00039x-2q; Wed, 08 Jan 2014 08:20:48 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1W0oNZ-00066q-M1; Wed, 08 Jan 2014 08:20:45 +0000 Received: from moutng.kundenserver.de ([212.227.126.187]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1W0oNX-00066A-El for linux-arm-kernel@lists.infradead.org; Wed, 08 Jan 2014 08:20:44 +0000 Received: from wuerfel.localnet (HSI-KBW-085-216-031-165.hsi.kabelbw.de [85.216.31.165]) by mrelayeu.kundenserver.de (node=mrbap1) with ESMTP (Nemesis) id 0MVsSW-1VuK7n2naC-00XovQ; Wed, 08 Jan 2014 09:20:11 +0100 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] Fix select-induced Kconfig warning for ZBOOT_ROM Date: Wed, 08 Jan 2014 09:20:10 +0100 Message-ID: <3792319.Wf518ByjFs@wuerfel> User-Agent: KMail/4.11 rc1 (Linux/3.10.0-5-generic; KDE/4.11.2; x86_64; ; ) In-Reply-To: References: MIME-Version: 1.0 X-Provags-ID: V02:K0:dRxRHFToEuNFmJvAATSXG+LPr0nwh+6ODQ98bOk76TC oMrRo7CAgsvtF34aXtXzgV6d+/zK54iFKI8ATgjxJb0u/w8m8d zPNYEOC650MeKhlh5snxGC/mY8KwKbTM+gD9p7oOqzY8Nak/7V 2DjOiNL1mcojvpeCEhJFO3bCxs8REcTlb7CZeHI5D6Fks/f2/a VUa/a2B10PAyG9FZ9KUncmvS3YIYsz7BHkHTEndKSPzhGtKSPW tqRkJvdyYjzMku7xcmGd3+ggssUmIRELEUB7t99teZ1F6gPxlP qYiP7mUEqjgPKqwgfM3RjsWiDZOzeRkL1Mj9yfCG87d8kfM08F umMeWGpQ4PHJObJbGPIk= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140108_032043_686570_84BEB730 X-CRM114-Status: GOOD ( 13.18 ) X-Spam-Score: -1.9 (-) Cc: Viresh Kumar , "arm@kernel.org" , Russell King X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Wednesday 08 January 2014 13:32:35 Viresh Kumar wrote: > On Thu, Jan 2, 2014 at 9:53 PM, Russell King > wrote: > > warning: (ARCH_MULTIPLATFORM && ARCH_CLPS711X && ARCH_PXA && > > SOC_EXYNOS5440 && ARCH_EMEV2) selects AUTO_ZRELADDR which > > has unmet direct dependencies (!ZBOOT_ROM) > > > > This is because it's possible to have ZBOOT_ROM enabled, but at the > > same time have another option enabled which selects AUTO_ZRELADDR > > overriding the !ZBOOT_ROM dependency. Fix this by reversing the > > dependencies between ZBOOT_ROM and the options which depend on > > !ZBOOT_ROM. > > > > Signed-off-by: Russell King > > --- > > After this patch I see these warnings with exynos_defconfig > > arch/arm/Kconfig:1963:error: recursive dependency detected! > arch/arm/Kconfig:1963: symbol ZBOOT_ROM depends on AUTO_ZRELADDR > arch/arm/Kconfig:2151: symbol AUTO_ZRELADDR is selected by ZBOOT_ROM > > I am not really sure why this happened as I don't see AUTO_ZRELADDR > selected by ZBOOT_ROM in Kconfig :) It's a weird dependency. You need this hunk: --- a/arch/arm/mach-imx/Kconfig +++ b/arch/arm/mach-imx/Kconfig @@ -3,7 +3,7 @@ config ARCH_MXC select ARCH_REQUIRE_GPIOLIB select ARM_CPU_SUSPEND if PM select ARM_PATCH_PHYS_VIRT - select AUTO_ZRELADDR if !ZBOOT_ROM + select AUTO_ZRELADDR select CLKSRC_MMIO select COMMON_CLK select GENERIC_ALLOCATOR