From patchwork Sun Nov 6 10:20:56 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 9413901 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 925076022E for ; Sun, 6 Nov 2016 10:23:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7FBD628505 for ; Sun, 6 Nov 2016 10:23:09 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 73EDC28E7E; Sun, 6 Nov 2016 10:23:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 0DFB128505 for ; Sun, 6 Nov 2016 10:23:09 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1c3KaC-0000FQ-Md; Sun, 06 Nov 2016 10:21:48 +0000 Received: from mout.kundenserver.de ([212.227.126.130]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1c3Ka5-00008w-9T for linux-arm-kernel@lists.infradead.org; Sun, 06 Nov 2016 10:21:44 +0000 Received: from oxbaltgw06.schlund.de ([172.19.246.12]) by mrelayeu.kundenserver.de (mreue002) with ESMTPSA (Nemesis) id 0Lo5sn-1cVopf11hp-00gKGR; Sun, 06 Nov 2016 11:20:58 +0100 Date: Sun, 6 Nov 2016 11:20:56 +0100 (CET) From: Stefan Wahren To: Russell King - ARM Linux Message-ID: <381813296.167766.9867e3e7-5710-4844-a098-6f44bd852a6d.open-xchange@email.1und1.de> In-Reply-To: <20161105180542.GE1041@n2100.armlinux.org.uk> References: <20161023133134.GI1041@n2100.armlinux.org.uk> <1709157673.85170.1cb53b4d-2805-48ea-aef1-dd282306d108.open-xchange@email.1und1.de> <20161031161700.GH1041@n2100.armlinux.org.uk> <847975190.29034.38a9c7fa-bdf8-4732-ac8b-cf15c21e3ce8.open-xchange@email.1und1.de> <20161101092304.GM1041@n2100.armlinux.org.uk> <322177156.158733.9867e3e7-5710-4844-a098-6f44bd852a6d.open-xchange@email.1und1.de> <1478345972.2206.15.camel@intel.com> <122295766.159553.9867e3e7-5710-4844-a098-6f44bd852a6d.open-xchange@email.1und1.de> <20161105130034.GG15759@mai> <1113068116.152452.34665947-6f6b-41d6-92af-eabcbcb794ea.open-xchange@email.1und1.de> <20161105180542.GE1041@n2100.armlinux.org.uk> Subject: Re: [Bug] ARM: mxs: STI: console can't wake up from freeze MIME-Version: 1.0 X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.8.0-Rev40 X-Originating-Client: open-xchange-appsuite X-Provags-ID: V03:K0:q26trwEZ2wIiPsaSl/DZDWTRQpuWYeZLfX6PpfghSC5UUpO5Cfc 0BXS1XHspKOHPBk7j09z+WOuBnLAREibmS1W7ZC+HxhElmicrWefCtoWvjLzrR5ahas8gu9 wILvckMWjOewpxsfUP56Q44C6JoRd8f2/hIgZKtdmX0AMPV3AdrYQxh4rV/aPz7L9DljiDT sXGX1nFORs0xP62ZbjGcQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:1nMcX0jWo5M=:M6CA57cVAG6hmJDI0hF31p aBJUqS8pjQ1/Gm2tHQ0agDen1THkTAml8rOSGs1vJxT/s7CPYI5zfzKkG7ZIwdLDS8JXHl5h7 dupyP+nwlQGQmMn7kyti2+DQ0McWV46EalNEpDAS/Ywt/0QCzddb5e+VGd4c2my6Ag4gU4tzs 7/wwmc4LhPPzZ4mGJjotoFFqtT4+EHuCWU3DSKXiepWaV3nALFhkqVbapnIKLALJE98SlxDrl 16g4MqCdNCZt2Kb4LTB6nrt78HsfGLJOAsVo0Oscc9/Rlh/kbyHJUmDwy/kFE/b8jSaSxhl7B kW1q/p2LQDNYRubogY6ovtc45Uo2QUUNubauHm6+eWH8eoUB6eTQtlhetxs6SifKHFQA7MtWt O1IpNBGqRwbhPI3yYHcq0R1jLslsKuDjMU9xQ0meQ8w5h+Lg9lOIXzxcPJLt0vfyUxIbExS7g 2HCkp4CWT/PiZtQgpYIehX0lAlkOoVPR/OtrfMmiAZWPB3w6ryiTGJpIJwS+34RzZ8I4zd/OZ 6D6HXnSRXK1xm+acHKERSTO78Hir8XkWv5+oT5i0r1CqUIr3543nbovobWP7N+ChGUDxTfwOq 8QTavzYC5YAbvp6UeVeYH2kvtWLVGcusPpmYB8cW+Bw28Lm/P0YkwsSacm9HAaT9uRnY0QuBR h9gRUFKs2yY/iRHrZ+bXxKfspMtXbcurlqGO8PH1Tku0M59zyaG24kK8fUJ3LxeajKiwvd0tq 0lr7eam/dh0ikVZd X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20161106_022141_716980_A43F5EBA X-CRM114-Status: GOOD ( 11.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Lezcano , linux-pm@vger.kernel.org, joerg.krause@embedded.rocks, "Rafael J. Wysocki" , Sascha Hauer , Fabio Estevam , Zhang Rui , Shawn Guo , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Hi, > Russell King - ARM Linux hat am 5. November 2016 um > 19:05 geschrieben: > > > On Sat, Nov 05, 2016 at 04:28:37PM +0100, Stefan Wahren wrote: > > As i wrote in my email before, i added a pr_info() into freeze_wake. > > But i never see the output of this message. So i assume freeze_wake > > is never called. Again, how could this happen? > > Hmm, so the bit that you're getting stuck on is: > > wait_event(suspend_freeze_wait_head, > suspend_freeze_state == FREEZE_STATE_WAKE); > thanks for all the feedback. The real cause for this issue is in the irqchip driver. I fixed it with this patch: diff --git a/drivers/irqchip/irq-mxs.c b/drivers/irqchip/irq-mxs.c index 1730470..05fa9f7 100644 --- a/drivers/irqchip/irq-mxs.c +++ b/drivers/irqchip/irq-mxs.c @@ -131,12 +131,16 @@ static void asm9260_unmask_irq(struct irq_data *d) .irq_ack = icoll_ack_irq, .irq_mask = icoll_mask_irq, .irq_unmask = icoll_unmask_irq, + .flags = IRQCHIP_MASK_ON_SUSPEND | + IRQCHIP_SKIP_SET_WAKE, }; static struct irq_chip asm9260_icoll_chip = { .irq_ack = icoll_ack_irq, .irq_mask = asm9260_mask_irq, .irq_unmask = asm9260_unmask_irq, + .flags = IRQCHIP_MASK_ON_SUSPEND | + IRQCHIP_SKIP_SET_WAKE, }; asmlinkage void __exception_irq_entry icoll_handle_irq(struct pt_regs *regs)