From patchwork Thu Jan 25 12:09:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13530888 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38B25C48285 for ; Thu, 25 Jan 2024 14:09:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PLtUnNuVRNNNsldBfXpyAHxjyxpj4V74m+ZXYK1Sido=; b=QwR0GsQKmDUiE9 UsKdEd1eu2Pz7GOV2BrENsiQBXCzQQnlq0gfyz6xd0/Ec2FgFRrIVXhTrCEz1AhIfSbKpyBL+EGpL HLacddFusLo+nbJuWVukR05fYGyBqn6sCFMqKC9LIXgo/Iiolc4AFDXzZKhWGeDKnJcIUo+LC+dvB 0RdnUFeBAqTZIv+4m+YH/KUA0/q/jfuEISuciUy85sl2ijNQWuvE+4QPwNo4bLX4gpURvyW3LAC6z d6n9JMH3L7nAJO94Varmnj57jDfhX5+iLiOvx1+45JdXTqAndwwLiihvysDOaj7QBsweB7dI/oFm7 5zvFJCd0fOlTTuOZUwbQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rT0PS-00000000FMf-1qFF; Thu, 25 Jan 2024 14:08:50 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rT0Ol-00000000F1m-0t6p for linux-arm-kernel@bombadil.infradead.org; Thu, 25 Jan 2024 14:08:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description; bh=EF3eYK6XmS3ZD3U/bmbaOtrol+AEJdn5GjkXO/CimKY=; b=UfzJEWvo+dYg9pgoUbeQv/ZzXg GFYFLJqT8bv5hauOOenBYlzq0v02hnr50Z+khtzzdaxhh5nQsX8NRoyDKaAUjsunARh/TVz0Krl3z +1bglEs/ENAshytaimc3Eb1vgkoMsm+oaVdajRSKNEu2h4zt+FSjGweusYcbNssOD1HF1YOBNUHOu uE8Ji+O4WQ1eFg59N9uRQ1MCT5gc0GPNC6yA9lm8AdYS0ktRuL0Q1Pn16IQEJIs2KicTf+luQtXjL j1iy6E8Lr4gGxAV3U5CnRyPRg45FjTQX2ncdx+0E8sQMdZNpH1/xo6YcefRPoQ5h/bickJOZjYbq6 yZ6raXPg==; Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by casper.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rSybd-00000009sDd-0l8D for linux-arm-kernel@lists.infradead.org; Thu, 25 Jan 2024 12:13:23 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rSyZN-0004Vs-IK; Thu, 25 Jan 2024 13:10:57 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rSyZM-002HU4-9G; Thu, 25 Jan 2024 13:10:56 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rSyZM-007n3g-0e; Thu, 25 Jan 2024 13:10:56 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Heiko Stuebner , linux-pwm@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH v5 083/111] pwm: rockchip: Make use of devm_pwmchip_alloc() function Date: Thu, 25 Jan 2024 13:09:45 +0100 Message-ID: <3fa1cd248c423c95ab1290634cbfeb3276ba28fd.1706182805.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2829; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=rtkcltZMOo6Md1RGPzlmRgv8CpR5PZFpQu75wMewXGw=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlsk+b7O3Tj9e5mLiJRD+ipanh5rqcqMw8SSFr/ hT7jkyLY7CJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZbJPmwAKCRCPgPtYfRL+ TuX4CAC4FUxEkLR++lna/0x4V3p4ucf0bvhZZV0k6mJtnGEetrbF3GlcUj72tO9zyWvSwqlKlpa Sb2q6kLIzDQ5ibxn4iivv2/bu9OP5KAElzL1SNw+Zz8g+60tyRtXVuF5Fkz7Jm8ZQYAe0IzbCK7 /8hEjfWL1mq67VfXAdd8yUSDLgt5iO2lUVc2OW0kyLSXDqsLyci3EuaKXD+Dn5xur7WNvikj+iv JPBuh0SVgJmHo/euTq7tj1bvqvCBhjqbK8L76bhzidQlLJmAb+KufRtPjEMG/wdJPovR+3wjbv7 pro6sGXR9szKEmMyP9kEdsFle+mOmG+n34s717EcTv0kDpjR X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240125_121318_689233_9C0F82EE X-CRM114-Status: GOOD ( 13.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This prepares the pwm-rockchip driver to further changes of the pwm core outlined in the commit introducing devm_pwmchip_alloc(). There is no intended semantical change and the driver should behave as before. Reviewed-by: Heiko Stuebner Signed-off-by: Uwe Kleine-König --- drivers/pwm/pwm-rockchip.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/pwm/pwm-rockchip.c b/drivers/pwm/pwm-rockchip.c index a7c647e37837..0fa7575dbb54 100644 --- a/drivers/pwm/pwm-rockchip.c +++ b/drivers/pwm/pwm-rockchip.c @@ -30,7 +30,6 @@ #define PWM_LP_DISABLE (0 << 8) struct rockchip_pwm_chip { - struct pwm_chip chip; struct clk *clk; struct clk *pclk; const struct rockchip_pwm_data *data; @@ -54,7 +53,7 @@ struct rockchip_pwm_data { static inline struct rockchip_pwm_chip *to_rockchip_pwm_chip(struct pwm_chip *chip) { - return container_of(chip, struct rockchip_pwm_chip, chip); + return pwmchip_get_drvdata(chip); } static int rockchip_pwm_get_state(struct pwm_chip *chip, @@ -296,14 +295,16 @@ MODULE_DEVICE_TABLE(of, rockchip_pwm_dt_ids); static int rockchip_pwm_probe(struct platform_device *pdev) { + struct pwm_chip *chip; struct rockchip_pwm_chip *pc; u32 enable_conf, ctrl; bool enabled; int ret, count; - pc = devm_kzalloc(&pdev->dev, sizeof(*pc), GFP_KERNEL); - if (!pc) - return -ENOMEM; + chip = devm_pwmchip_alloc(&pdev->dev, 1, sizeof(*pc)); + if (IS_ERR(chip)) + return PTR_ERR(chip); + pc = to_rockchip_pwm_chip(chip); pc->base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(pc->base)) @@ -337,18 +338,16 @@ static int rockchip_pwm_probe(struct platform_device *pdev) goto err_clk; } - platform_set_drvdata(pdev, pc); + platform_set_drvdata(pdev, chip); pc->data = device_get_match_data(&pdev->dev); - pc->chip.dev = &pdev->dev; - pc->chip.ops = &rockchip_pwm_ops; - pc->chip.npwm = 1; + chip->ops = &rockchip_pwm_ops; enable_conf = pc->data->enable_conf; ctrl = readl_relaxed(pc->base + pc->data->regs.ctrl); enabled = (ctrl & enable_conf) == enable_conf; - ret = pwmchip_add(&pc->chip); + ret = pwmchip_add(chip); if (ret < 0) { dev_err_probe(&pdev->dev, ret, "pwmchip_add() failed\n"); goto err_pclk; @@ -372,9 +371,10 @@ static int rockchip_pwm_probe(struct platform_device *pdev) static void rockchip_pwm_remove(struct platform_device *pdev) { - struct rockchip_pwm_chip *pc = platform_get_drvdata(pdev); + struct pwm_chip *chip = platform_get_drvdata(pdev); + struct rockchip_pwm_chip *pc = to_rockchip_pwm_chip(chip); - pwmchip_remove(&pc->chip); + pwmchip_remove(chip); clk_unprepare(pc->pclk); clk_unprepare(pc->clk);