From patchwork Thu Jun 27 11:04:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lorenzo Bianconi X-Patchwork-Id: 13714195 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A35D7C3064D for ; Thu, 27 Jun 2024 11:07:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qi8bJGcSifhUOZte1o3r4lzsytIrzM0LU6zxkcCefwE=; b=cyCMStF7iV+p6bo6QRQGGhx2oV C5+4uinpYlLmclL5yTfp7PnfSiY4B0eCyzC6C/xfJnXAhzphXiD4IdQZ6AtTclorT/XLKgeTCd/um D6UBUf71x14zOXmaNoD3HXNOz7bPk5lTEziCZUuu13IOIbrot8KlreDnLy0AW/O7CV2c9yhHAjgc0 oBimjkIVC1koMZ1KhPixVxd/9M5TGPeEMRYolo08Lp8y4bZNJCnv9MJN3R2/dtCjSBXeygtg9I+YA baAkeJW7ObX8ByCfsiagVrgQ7GiiYJ9tG8cx/MprSXDQq/Zukyyvfvfb33PM5Gorvv4lYjrb6TlyP rQFjcB2g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMmxX-0000000A5Kb-3gIa; Thu, 27 Jun 2024 11:06:35 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMmwH-0000000A4z4-0Zbu for linux-arm-kernel@lists.infradead.org; Thu, 27 Jun 2024 11:05:26 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id EA676CE2E1C; Thu, 27 Jun 2024 11:05:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D26D4C2BBFC; Thu, 27 Jun 2024 11:05:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719486313; bh=CHPj1ScjgYdVyznC3pgzpXrR/68/AlaRg0dR6cJ7qLc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=T8XMc63rUSyUjf3w5SjrCw9rLNMNNrHG2wu4Ani4jr+NFkzmU9opOMAJd6YXCGKOY UvksEtyOvS1wJLAQcfgHBim+uBvp7DCHS6036/foKPAO/2s3htlsSNV42V8G1NCuSz 00nZ9axcC2P6SAOQj0qaUl5R+tWd9ovzz3eyJ0R66mRdK3+zAZMyPEBxluF+UNR/ke o2YH4vdA7+f2Uxe6zFyPTj0kd/eiR7i5N9QKJxHrVcp5aGS4wG9ORZewWd050RCtK/ qVTIuXIW8AN3Od9Nwb9X1miOZCgoIjjxEh0vsVrwjAm7xzJ1la5QIuTPWOtp0Bh9OJ TwaVRgqFCPDkg== From: Lorenzo Bianconi To: linux-clk@vger.kernel.org Cc: p.zabel@pengutronix.de, mturquette@baylibre.com, sboyd@kernel.org, lorenzo.bianconi83@gmail.com, conor@kernel.org, linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org, nbd@nbd.name, john@phrozen.org, dd@embedd.com, catalin.marinas@arm.com, will@kernel.org, upstream@airoha.com, angelogioacchino.delregno@collabora.com Subject: [PATCH v4 4/4] clk: en7523: Remove PCIe reset open drain configuration for EN7581 Date: Thu, 27 Jun 2024 13:04:25 +0200 Message-ID: <43276af5f08a554b4ab2e52e8d437fff5c06a732.1719485847.git.lorenzo@kernel.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240627_040517_888878_314BB732 X-CRM114-Status: GOOD ( 12.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org PCIe reset open drain configuration will be managed by pinctrl driver. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Lorenzo Bianconi --- drivers/clk/clk-en7523.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/clk/clk-en7523.c b/drivers/clk/clk-en7523.c index b134821b23c1..e10c73c29ee2 100644 --- a/drivers/clk/clk-en7523.c +++ b/drivers/clk/clk-en7523.c @@ -37,8 +37,6 @@ #define REG_PCIE1_MEM_MASK 0x0c #define REG_PCIE2_MEM 0x10 #define REG_PCIE2_MEM_MASK 0x14 -#define REG_PCIE_RESET_OPEN_DRAIN 0x018c -#define REG_PCIE_RESET_OPEN_DRAIN_MASK GENMASK(2, 0) #define REG_NP_SCU_PCIC 0x88 #define REG_NP_SCU_SSTR 0x9c #define REG_PCIE_XSI0_SEL_MASK GENMASK(14, 13) @@ -85,8 +83,7 @@ struct en_clk_soc_data { const u16 *idx_map; u16 idx_map_nr; } reset; - int (*hw_init)(struct platform_device *pdev, void __iomem *base, - void __iomem *np_base); + int (*hw_init)(struct platform_device *pdev, void __iomem *np_base); }; static const u32 gsw_base[] = { 400000000, 500000000 }; @@ -411,7 +408,6 @@ static void en7581_pci_disable(struct clk_hw *hw) } static int en7581_clk_hw_init(struct platform_device *pdev, - void __iomem *base, void __iomem *np_base) { void __iomem *pb_base; @@ -434,10 +430,6 @@ static int en7581_clk_hw_init(struct platform_device *pdev, writel(0x28000000, pb_base + REG_PCIE2_MEM); writel(0xfc000000, pb_base + REG_PCIE2_MEM_MASK); - val = readl(base + REG_PCIE_RESET_OPEN_DRAIN); - writel(val | REG_PCIE_RESET_OPEN_DRAIN_MASK, - base + REG_PCIE_RESET_OPEN_DRAIN); - return 0; } @@ -577,7 +569,7 @@ static int en7523_clk_probe(struct platform_device *pdev) soc_data = device_get_match_data(&pdev->dev); if (soc_data->hw_init) { - r = soc_data->hw_init(pdev, base, np_base); + r = soc_data->hw_init(pdev, np_base); if (r) return r; }