| Message ID | 44fcf525273b32c9afcd7e99acbd346d47f0e047.1628603162.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | iommu: APPLE_DART should depend on ARCH_APPLE | expand |
Good catch, thanks! Acked-by: Sven Peter <sven@svenpeter.dev> Sven On Tue, Aug 10, 2021, at 15:47, Geert Uytterhoeven wrote: > The Apple DART (Device Address Resolution Table) IOMMU is only present > on Apple ARM SoCs like the M1. Hence add a dependency on ARCH_APPLE, to > prevent asking the user about this driver when configuring a kernel > without support for the Apple Silicon SoC family. > > Fixes: 05ce9d20d699b093 ("iommu/dart: Add DART iommu driver") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > drivers/iommu/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig > index dfe81da483e9e073..e908b8222e4ed679 100644 > --- a/drivers/iommu/Kconfig > +++ b/drivers/iommu/Kconfig > @@ -292,7 +292,7 @@ config SPAPR_TCE_IOMMU > > config APPLE_DART > tristate "Apple DART IOMMU Support" > - depends on ARM64 || (COMPILE_TEST && !GENERIC_ATOMIC64) > + depends on ARCH_APPLE || (COMPILE_TEST && !GENERIC_ATOMIC64) > select IOMMU_API > select IOMMU_IO_PGTABLE_LPAE > default ARCH_APPLE > -- > 2.25.1 > >
On Tue, Aug 10, 2021 at 03:47:19PM +0200, Geert Uytterhoeven wrote: > The Apple DART (Device Address Resolution Table) IOMMU is only present > on Apple ARM SoCs like the M1. Hence add a dependency on ARCH_APPLE, to > prevent asking the user about this driver when configuring a kernel > without support for the Apple Silicon SoC family. > > Fixes: 05ce9d20d699b093 ("iommu/dart: Add DART iommu driver") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > drivers/iommu/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig > index dfe81da483e9e073..e908b8222e4ed679 100644 > --- a/drivers/iommu/Kconfig > +++ b/drivers/iommu/Kconfig > @@ -292,7 +292,7 @@ config SPAPR_TCE_IOMMU > > config APPLE_DART > tristate "Apple DART IOMMU Support" > - depends on ARM64 || (COMPILE_TEST && !GENERIC_ATOMIC64) > + depends on ARCH_APPLE || (COMPILE_TEST && !GENERIC_ATOMIC64) > select IOMMU_API > select IOMMU_IO_PGTABLE_LPAE > default ARCH_APPLE Dropped the Fixes tag, as this doesn't fix any real issue. Otherwise applied with adjusted subject (iommu: -> iommu/dart:), Thanks.
diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig index dfe81da483e9e073..e908b8222e4ed679 100644 --- a/drivers/iommu/Kconfig +++ b/drivers/iommu/Kconfig @@ -292,7 +292,7 @@ config SPAPR_TCE_IOMMU config APPLE_DART tristate "Apple DART IOMMU Support" - depends on ARM64 || (COMPILE_TEST && !GENERIC_ATOMIC64) + depends on ARCH_APPLE || (COMPILE_TEST && !GENERIC_ATOMIC64) select IOMMU_API select IOMMU_IO_PGTABLE_LPAE default ARCH_APPLE
The Apple DART (Device Address Resolution Table) IOMMU is only present on Apple ARM SoCs like the M1. Hence add a dependency on ARCH_APPLE, to prevent asking the user about this driver when configuring a kernel without support for the Apple Silicon SoC family. Fixes: 05ce9d20d699b093 ("iommu/dart: Add DART iommu driver") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/iommu/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)