Message ID | 4720038.3sLXXjk50c@wuerfel (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org> X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id ED2819F38D for <patchwork-linux-arm@patchwork.kernel.org>; Fri, 8 Jan 2016 21:55:16 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2FACE201DD for <patchwork-linux-arm@patchwork.kernel.org>; Fri, 8 Jan 2016 21:55:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 56D8C201C8 for <patchwork-linux-arm@patchwork.kernel.org>; Fri, 8 Jan 2016 21:55:15 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aHeyI-0006Zq-Nv; Fri, 08 Jan 2016 21:53:22 +0000 Received: from mout.kundenserver.de ([212.227.126.133]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aHeyF-0006YM-N5 for linux-arm-kernel@lists.infradead.org; Fri, 08 Jan 2016 21:53:20 +0000 Received: from wuerfel.localnet ([134.3.118.24]) by mrelayeu.kundenserver.de (mreue003) with ESMTPSA (Nemesis) id 0LzWX0-1a5CGx1Nly-014jaz; Fri, 08 Jan 2016 22:52:49 +0100 From: Arnd Bergmann <arnd@arndb.de> To: Theodore Ts'o <tytso@mit.edu> Subject: [PATCH] ext4: fix ext4_ioctl_setproject return code Date: Fri, 08 Jan 2016 22:52:44 +0100 Message-ID: <4720038.3sLXXjk50c@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 X-Provags-ID: V03:K0:EHyPgC2ewMPbBlznAMHRec34nv318RoOKDHA1Nkors34FvaAwHV NeeV0T0ZMqWoTjxwcS5UlVBjMXlIpvceQdXpVdtgQZ/5s3kVEJwvB2qkNC+GE0IHiafsSbU JnEDryJEc2YcllYTXy6GKey+73CuKOJ2ymYMSav5VVN0Aesqi9SJACP5TZPBY0DqOU3ivRM 3vWb7vlppM1/URSZxjFvw== X-UI-Out-Filterresults: notjunk:1; V01:K0:bH/gPzdYmyI=:FKDZM/xsqUeRALbcg3MxUg 3nf1zbNwIZuRHOa1o3WXaasbJ3ChVBhcWK+xwk9ZE320hqUUGpKqt5OB4TJx4/QcmetRIAPrA LlHEjHBwQX5HJDg7gElrm7xNXQx6mHKezdE9Gv09ENzZ9LfppsNMkoIt4NL3BkNL3kgQBGyAE 161sBFFeVVMXBWzYVrMbCZ6/xJVItgN/+FFmYY8TLEVAJNexMakzLib70SB1rEo0TqG04dx5l 2Or5LufhnkBeyYuBhClcRNsw9YDfW8G2DpFInpTulq1YFwdvZ9z/qwLKzA2dWi4KWHbhBQk25 paP5P8TF74d/fUeuPRhY0H14ePcPCdcN1IzhDKX6LjVdtgHfcFWVT/T4wzgbjOeITHJ8yN/cn G1Zun60fcH3r1RcpUQyfvQD1inJZx8+u1/dc2x+tSnn97DUNdEyfPwMLIN5Q+EuFBX/9GFEuQ KGgk2jIDVVlauZswCC7FRy2J+MwzSTaLk3f6So8GmK7i+KOfbR3kzLzHHt/xhhGjxPtJljEIB zw82uIhZdsa3kZS+b3QDtGJvjyOupi2EY0GZ+/hgInlyI5swTSjPlkanBqSQ5gcgeXOy05749 XhfBQhsZnQqBChGdV4lXUSr0N5GwQgwTGVH4not1gPI9McplaOsU59lXB39YX9tSnBnG0BpvD f/faT/VnVwvUSXuPuuh4b8+aC9sHmFkYLNAFREObRdWRAw3OddPlGBSKijv/ci4asp5ILD3TV bhk4XQYE9bux4N/H X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160108_135320_236391_E81D8AB6 X-CRM114-Status: GOOD ( 11.94 ) X-Spam-Score: -1.9 (-) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: <linux-arm-kernel.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> Cc: Jan Kara <jack@suse.cz>, Li Xi <lixi@ddn.com>, linux-kernel@vger.kernel.org, Andreas Dilger <adilger.kernel@dilger.ca>, linux-ext4@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP |
diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c index c1d45aaa7d55..946560cb3fe6 100644 --- a/fs/ext4/ioctl.c +++ b/fs/ext4/ioctl.c @@ -423,6 +423,7 @@ static int ext4_ioctl_setproject(struct file *filp, __u32 projid) { if (projid != EXT4_DEF_PROJID) return -EOPNOTSUPP; + return 0; } #endif
The newly introduced ext4_ioctl_setproject() functions comes in two versions, one is fine and the other has an undefined return value, as indicated by a compiler warning: fs/ext4/ioctl.c:426:1: warning: control reaches end of non-void function [-Wreturn-type] fs/ext4/ioctl.c: In function 'ext4_ioctl_setproject': This changes the function to return zero on success, as the other version does. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Fixes: e14c6dbc6429 ("ext4: add FS_IOC_FSSETXATTR/FS_IOC_FSGETXATTR interface support") --- Found on ARM randconfig testing on the last two linux-next releases.