From patchwork Sun Mar 12 00:30:53 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Longerbeam X-Patchwork-Id: 9619189 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 13097604A9 for ; Sun, 12 Mar 2017 00:31:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 04868285B0 for ; Sun, 12 Mar 2017 00:31:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id ECBA2285B5; Sun, 12 Mar 2017 00:31:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A6DFC285B0 for ; Sun, 12 Mar 2017 00:31:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:To:Subject:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=h7EsBADEY6wPmzyC4VvXm/sZQUR3Y3Zyojq5Z+3IB6M=; b=U9SIKSRE4oGSUWXn+sgN4eVXX iO9oU2g5daupk7Y14DR2KitIPAiN/ODHQt3yxVqba/KkEDBhMwloyCQL4D1g+W0ecRlH3GGOWMg+K uEtaqbvodt9bthy+2XjB+TpXHhCsryquQ3YA1YqPhwRlaLDCRP6rC0NKANI8RPvXO9Isrf0sV0w5A /9ODq7ph/RGzasX4keCChsTtnqzWm+ChGzsxrL2XizLRJbbWH2e6qZnJk/tFJIxPtfH5GWxsvVIIy qGUb5VjBG/3t+rJmXtSl7cBaHwmMFaR/XbsWdrR0i78p56QIhW5z7Qyv4TAVdUL4tMSedwDVxa/x4 NFMD9aujA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cmrPt-0004mQ-9Q; Sun, 12 Mar 2017 00:31:21 +0000 Received: from mail-pg0-x242.google.com ([2607:f8b0:400e:c05::242]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cmrPq-0004lC-2K for linux-arm-kernel@lists.infradead.org; Sun, 12 Mar 2017 00:31:19 +0000 Received: by mail-pg0-x242.google.com with SMTP id g2so9815107pge.2 for ; Sat, 11 Mar 2017 16:30:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to; bh=n3iGcn63Bdd1p9DcBt7nVhtMKRxBthukowVHzOPuRU4=; b=BEt43O4lLy/3qU+V0MnOuc9ojLemC9ID9Jdm8ckIaocrWadkGzF47zcThscKbW5tlW fVQkha4s+avuzU3MP2Q7Rae4ipFpzyqtv78Oo+sjUc9zu4NiugKh7reJrQ146ezFesYP PVu7zNgj/0Y+/WXAjiJgW54ze+8DyFS878KVmPPoppdf0BiXssw4ShyDvlvR6i4PeXxW +xyXqNtV/q+2y58iPlg3ioS0iGXl704azvDgEKMeVQnkoAe2EtT9G/ghTrwzXXP3YqF6 CsSJbD0US4fWMou8NhtMOh319Q5IzZ+X6fbwC+fVQs+ogNM/xXraJiGnWwbGk0+rUSGK CCxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to; bh=n3iGcn63Bdd1p9DcBt7nVhtMKRxBthukowVHzOPuRU4=; b=ByoWWdZnoPPG6+ZF8HWIzxb/WwBFd2QKhqfN8+NgFXiiblGy+Giarq7W1vqc4aWwLl 1LZsHIa7S2n4T9dgD4Tqzvp5gFdB+4EX0wuGi0VfPdTC0tTceLnJ9sY3iOU3Hf10eJ22 xpLp4ILHgR+SiPj74U4ulphJ8MyKC2VSxKrdqKwTOvbpnsLIwdQZTThX6jVdPYS9G5hY K3msMO+eB+pwxlphyNAKnxVWke98Xk+gemet2VnbMUVxPrzBcCgp4Ilk2Jg+dVmY0PNY NhZxigHSk41i/qXsSWn+ODvwQibccnwJxnb0LVSNMHCvymsI56tfXxe3pYfCKNJSttWV MxLg== X-Gm-Message-State: AMke39mzUhzca/aqPEyhhyDs/eHAxw6m8xmJH+EnhIjmgBs3KFZkVGQ9puZaOI/lybdRUQ== X-Received: by 10.99.139.196 with SMTP id j187mr28022336pge.105.1489278657271; Sat, 11 Mar 2017 16:30:57 -0800 (PST) Received: from [192.168.1.59] (c-98-210-181-167.hsd1.ca.comcast.net. [98.210.181.167]) by smtp.gmail.com with ESMTPSA id r12sm26227101pgn.26.2017.03.11.16.30.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 11 Mar 2017 16:30:55 -0800 (PST) Subject: Re: [PATCH v5 00/39] i.MX Media Driver To: Russell King - ARM Linux References: <1489121599-23206-1-git-send-email-steve_longerbeam@mentor.com> <20170310201356.GA21222@n2100.armlinux.org.uk> From: Steve Longerbeam Message-ID: <47542ef8-3e91-b4cd-cc65-95000105f172@gmail.com> Date: Sat, 11 Mar 2017 16:30:53 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170310201356.GA21222@n2100.armlinux.org.uk> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170311_163118_169487_8035200C X-CRM114-Status: GOOD ( 14.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, andrew-ct.chen@mediatek.com, minghsiu.tsai@mediatek.com, sakari.ailus@linux.intel.com, nick@shmanahar.org, songjun.wu@microchip.com, hverkuil@xs4all.nl, Steve Longerbeam , pavel@ucw.cz, robert.jarzmik@free.fr, devel@driverdev.osuosl.org, markus.heiser@darmarIT.de, laurent.pinchart+renesas@ideasonboard.com, shuah@kernel.org, geert@linux-m68k.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, kernel@pengutronix.de, arnd@arndb.de, mchehab@kernel.org, bparrot@ti.com, robh+dt@kernel.org, horms+renesas@verge.net.au, tiffany.lin@mediatek.com, linux-arm-kernel@lists.infradead.org, niklas.soderlund+renesas@ragnatech.se, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, jean-christophe.trotin@st.com, p.zabel@pengutronix.de, fabio.estevam@nxp.com, shawnguo@kernel.org, sudipm.mukherjee@gmail.com Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On 03/10/2017 12:13 PM, Russell King - ARM Linux wrote: > Version 5 gives me no v4l2 controls exposed through the video device > interface. > > Just like with version 4, version 5 is completely useless with IMX219: > > imx6-mipi-csi2: LP-11 timeout, phy_state = 0x00000200 > ipu1_csi0: pipeline start failed with -110 > imx6-mipi-csi2: LP-11 timeout, phy_state = 0x00000200 > ipu1_csi0: pipeline start failed with -110 > imx6-mipi-csi2: LP-11 timeout, phy_state = 0x00000200 > ipu1_csi0: pipeline start failed with -110 > If it's too difficult to get the imx219 csi-2 transmitter into the LP-11 state on power on, perhaps the csi-2 receiver can be a little more lenient on the transmitter and make the LP-11 timeout a warning instead of error-out. Can you try the attached change on top of the version 5 patchset? If that doesn't work then you're just going to have to fix the bug in imx219. Steve diff --git a/drivers/staging/media/imx/imx6-mipi-csi2.c b/drivers/staging/media/imx/imx6-mipi-csi2.c index d8f931e..720bf4d 100644 --- a/drivers/staging/media/imx/imx6-mipi-csi2.c +++ b/drivers/staging/media/imx/imx6-mipi-csi2.c @@ -224,11 +224,8 @@ static int csi2_dphy_wait_stopstate(struct csi2_dev *csi2) ret = readl_poll_timeout(csi2->base + CSI2_PHY_STATE, reg, (reg & mask) == mask, 0, 500000); - if (ret) { - v4l2_err(&csi2->sd, "LP-11 timeout, phy_state = 0x%08x\n", reg); - return ret; - } - + if (ret) + v4l2_warn(&csi2->sd, "LP-11 timeout, phy_state = 0x%08x\n", reg); return 0; }