From patchwork Thu Feb 23 14:45:56 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andreas_F=C3=A4rber?= X-Patchwork-Id: 9588393 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C7F8E60578 for ; Thu, 23 Feb 2017 14:46:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B54EA2877C for ; Thu, 23 Feb 2017 14:46:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A8D3A2877F; Thu, 23 Feb 2017 14:46:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 2482E2877C for ; Thu, 23 Feb 2017 14:46:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GIpZQiXKgKoMi3whaC8rANtnL9kYRL90Djpz4qGNM6Q=; b=BVl09aGgkK8cR8 uH8aDV8z71Jr/YHOHBtf9P4c/Z6SnxQQIl/Fi/EWkiMq0wV4zNV4D2A1Bj4JxfDFCPoMeZajqod1x JUpk3uTXWg+b6ScC4Jtl2GyabLYV8/u3VsP2jDQvX7W4GbYhN8vbepmmO1fNoplCcv4vunrBe7Z23 M2pu6MgOh9esifnpwNWC+OG3zMpDfqGMikvK0FCoso8tW8E3URuW8b5GYwxzPw5FtKaiuRsO3qWqw j6BNtuGUkhiYdZ+6TQkUjMsDyXk7F8TvJ48tRMnD4ffcm1iox4dQzDPtiv9aR4tKsHQ60/BrLTzHj +w2+Fm/EGz64+KwWhRNg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cgufJ-0008Qk-31; Thu, 23 Feb 2017 14:46:41 +0000 Received: from mx2.suse.de ([195.135.220.15]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cguex-0008FM-VZ for linux-arm-kernel@lists.infradead.org; Thu, 23 Feb 2017 14:46:21 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id A8AFBABCC; Thu, 23 Feb 2017 14:45:57 +0000 (UTC) Subject: Re: [PATCH v2 4/8] sound: soc: pxa: Suppress SND_MMP_SOC for arm64 To: Takashi Iwai References: <20170222022929.10540-1-afaerber@suse.de> <20170222022929.10540-5-afaerber@suse.de> <20170222184734.wmkbzfsz4yklofcg@sirena.org.uk> <473e4976-77eb-4b67-e874-ae6bd717ddaa@suse.de> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Organization: SUSE Linux GmbH Message-ID: <48c91f5d-6ff3-af67-c4eb-4e958a7de465@suse.de> Date: Thu, 23 Feb 2017 15:45:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170223_064620_253599_EC5893CE X-CRM114-Status: GOOD ( 13.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: info@andromedabox.org, alsa-devel@alsa-project.org, Eric Miao , linux-kernel@vger.kernel.org, Liam Girdwood , Haojian Zhuang , Jaroslav Kysela , Mark Brown , Daniel Mack , Robert Jarzmik , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Am 23.02.2017 um 15:24 schrieb Takashi Iwai: > On Thu, 23 Feb 2017 15:11:46 +0100, > Andreas Färber wrote: >> Am 22.02.2017 um 19:47 schrieb Mark Brown: >>> Please use subject lines matching the style for the subsystem. This >>> makes it easier for people to identify relevant patches. >> >> Should I make it "ASoC: pxa: ..." then? SND_MMP_SOC selects SND_ARM, >> which in sound/arm/Kconfig says 'Drivers that are implemented on ASoC >> can be found in "ALSA for SoC audio support" section.', which confused >> me about whether or not this is an ASoC compliant driver if it selects a >> non-ASoC symbol. > > It's a bug that selects SND_ARM there. I guess this was wrongly taken > from the old example of AC97 ARM SoC code, which was fixed later. > ASoC stuff is basically irrelevant from the legacy sound/arm/*. Thanks, Takashi-san. I'll update as follows then. Okay to do that in one patch or break up into three? Regards, Andreas diff --git a/sound/soc/pxa/Kconfig b/sound/soc/pxa/Kconfig index f8e1c06..aba7213 100644 --- a/sound/soc/pxa/Kconfig +++ b/sound/soc/pxa/Kconfig @@ -9,10 +9,9 @@ config SND_PXA2XX_SOC config SND_MMP_SOC bool "SoC Audio for Marvell MMP chips" - depends on ARCH_MMP && ARM - select MMP_SRAM + depends on ARCH_MMP || COMPILE_TEST + select MMP_SRAM if ARM select SND_SOC_GENERIC_DMAENGINE_PCM - select SND_ARM help Say Y if you want to add support for codecs attached to the MMP SSPA interface.