| Message ID | 4cac19e32295c708d72b9fc6ba342b5c961fb6c3.1739221064.git.Ryan.Wanner@microchip.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Enable Power Modes Support for SAMA7D65 SoC | expand |
On Mon, Feb 10, 2025 at 02:13:02PM -0700, Ryan.Wanner@microchip.com wrote: > From: Ryan Wanner <Ryan.Wanner@microchip.com> > > Add SAMA7D65 SFRBU compatible string to DT bindings documentation > > Signed-off-by: Ryan Wanner <Ryan.Wanner@microchip.com> > --- > Documentation/devicetree/bindings/mfd/syscon.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml > index 51d896c88dafa..727292ffe092e 100644 > --- a/Documentation/devicetree/bindings/mfd/syscon.yaml > +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml > @@ -91,6 +91,7 @@ select: > - microchip,mpfs-sysreg-scb > - microchip,sam9x60-sfr > - microchip,sama7d65-ddr3phy > + - microchip,sama7d65-sfrbu You got comment on #1 of your v1, so if you make exactly the same mistake in other patches then fix it there as well. Apply v1 Rob's comments to all your patches. Best regards, Krzysztof
On Tue, Feb 11, 2025 at 09:14:05AM +0100, Krzysztof Kozlowski wrote: > On Mon, Feb 10, 2025 at 02:13:02PM -0700, Ryan.Wanner@microchip.com wrote: > > From: Ryan Wanner <Ryan.Wanner@microchip.com> > > > > Add SAMA7D65 SFRBU compatible string to DT bindings documentation > > > > Signed-off-by: Ryan Wanner <Ryan.Wanner@microchip.com> > > --- > > Documentation/devicetree/bindings/mfd/syscon.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml > > index 51d896c88dafa..727292ffe092e 100644 > > --- a/Documentation/devicetree/bindings/mfd/syscon.yaml > > +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml > > @@ -91,6 +91,7 @@ select: > > - microchip,mpfs-sysreg-scb > > - microchip,sam9x60-sfr > > - microchip,sama7d65-ddr3phy > > + - microchip,sama7d65-sfrbu > > You got comment on #1 of your v1, so if you make exactly the same > mistake in other patches then fix it there as well. > > Apply v1 Rob's comments to all your patches. Actually, this patch v1 did put it in both lists, but here it got dropped from the second list: https://lore.kernel.org/all/20250130233431.GB1868322-robh@kernel.org/
On 13/02/2025 21:30, Conor Dooley wrote: >>> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml >>> index 51d896c88dafa..727292ffe092e 100644 >>> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml >>> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml >>> @@ -91,6 +91,7 @@ select: >>> - microchip,mpfs-sysreg-scb >>> - microchip,sam9x60-sfr >>> - microchip,sama7d65-ddr3phy >>> + - microchip,sama7d65-sfrbu >> >> You got comment on #1 of your v1, so if you make exactly the same >> mistake in other patches then fix it there as well. >> >> Apply v1 Rob's comments to all your patches. > > Actually, this patch v1 did put it in both lists, but here it got > dropped from the second list: > https://lore.kernel.org/all/20250130233431.GB1868322-robh@kernel.org/ That's even weirder... Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml index 51d896c88dafa..727292ffe092e 100644 --- a/Documentation/devicetree/bindings/mfd/syscon.yaml +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml @@ -91,6 +91,7 @@ select: - microchip,mpfs-sysreg-scb - microchip,sam9x60-sfr - microchip,sama7d65-ddr3phy + - microchip,sama7d65-sfrbu - microchip,sama7g5-ddr3phy - mscc,ocelot-cpu-syscon - mstar,msc313-pmsleep