From patchwork Tue Nov 6 14:54:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 10670633 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D0FEC14E2 for ; Tue, 6 Nov 2018 14:55:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BDEF82A4DC for ; Tue, 6 Nov 2018 14:55:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B1C522A4E0; Tue, 6 Nov 2018 14:55:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 26C4A2A4DC for ; Tue, 6 Nov 2018 14:55:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lZViLrBbP3YIHoA76nsWiO1Ax6SG2ubhB27+39Txnns=; b=kYJNhkHcqPr/If bqAfK2kJpfAOf5SVTxAxuStAwLaxvPEU4JTEIcXVtQ5n/+uSwUBXTyQamvupJkPtDDVr2JgSW3Zat sXRfOeLLIlChbQ+zUBRS0clMFduxJrO09tXeCMJQj2+9sZ93OXtUG9nyZIQl/DQ3S1CY3kNeJ9xlZ SLiQjeuQA1lkH/XUlORMYceHyOStRryjX+hmFTO+zPVt18bKICMsfHKeE7tGFC5QTUkIsdiz2twvR Zqo7tO8Z08HdVJdUfWB1D6VZm/O2haAlUVxy7vzZlD1q+/E2QlMwTLh1OuN3ztMTIWJPC6kUGqQ3m qaZvzsw9bmVJh9leDKlQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gK2lm-0003t1-Q9; Tue, 06 Nov 2018 14:55:54 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gK2kr-0001lP-Ij for linux-arm-kernel@bombadil.infradead.org; Tue, 06 Nov 2018 14:54:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=LoKhVbHFgXHM/cPXU02lAwA9nzs4scFwPA3WQ0y4+98=; b=nZq/iFODNUeS6SsiyjGToxVrKo hdhbPAlqFG6YJhnfFYzzwQUF6J76tPNaeUwAyqR2y+nmj/OSh7CmQrbAktk2im/ZaNsSC7CW1Fi52 u3XQzBj0A9oV7B8pSYOTtjr+kq4EysF//Iv3N3hmbDe3VkcSlBvveU/L6guUwQoZ1Z7CumSmk8g4a 98nFZgGYvE9ftDeBA/W96uIE86cR4MKDHlE4ZMxKO9ZSEDPaxfzujIP5fAuNW3rPdzL7caoVVYDX/ 3Lmdmq2Q2pSgr+P6bxR/QNXYeqvPT4bNE+dxv/0wqoYBtIBUEE1HY0afF9RIjpI0YuYZB6CwNmRar JadmRxpw==; Received: from mail.bootlin.com ([62.4.15.54]) by merlin.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gK2ko-0007RG-LS for linux-arm-kernel@lists.infradead.org; Tue, 06 Nov 2018 14:54:55 +0000 Received: by mail.bootlin.com (Postfix, from userid 110) id 9686D20741; Tue, 6 Nov 2018 15:54:37 +0100 (CET) Received: from localhost (unknown [185.94.189.188]) by mail.bootlin.com (Postfix) with ESMTPSA id 4E693207D0; Tue, 6 Nov 2018 15:54:27 +0100 (CET) From: Maxime Ripard To: Kishon Vijay Abraham I , Boris Brezillon Subject: [PATCH v2 4/9] phy: dphy: Add configuration helpers Date: Tue, 6 Nov 2018 15:54:16 +0100 Message-Id: <4d44460c4ecbd47f4cbd9141c6bf2632b6c21e1e.1541516029.git-series.maxime.ripard@bootlin.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181106_095454_911192_995412E4 X-CRM114-Status: GOOD ( 20.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Archit Taneja , Rafal Ciepiela , Krzysztof Witos , Maxime Ripard , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Andrzej Hajda , Chen-Yu Tsai , Laurent Pinchart , Thomas Petazzoni , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The MIPI D-PHY spec defines default values and boundaries for most of the parameters it defines. Introduce helpers to help drivers get meaningful values based on their current parameters, and validate the boundaries of these parameters if needed. Signed-off-by: Maxime Ripard --- drivers/phy/Kconfig | 8 ++- drivers/phy/Makefile | 1 +- drivers/phy/phy-core-mipi-dphy.c | 160 +++++++++++++++++++++++++++++++- include/linux/phy/phy-mipi-dphy.h | 6 +- 4 files changed, 175 insertions(+) create mode 100644 drivers/phy/phy-core-mipi-dphy.c diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index 60f949e2a684..c87a7d49eaab 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -15,6 +15,14 @@ config GENERIC_PHY phy users can obtain reference to the PHY. All the users of this framework should select this config. +config GENERIC_PHY_MIPI_DPHY + bool + help + Generic MIPI D-PHY support. + + Provides a number of helpers a core functions for MIPI D-PHY + drivers to us. + config PHY_LPC18XX_USB_OTG tristate "NXP LPC18xx/43xx SoC USB OTG PHY driver" depends on OF && (ARCH_LPC18XX || COMPILE_TEST) diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile index 0301e25d07c1..baec59cebbab 100644 --- a/drivers/phy/Makefile +++ b/drivers/phy/Makefile @@ -4,6 +4,7 @@ # obj-$(CONFIG_GENERIC_PHY) += phy-core.o +obj-$(CONFIG_GENERIC_PHY_MIPI_DPHY) += phy-core-mipi-dphy.o obj-$(CONFIG_PHY_LPC18XX_USB_OTG) += phy-lpc18xx-usb-otg.o obj-$(CONFIG_PHY_XGENE) += phy-xgene.o obj-$(CONFIG_PHY_PISTACHIO_USB) += phy-pistachio-usb.o diff --git a/drivers/phy/phy-core-mipi-dphy.c b/drivers/phy/phy-core-mipi-dphy.c new file mode 100644 index 000000000000..127ca6960084 --- /dev/null +++ b/drivers/phy/phy-core-mipi-dphy.c @@ -0,0 +1,160 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Copyright (C) 2013 NVIDIA Corporation + * Copyright (C) 2018 Cadence Design Systems Inc. + */ + +#include +#include +#include +#include + +#include +#include + +/* + * Minimum D-PHY timings based on MIPI D-PHY specification. Derived + * from the valid ranges specified in Section 6.9, Table 14, Page 41 + * of the D-PHY specification (v2.1). + */ +int phy_mipi_dphy_get_default_config(unsigned long pixel_clock, + unsigned int bpp, + unsigned int lanes, + struct phy_configure_opts_mipi_dphy *cfg) +{ + unsigned long hs_clk_rate; + unsigned long ui; + + if (!cfg) + return -EINVAL; + + hs_clk_rate = pixel_clock * bpp / lanes; + ui = DIV_ROUND_UP(NSEC_PER_SEC, hs_clk_rate); + + cfg->clk_miss = 0; + cfg->clk_post = 60 + 52 * ui; + cfg->clk_pre = 8; + cfg->clk_prepare = 38; + cfg->clk_settle = 95; + cfg->clk_term_en = 0; + cfg->clk_trail = 60; + cfg->clk_zero = 262; + cfg->d_term_en = 0; + cfg->eot = 0; + cfg->hs_exit = 100; + cfg->hs_prepare = 40 + 4 * ui; + cfg->hs_zero = 105 + 6 * ui; + cfg->hs_settle = 85 + 6 * ui; + cfg->hs_skip = 40; + + /* + * The MIPI D-PHY specification (Section 6.9, v1.2, Table 14, Page 40) + * contains this formula as: + * + * T_HS-TRAIL = max(n * 8 * ui, 60 + n * 4 * ui) + * + * where n = 1 for forward-direction HS mode and n = 4 for reverse- + * direction HS mode. There's only one setting and this function does + * not parameterize on anything other that ui, so this code will + * assumes that reverse-direction HS mode is supported and uses n = 4. + */ + cfg->hs_trail = max(4 * 8 * ui, 60 + 4 * 4 * ui); + + cfg->init = 100000; + cfg->lpx = 60; + cfg->ta_get = 5 * cfg->lpx; + cfg->ta_go = 4 * cfg->lpx; + cfg->ta_sure = 2 * cfg->lpx; + cfg->wakeup = 1000000; + + cfg->hs_clk_rate = hs_clk_rate; + cfg->lanes = lanes; + + return 0; +} +EXPORT_SYMBOL(phy_mipi_dphy_get_default_config); + +/* + * Validate D-PHY configuration according to MIPI D-PHY specification + * (v1.2, Section Section 6.9 "Global Operation Timing Parameters"). + */ +int phy_mipi_dphy_config_validate(struct phy_configure_opts_mipi_dphy *cfg) +{ + unsigned long ui; + + if (!cfg) + return -EINVAL; + + ui = DIV_ROUND_UP(NSEC_PER_SEC, cfg->hs_clk_rate); + + if (cfg->clk_miss > 60) + return -EINVAL; + + if (cfg->clk_post < (60 + 52 * ui)) + return -EINVAL; + + if (cfg->clk_pre < 8) + return -EINVAL; + + if (cfg->clk_prepare < 38 || cfg->clk_prepare > 95) + return -EINVAL; + + if (cfg->clk_settle < 95 || cfg->clk_settle > 300) + return -EINVAL; + + if (cfg->clk_term_en > 38) + return -EINVAL; + + if (cfg->clk_trail < 60) + return -EINVAL; + + if (cfg->clk_prepare + cfg->clk_zero < 300) + return -EINVAL; + + if (cfg->d_term_en > 35 + 4 * ui) + return -EINVAL; + + if (cfg->eot > 105 + 12 * ui) + return -EINVAL; + + if (cfg->hs_exit < 100) + return -EINVAL; + + if (cfg->hs_prepare < 40 + 4 * ui || + cfg->hs_prepare > 85 + 6 * ui) + return -EINVAL; + + if (cfg->hs_prepare + cfg->hs_zero < 145 + 10 * ui) + return -EINVAL; + + if ((cfg->hs_settle < 85 + 6 * ui) || + (cfg->hs_settle > 145 + 10 * ui)) + return -EINVAL; + + if (cfg->hs_skip < 40 || cfg->hs_skip > 55 + 4 * ui) + return -EINVAL; + + if (cfg->hs_trail < max(8 * ui, 60 + 4 * ui)) + return -EINVAL; + + if (cfg->init < 100000) + return -EINVAL; + + if (cfg->lpx < 50) + return -EINVAL; + + if (cfg->ta_get != 5 * cfg->lpx) + return -EINVAL; + + if (cfg->ta_go != 4 * cfg->lpx) + return -EINVAL; + + if (cfg->ta_sure < cfg->lpx || cfg->ta_sure > 2 * cfg->lpx) + return -EINVAL; + + if (cfg->wakeup < 1000000) + return -EINVAL; + + return 0; +} +EXPORT_SYMBOL(phy_mipi_dphy_config_validate); diff --git a/include/linux/phy/phy-mipi-dphy.h b/include/linux/phy/phy-mipi-dphy.h index 0b05932916af..5e3673778afa 100644 --- a/include/linux/phy/phy-mipi-dphy.h +++ b/include/linux/phy/phy-mipi-dphy.h @@ -229,4 +229,10 @@ struct phy_configure_opts_mipi_dphy { unsigned char lanes; }; +int phy_mipi_dphy_get_default_config(unsigned long pixel_clock, + unsigned int bpp, + unsigned int lanes, + struct phy_configure_opts_mipi_dphy *cfg); +int phy_mipi_dphy_config_validate(struct phy_configure_opts_mipi_dphy *cfg); + #endif /* __PHY_MIPI_DPHY_H_ */