From patchwork Wed Jan 4 14:54:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jens Axboe X-Patchwork-Id: 13088686 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6CE60C46467 for ; Wed, 4 Jan 2023 15:16:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:From:Cc:To:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=d1UNF9zJc78wPdwrT2dTcsr4oXW5m5lqM+OAxNIlfh4=; b=sfPw1aay82d4xG GZCaOlPpkBkl7ANVqKZrWd2AoTEEN23NrxTdglD81pcH/BE868ZiyrNVp5Rkj6Cxgg3BsuDwW5Lxb hMBK6iT/dcRoBZe92tOD1XPkDbB5xb0U1esC5PweqShjjoU+YRv8L52yowRopu5RxU1w7n3dlI+Nq a+0jPv18Op9jpWANxMrgn1oGZZmVjsCLEGB+WqDAcP2KqX+XWTYuqdifh1exGP4KafhqZRC3mKFZr 6vUKZwF82g1X3gwHCUxtmjCK8UICCjofbYlxygEc7i7X37+3+rxuPXUAnVd9cc2RscBcispPUde75 KHy3AaVapDlqNdqrC6Tw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pD5Te-00A0is-Iv; Wed, 04 Jan 2023 15:14:53 +0000 Received: from mail-io1-xd2d.google.com ([2607:f8b0:4864:20::d2d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pD5AT-009sOt-I6 for linux-arm-kernel@lists.infradead.org; Wed, 04 Jan 2023 14:55:03 +0000 Received: by mail-io1-xd2d.google.com with SMTP id g20so18121215iob.2 for ; Wed, 04 Jan 2023 06:55:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:subject:from:cc:to:content-language :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=W0BcGWobwzi6/Wce6RmIaLMPhE9xq+zsKPoIkbrKs+M=; b=d6u6nxE2AaM0DJa77K3fm2kU7MZiw0OApdYV46xoQc5qj6qzZLjXqbSgB17YDqSymD vDb9+yPUQjWzrgfLMFKQrqW1eJY5rb5YVVo6d73T0Veu3DlMDDfPV5Lop0PcwjCtAT0O 4uUqtV+BPMBcEC79uild8RkHFdQNsL358LpOsiCnL7VCQ3k6uX3nMAGPWTfv184IY0xd G1hRHKRGa7fs02hgi3Ox9IbCpcmjuoXjdIkuA+jzFLbHWpCjRazVDbMheOuApOGpyNyu EyH5BL3aRYuW9ApdIqSTlTBRPLtI9Ne2iLId0aSbUsbdzeKqGqOHSEedRsqPO4xkzyVa GioQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:subject:from:cc:to:content-language :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=W0BcGWobwzi6/Wce6RmIaLMPhE9xq+zsKPoIkbrKs+M=; b=tBfBt5JhXZ9GyCw9CxTMa9VhfLLaU9WnJScs6aAvsySpMqTREximIi1eDkHdDNKJqQ 4tZw/I9cYy50FxthuqtNrtBrzk4evPXQxdesSfwJUfoIGKPztH5+Y3veybJZq+TUzUMT ejvNNztAGx2M6zOKHjRoZU0I3Hb/WaV1+oVfruK3EceovBhtVKiOKmAXrO2j1QLjpfCH mzW9/Kwje2B9oMD+cy4O09AkgZdwoUkHIQfbmJPi67eCvF7rjhwweKf8Pan5EpppiU/L cexkTlFxs4MqAhH/krVo+8vyluztV0yjGDndUUCPGMK1aJUQtPQYt9K/32tTPWfiv5VM glXA== X-Gm-Message-State: AFqh2kp8pHqs62291sAyenO/URoNda9EYb359XLK5skZ/dY1PIq8ksRS E1ioiviHO1uxZagKxtA6ZCIIE39mnV0PO3Og X-Google-Smtp-Source: AMrXdXtmLI+qg6U0P5f1XjZWWfBSJHVKGTAqmbbnLHRPx6kQpyfsT7VciKoMHmchf5K3kQjspWm6/A== X-Received: by 2002:a05:6602:1cf:b0:6ed:95f:92e7 with SMTP id w15-20020a05660201cf00b006ed095f92e7mr5435605iot.0.1672844099360; Wed, 04 Jan 2023 06:54:59 -0800 (PST) Received: from [192.168.1.94] ([207.135.234.126]) by smtp.gmail.com with ESMTPSA id y20-20020a056602165400b006eb5f90768csm12325964iow.55.2023.01.04.06.54.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Jan 2023 06:54:58 -0800 (PST) Message-ID: <4f9785c8-a425-66b1-7ab2-64143abf850f@kernel.dk> Date: Wed, 4 Jan 2023 07:54:57 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Content-Language: en-US To: linux-arm-kernel@lists.infradead.org Cc: "Russell King (Oracle)" , Hui Tang From: Jens Axboe Subject: [PATCH] ARM: renumber bits related to _TIF_WORK_MASK X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230104_065501_674490_47B06C65 X-CRM114-Status: GOOD ( 10.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org We want to ensure that the mask related to calling do_work_pending() is within the first 16 bits. Move bits unrelated to that outside of that range, to avoid spuriously calling do_work_pending() when we don't need to. Cc: stable@vger.kernel.org Fixes: 32d59773da38 ("arm: add support for TIF_NOTIFY_SIGNAL") Reported-and-tested-by: Hui Tang Suggested-by: Russell King (Oracle) Link: https://lore.kernel.org/lkml/7ecb8f3c-2aeb-a905-0d4a-aa768b9649b5@huawei.com/ Signed-off-by: Jens Axboe --- Russell, I have this queued up and can send it out other fixes this week. Or let me know if you want to funnel it. Thanks! diff --git a/arch/arm/include/asm/thread_info.h b/arch/arm/include/asm/thread_info.h index aecc403b2880..7f092cb55a41 100644 --- a/arch/arm/include/asm/thread_info.h +++ b/arch/arm/include/asm/thread_info.h @@ -128,15 +128,16 @@ extern int vfp_restore_user_hwstate(struct user_vfp *, #define TIF_NEED_RESCHED 1 /* rescheduling necessary */ #define TIF_NOTIFY_RESUME 2 /* callback before returning to user */ #define TIF_UPROBE 3 /* breakpointed or singlestepping */ -#define TIF_SYSCALL_TRACE 4 /* syscall trace active */ -#define TIF_SYSCALL_AUDIT 5 /* syscall auditing active */ -#define TIF_SYSCALL_TRACEPOINT 6 /* syscall tracepoint instrumentation */ -#define TIF_SECCOMP 7 /* seccomp syscall filtering active */ -#define TIF_NOTIFY_SIGNAL 8 /* signal notifications exist */ +#define TIF_NOTIFY_SIGNAL 4 /* signal notifications exist */ #define TIF_USING_IWMMXT 17 #define TIF_MEMDIE 18 /* is terminating due to OOM killer */ -#define TIF_RESTORE_SIGMASK 20 +#define TIF_RESTORE_SIGMASK 19 +#define TIF_SYSCALL_TRACE 20 /* syscall trace active */ +#define TIF_SYSCALL_AUDIT 21 /* syscall auditing active */ +#define TIF_SYSCALL_TRACEPOINT 22 /* syscall tracepoint instrumentation */ +#define TIF_SECCOMP 23 /* seccomp syscall filtering active */ + #define _TIF_SIGPENDING (1 << TIF_SIGPENDING) #define _TIF_NEED_RESCHED (1 << TIF_NEED_RESCHED)