diff mbox

[1/3] irqchip/mips-gic: pr_err() strings should end with newlines

Message ID 500e0c48a5e46003d33b31a257806a4991c0ff9d.1510580710.git.arvind.yadav.cs@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Arvind Yadav Nov. 13, 2017, 1:53 p.m. UTC 
pr_err() messages should end with a new-line to avoid other messages
being concatenated.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/irqchip/irq-mips-gic.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Marc Zyngier Nov. 13, 2017, 2:39 p.m. UTC | #1 
On 13/11/17 13:53, Arvind Yadav wrote:
> pr_err() messages should end with a new-line to avoid other messages
> being concatenated.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>  drivers/irqchip/irq-mips-gic.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-mips-gic.c b/drivers/irqchip/irq-mips-gic.c
> index c90976d..e87d33b 100644
> --- a/drivers/irqchip/irq-mips-gic.c
> +++ b/drivers/irqchip/irq-mips-gic.c
> @@ -737,7 +737,7 @@ static int __init gic_of_init(struct device_node *node,
>  					       gic_shared_intrs, 0,
>  					       &gic_irq_domain_ops, NULL);
>  	if (!gic_irq_domain) {
> -		pr_err("Failed to add GIC IRQ domain");
> +		pr_err("Failed to add GIC IRQ domain\n");
>  		return -ENXIO;
>  	}
>  
> @@ -746,7 +746,7 @@ static int __init gic_of_init(struct device_node *node,
>  						  GIC_NUM_LOCAL_INTRS + gic_shared_intrs,
>  						  node, &gic_ipi_domain_ops, NULL);
>  	if (!gic_ipi_domain) {
> -		pr_err("Failed to add GIC IPI domain");
> +		pr_err("Failed to add GIC IPI domain\n");
>  		return -ENXIO;
>  	}
>  
> 

This patch doesn't apply to the current state of the irqchip tree, nor
of tip/irq/core. Please verify that it applies and resubmit if required.

I've applied patches 2 and 3.

Thanks,

	M.
diff mbox

Patch

diff --git a/drivers/irqchip/irq-mips-gic.c b/drivers/irqchip/irq-mips-gic.c
index c90976d..e87d33b 100644
--- a/drivers/irqchip/irq-mips-gic.c
+++ b/drivers/irqchip/irq-mips-gic.c
@@ -737,7 +737,7 @@  static int __init gic_of_init(struct device_node *node,
 					       gic_shared_intrs, 0,
 					       &gic_irq_domain_ops, NULL);
 	if (!gic_irq_domain) {
-		pr_err("Failed to add GIC IRQ domain");
+		pr_err("Failed to add GIC IRQ domain\n");
 		return -ENXIO;
 	}
 
@@ -746,7 +746,7 @@  static int __init gic_of_init(struct device_node *node,
 						  GIC_NUM_LOCAL_INTRS + gic_shared_intrs,
 						  node, &gic_ipi_domain_ops, NULL);
 	if (!gic_ipi_domain) {
-		pr_err("Failed to add GIC IPI domain");
+		pr_err("Failed to add GIC IPI domain\n");
 		return -ENXIO;
 	}