From patchwork Thu Sep 6 23:40:27 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ryan Mallon X-Patchwork-Id: 1418501 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 5DAA43FC85 for ; Thu, 6 Sep 2012 23:43:21 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1T9lgc-0008Kw-Ia; Thu, 06 Sep 2012 23:40:39 +0000 Received: from mail-ie0-f177.google.com ([209.85.223.177]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1T9lgZ-0008Kc-S7 for linux-arm-kernel@lists.infradead.org; Thu, 06 Sep 2012 23:40:36 +0000 Received: by ieje10 with SMTP id e10so4229325iej.36 for ; Thu, 06 Sep 2012 16:40:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=h2RcrRF90hoaR2S2tXRs4BoQc2VdUdcvVKEH5fZxLm4=; b=yvTvKRgBYhhMP+55ZQ8LvQFPeoXxW7aQSV3KDLtPMkU5TXbYwqBHcOg8NUa5ms4yfe aTM994qrM8QKrtrzlBDA/m8e3U6zjj38SUzHTmhX9koDIjoJC4XZn1LS6WHVGGXJ95bF UQZU7h89qS+rFzcfRypZ54MZJ7bvdPyQQjMZf++r2NmTbh711GD8QILn5/Uc2xrps6gq j8958510ex1Xun+13sKm8gAMEsAM6Pzq92Aj2GNgfzKR6NLDWbu3pFFrJ0BBMRt/u/TW LVfpTwcUQwX2F7PUZCMPVH1TMCfZTbM7KRigH1R8Qu9sHl5Hsy2NUJalgGCzQtei2Nc6 wbjA== Received: by 10.50.94.138 with SMTP id dc10mr5445518igb.39.1346974833288; Thu, 06 Sep 2012 16:40:33 -0700 (PDT) Received: from [10.21.11.113] (vl10.gw.ok-labs.com. [58.96.27.158]) by mx.google.com with ESMTPS id fu4sm5464316igc.4.2012.09.06.16.40.29 (version=SSLv3 cipher=OTHER); Thu, 06 Sep 2012 16:40:32 -0700 (PDT) Message-ID: <5049346B.5020205@gmail.com> Date: Fri, 07 Sep 2012 09:40:27 +1000 From: Ryan Mallon User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120714 Thunderbird/14.0 MIME-Version: 1.0 To: Axel Lin Subject: Re: [PATCH] ARM: ep93xx: Fix build error due to 'SZ_32M' undeclared References: <1346675368.15950.0.camel@phoenix> In-Reply-To: <1346675368.15950.0.camel@phoenix> X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rmallon[at]gmail.com) -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.223.177 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: Hartley Sweeten , Russell King , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org On 03/09/12 22:29, Axel Lin wrote: > Include linux/sizes.h to fix below build errors: > > CC arch/arm/mach-ep93xx/adssphere.o > arch/arm/mach-ep93xx/adssphere.c: In function 'adssphere_init_machine': > arch/arm/mach-ep93xx/adssphere.c:32:49: error: 'SZ_32M' undeclared (first use in this function) > arch/arm/mach-ep93xx/adssphere.c:32:49: note: each undeclared identifier is reported only once for each function it appears in > make[1]: *** [arch/arm/mach-ep93xx/adssphere.o] Error 1 > make: *** [arch/arm/mach-ep93xx] Error 2 > > CC arch/arm/mach-ep93xx/gesbc9312.o > arch/arm/mach-ep93xx/gesbc9312.c: In function 'gesbc9312_init_machine': > arch/arm/mach-ep93xx/gesbc9312.c:32:49: error: 'SZ_8M' undeclared (first use in this function) > arch/arm/mach-ep93xx/gesbc9312.c:32:49: note: each undeclared identifier is reported only once for each function it appears in > make[1]: *** [arch/arm/mach-ep93xx/gesbc9312.o] Error 1 > make: *** [arch/arm/mach-ep93xx] Error 2 > > Signed-off-by: Axel Lin Hi Axel, The patch looks fine. I notice that the other ep93xx boards are also using the SZ_ defines, but are indirectly including linux/sizes.h via asm/memory.h, which in turn is indirectly included via asm/io.h. That seems a bit flaky, so I wonder if we should just explicitly include in all the board files which use the SZ_ macros as per the patch below. Thoughts? ~Ryan --- ARM: ep93xx: Fix build error due to 'SZ_32M' undeclared Include linux/sizes.h to fix below build errors: CC arch/arm/mach-ep93xx/adssphere.o arch/arm/mach-ep93xx/adssphere.c: In function 'adssphere_init_machine': arch/arm/mach-ep93xx/adssphere.c:32:49: error: 'SZ_32M' undeclared (first use in this function) arch/arm/mach-ep93xx/adssphere.c:32:49: note: each undeclared identifier is reported only once for each function it appears in make[1]: *** [arch/arm/mach-ep93xx/adssphere.o] Error 1 make: *** [arch/arm/mach-ep93xx] Error 2 CC arch/arm/mach-ep93xx/gesbc9312.o arch/arm/mach-ep93xx/gesbc9312.c: In function 'gesbc9312_init_machine': arch/arm/mach-ep93xx/gesbc9312.c:32:49: error: 'SZ_8M' undeclared (first use in this function) arch/arm/mach-ep93xx/gesbc9312.c:32:49: note: each undeclared identifier is reported only once for each function it appears in make[1]: *** [arch/arm/mach-ep93xx/gesbc9312.o] Error 1 make: *** [arch/arm/mach-ep93xx] Error 2 Also explicitly include linux/sizes.h on the other ep93xx which use the SZ_ macros and are currently indirectly including linux/sizes.h via asm/memory.h, which is included via asm/io.h. Signed-off-by: Axel Lin Signed-off-by: Ryan Mallon diff --git a/arch/arm/mach-ep93xx/adssphere.c b/arch/arm/mach-ep93xx/adssphere.c index a472777..41383bf 100644 --- a/arch/arm/mach-ep93xx/adssphere.c +++ b/arch/arm/mach-ep93xx/adssphere.c @@ -13,6 +13,7 @@ #include #include #include +#include #include diff --git a/arch/arm/mach-ep93xx/edb93xx.c b/arch/arm/mach-ep93xx/edb93xx.c index 337ab7c..e34f257 100644 --- a/arch/arm/mach-ep93xx/edb93xx.c +++ b/arch/arm/mach-ep93xx/edb93xx.c @@ -31,6 +31,7 @@ #include #include #include +#include #include diff --git a/arch/arm/mach-ep93xx/gesbc9312.c b/arch/arm/mach-ep93xx/gesbc9312.c index 437c341..7fd705b 100644 --- a/arch/arm/mach-ep93xx/gesbc9312.c +++ b/arch/arm/mach-ep93xx/gesbc9312.c @@ -13,6 +13,7 @@ #include #include #include +#include #include diff --git a/arch/arm/mach-ep93xx/micro9.c b/arch/arm/mach-ep93xx/micro9.c index 3d7cdab..1a8f032 100644 --- a/arch/arm/mach-ep93xx/micro9.c +++ b/arch/arm/mach-ep93xx/micro9.c @@ -15,6 +15,7 @@ #include #include #include +#include #include diff --git a/arch/arm/mach-ep93xx/simone.c b/arch/arm/mach-ep93xx/simone.c index 33dc079..a7c84cf 100644 --- a/arch/arm/mach-ep93xx/simone.c +++ b/arch/arm/mach-ep93xx/simone.c @@ -20,6 +20,7 @@ #include #include #include +#include #include #include diff --git a/arch/arm/mach-ep93xx/snappercl15.c b/arch/arm/mach-ep93xx/snappercl15.c index 01abd35..55acc79 100644 --- a/arch/arm/mach-ep93xx/snappercl15.c +++ b/arch/arm/mach-ep93xx/snappercl15.c @@ -23,6 +23,7 @@ #include #include #include +#include #include #include diff --git a/arch/arm/mach-ep93xx/ts72xx.c b/arch/arm/mach-ep93xx/ts72xx.c index aefda11..2a621af 100644 --- a/arch/arm/mach-ep93xx/ts72xx.c +++ b/arch/arm/mach-ep93xx/ts72xx.c @@ -19,6 +19,7 @@ #include #include #include +#include #include #include diff --git a/arch/arm/mach-ep93xx/vision_ep9307.c b/arch/arm/mach-ep93xx/vision_ep9307.c index 2905a49..4630a97 100644 --- a/arch/arm/mach-ep93xx/vision_ep9307.c +++ b/arch/arm/mach-ep93xx/vision_ep9307.c @@ -28,6 +28,7 @@ #include #include #include +#include #include #include