From patchwork Fri Sep 7 03:17:21 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 1418871 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id AD43840220 for ; Fri, 7 Sep 2012 03:19:42 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1T9p4Q-0006mR-Vt; Fri, 07 Sep 2012 03:17:27 +0000 Received: from wolverine02.qualcomm.com ([199.106.114.251]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1T9p4N-0006lv-7K for linux-arm-kernel@lists.infradead.org; Fri, 07 Sep 2012 03:17:23 +0000 X-IronPort-AV: E=McAfee;i="5400,1158,6827"; a="231592878" Received: from pdmz-ns-mip.qualcomm.com (HELO mostmsg01.qualcomm.com) ([199.106.114.10]) by wolverine02.qualcomm.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 06 Sep 2012 20:17:21 -0700 Received: from [10.46.166.8] (pdmz-ns-snip_218_1.qualcomm.com [192.168.218.1]) by mostmsg01.qualcomm.com (Postfix) with ESMTPA id 8E4EA10004AB; Thu, 6 Sep 2012 20:17:21 -0700 (PDT) Message-ID: <50496741.8000305@codeaurora.org> Date: Thu, 06 Sep 2012 20:17:21 -0700 From: Stephen Boyd User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:15.0) Gecko/20120824 Thunderbird/15.0 MIME-Version: 1.0 To: Rohit Vaswani Subject: Re: [PATCHv2 2/2] msm: io: Change the default static iomappings to be shared References: <1346951799-9415-1-git-send-email-rvaswani@codeaurora.org> In-Reply-To: <1346951799-9415-1-git-send-email-rvaswani@codeaurora.org> X-Spam-Note: CRM114 invocation failed X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-4.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, medium trust [199.106.114.251 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.0 UPPERCASE_50_75 message body is 50-75% uppercase Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan Huntsman , Olof Johansson , Daniel Walker , David Brown , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org On 09/06/12 10:16, Rohit Vaswani wrote: > static struct map_desc msm_io_desc[] __initdata = { > - MSM_DEVICE(VIC), > - MSM_CHIP_DEVICE(CSR, MSM7X00), > - MSM_DEVICE(DMOV), > - MSM_CHIP_DEVICE(GPIO1, MSM7X00), > - MSM_CHIP_DEVICE(GPIO2, MSM7X00), > - MSM_DEVICE(CLK_CTL), > + MSM_DEVICE_TYPE(VIC, MT_DEVICE_NONSHARED), > + MSM_CHIP_DEVICE_TYPE(CSR, MSM7X00, MT_DEVICE_NONSHARED), > + MSM_DEVICE_TYPE(DMOV, MT_DEVICE_NONSHARED), > + MSM_CHIP_DEVICE_TYPE(GPIO1, MSM7X00, MT_DEVICE_NONSHARED), > + MSM_CHIP_DEVICE_TYPE(GPIO2, MSM7X00, MT_DEVICE_NONSHARED), > + MSM_CHIP_DEVICE_TYPE(CLK_CTL, MSM7X00, MT_DEVICE_NONSHARED), This one is supposed to be MSM_DEVICE_TYPE. Please squash this in: diff --git a/arch/arm/mach-msm/io.c b/arch/arm/mach-msm/io.c index 35d6926..d908a37 100644 --- a/arch/arm/mach-msm/io.c +++ b/arch/arm/mach-msm/io.c @@ -52,7 +52,7 @@ static struct map_desc msm_io_desc[] __initdata = { MSM_DEVICE_TYPE(DMOV, MT_DEVICE_NONSHARED), MSM_CHIP_DEVICE_TYPE(GPIO1, MSM7X00, MT_DEVICE_NONSHARED), MSM_CHIP_DEVICE_TYPE(GPIO2, MSM7X00, MT_DEVICE_NONSHARED), - MSM_CHIP_DEVICE_TYPE(CLK_CTL, MSM7X00, MT_DEVICE_NONSHARED), + MSM_DEVICE_TYPE(CLK_CTL, MT_DEVICE_NONSHARED), #if defined(CONFIG_DEBUG_MSM_UART1) || defined(CONFIG_DEBUG_MSM_UART2) || \ defined(CONFIG_DEBUG_MSM_UART3) MSM_DEVICE_TYPE(DEBUG_UART, MT_DEVICE_NONSHARED),