From patchwork Tue Sep 11 09:46:31 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vaibhav Hiremath X-Patchwork-Id: 1437001 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 641993FC33 for ; Tue, 11 Sep 2012 10:05:05 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TBNEF-0000f8-VR; Tue, 11 Sep 2012 09:58:00 +0000 Received: from arroyo.ext.ti.com ([192.94.94.40]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TBN3K-0000XL-5L for linux-arm-kernel@lists.infradead.org; Tue, 11 Sep 2012 09:46:45 +0000 Received: from dbdp20.itg.ti.com ([172.24.170.38]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id q8B9kcMn017374; Tue, 11 Sep 2012 04:46:39 -0500 Received: from DBDE71.ent.ti.com (localhost [127.0.0.1]) by dbdp20.itg.ti.com (8.13.8/8.13.8) with ESMTP id q8B9kZAF011050; Tue, 11 Sep 2012 15:16:35 +0530 (IST) Received: from dbdp33.itg.ti.com (172.24.170.252) by DBDE71.ent.ti.com (172.24.170.149) with Microsoft SMTP Server id 14.1.323.3; Tue, 11 Sep 2012 15:16:35 +0530 Received: from [172.24.133.105] (smtpvbd.itg.ti.com [172.24.170.250]) by dbdp33.itg.ti.com (8.13.8/8.13.8) with ESMTP id q8B9kWYe028211; Tue, 11 Sep 2012 15:16:32 +0530 Message-ID: <504F0877.4030907@ti.com> Date: Tue, 11 Sep 2012 15:16:31 +0530 From: Vaibhav Hiremath User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:15.0) Gecko/20120824 Thunderbird/15.0 MIME-Version: 1.0 To: Paul Walmsley Subject: Re: [PATCH 00/29] Move OMAP2+ over to use COMMON clock References: <1339678038-23082-1-git-send-email-rnayak@ti.com> In-Reply-To: X-Spam-Note: CRM114 invocation failed X-Spam-Score: -7.3 (-------) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-7.3 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high trust [192.94.94.40 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.4 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: linux-omap@vger.kernel.org, Rajendra Nayak , linux-arm-kernel@lists.infradead.org, mturquette@ti.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org On 9/11/2012 12:05 PM, Paul Walmsley wrote: > > Hi Rajendra, > > A CCF testing branch has been built here. The base is v3.6-rc5, plus the > most recent version of the Common Clock Framework preparation patches that > you posted to the list, "[PATCH v4 0/3] Prepare for OMAP2+ movement to > Common Clk", but updated to take RMK's feedback into account. Then the > 'clk-next-omap-3.6-rc3' branch from your repo at > 'git://github.com/rrnayak/linux.git' was added. Then some patches to drop > the old arch/arm/mach-omap2/clock*_data.c files were added. > > This branch was then run through checkpatch.pl, and all of the parenthesis > alignment warnings have been fixed. I don't know what to do about these > crazy DECLARE_CLK_* macros; they have so many arguments that they are > basically impossible to read. Mike and I discussed converting them > into C99 structure initializers with named fields, but am not sure if it's > a readability advantage; it's probably going to be "write-only data" > either way. I've reflowed many of them to save diffstat but there are > quite a few more to go. > > The branch was then built with a set of testing Kconfigs. Here's what was > found: (these are still being investigated) > > - The OMAP4-only testconfig and rmk's OMAP4430-SDP Kconfigs failed: > "undefined reference to `omap2_clkt_iclk_allow_idle'": > > http://www.pwsan.com/omap/testlogs/common_clk_testing_devel_3.7/20120911000742/build/omap4_testconfig/ > http://www.pwsan.com/omap/testlogs/common_clk_testing_devel_3.7/20120911000742/build/rmk_omap4430_sdp_oldconfig/ > > - RMK's OMAP3430-LDP Kconfig failed with a whole set of warnings: > > http://www.pwsan.com/omap/testlogs/common_clk_testing_devel_3.7/20120911000742/build/rmk_omap3430_ldp_oldconfig/ > > > The kernel built with omap2plus_defconfig was then booted on several > OMAP2+ boards. Here's what was found: > > - The kernel wouldn't boot on either the 3517EVM nor CM-T3517 boards. > This turned out to be due to some missing AM35XX clkdev aliases, the > lack of which cause the CCF code to panic. The patch that adds the > OMAP3 data has been updated to fix that bug and an HSOTGUSB clkdev > alias bug that was found by visual inspection. > > - The 3730 Beagle XM issued a warning and stack trace upon boot. > Debugging with Mike, this turned out to be due to a bug in the > modified omap2_init_clksel_parent() function: it returned a register > bitfield rather than an array index. The patch that modifies this > function was then updated to fix the bug. > > - The 2420 N800 seems to have some kind of MMC-related problem > that prevents it from booting. Still looking into this: > > http://www.pwsan.com/omap/testlogs/common_clk_testing_devel_3.7/20120911000742/boot/2420n800/2420n800_log.txt > > > Then the branch was PM-tested to determine whether it can suspend and > serial-resume properly, and whether dynamic idle works. These tests > didn't go so well: > > - 3530ES3 Beagleboard here was able to enter retention-idle > suspend, and leave it with serial wakeup, but the CORE powerdomain never > entered a low-power state. Dynamic retention-idle with serial wakeup > never resumed, and the test stopped there: > > http://www.pwsan.com/omap/testlogs/common_clk_testing_devel_3.7/20120911000742/boot/3530es3beagle/3530es3beagle_log.txt > > - 37xx EVM and 3730 Beagle XM fared better; they made it through the whole > test program, but the CORE powerdomain also never entered a low-power > state: > > http://www.pwsan.com/omap/testlogs/common_clk_testing_devel_3.7/20120911000742/boot/37xxevm/37xxevm_log.txt > http://www.pwsan.com/omap/testlogs/common_clk_testing_devel_3.7/20120911000742/boot/3730beaglexm/3730beaglexm_log.txt > > - 4430ES2 Panda never made past the first retention-idle suspend: > > http://www.pwsan.com/omap/testlogs/common_clk_testing_devel_3.7/20120911000742/boot/4430es2panda/4430es2panda_log.txt > > > Could you please take a look and see if you can identify why the patches > aren't passing the tests? I can't send these upstream until they pass the > PM tests. > > This testing branch can be found at the branch named > "common_clk_testing_devel_3.7" of git://git.pwsan.com/linux-2.6 > > The testbed reports from this branch can be found here: > > http://www.pwsan.com/omap/testlogs/common_clk_testing_devel_3.7/20120911000742/ > > And the baseline test reports from v3.6-rc5 can be found here: > > http://www.pwsan.com/omap/testlogs/test_v3.6-rc5/20120908202511/ > I tried this branch on BeagleBone platform and needs one small typo correction in hwmod data patch (submitted earlier, which you are going to queue it) With above change I boot tested it on BeagleBone platform and also verified the clock rates getting printed in debugfs. Thanks, Vaibhav > > > - Paul > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c index de7a3ab..767a77d 100644 --- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c +++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c @@ -1441,7 +1441,7 @@ static struct omap_hwmod am33xx_mmc2_hwmod = { .clkdm_name = "l3s_clkdm", .mpu_irqs = am33xx_mmc2_irqs, .sdma_reqs = am33xx_mmc2_edma_reqs, - .main_clk = "mmc2_fck", + .main_clk = "mmc_clk", .prcm = { .omap4 = { .clkctrl_offs = AM33XX_CM_PER_MMC2_CLKCTRL_OFFSET,