From patchwork Fri Oct 12 16:24:56 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Poddar, Sourav" X-Patchwork-Id: 1587341 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 706E43FCFC for ; Fri, 12 Oct 2012 16:26:54 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TMi32-0006fF-N3; Fri, 12 Oct 2012 16:25:16 +0000 Received: from arroyo.ext.ti.com ([192.94.94.40]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TMi2y-0006e2-8h for linux-arm-kernel@lists.infradead.org; Fri, 12 Oct 2012 16:25:12 +0000 Received: from dbdp20.itg.ti.com ([172.24.170.38]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id q9CGOvLN010379; Fri, 12 Oct 2012 11:24:58 -0500 Received: from DBDE70.ent.ti.com (localhost [127.0.0.1]) by dbdp20.itg.ti.com (8.13.8/8.13.8) with ESMTP id q9CGOqnF004641; Fri, 12 Oct 2012 21:54:53 +0530 (IST) Received: from dbdp33.itg.ti.com (172.24.170.252) by dbde70.ent.ti.com (172.24.170.148) with Microsoft SMTP Server id 14.1.323.3; Fri, 12 Oct 2012 21:54:52 +0530 Received: from [172.24.136.172] (smtpvbd.itg.ti.com [172.24.170.250]) by dbdp33.itg.ti.com (8.13.8/8.13.8) with ESMTP id q9CGOjo5030426; Fri, 12 Oct 2012 21:54:45 +0530 Message-ID: <50784458.9080806@ti.com> Date: Fri, 12 Oct 2012 21:54:56 +0530 From: Sourav User-Agent: Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20120912 Thunderbird/15.0.1 MIME-Version: 1.0 To: Paul Walmsley Subject: Re: [RFT/PATCH] serial: omap: prevent resume if device is not suspended. References: <1347972050-3509-1-git-send-email-sourav.poddar@ti.com> <20120925083029.GG31374@n2100.arm.linux.org.uk> <20120925083118.GI9137@arwen.pp.htv.fi> <20120925091228.GI31374@n2100.arm.linux.org.uk> <20120925091112.GK9137@arwen.pp.htv.fi> <20120925092118.GJ31374@n2100.arm.linux.org.uk> <87ipas2y4h.fsf@deeprootsystems.com> In-Reply-To: X-Spam-Note: CRM114 invocation failed X-Spam-Score: -9.0 (---------) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-9.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high trust [192.94.94.40 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -2.1 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Russell King - ARM Linux , Kevin Hilman , gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Felipe Balbi , tony@atomide.com, santosh.shilimkar@ti.com, linux-serial@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alan@linux.intel.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Hi Paul, There are On Thursday 11 October 2012 11:58 PM, Paul Walmsley wrote: > Hi Sourav, Felipe, > > any progress on fixing the N800 problem? Would be good to keep it booting > since we use it as our primary 2420 test platform. > > > - Paul The patch sent inlined below might help us to get rid of the serial init issue. Unfortunately, I dont have a N800 board with me to test it and will require your help to do so. ----------- From: Sourav Poddar Date: Wed, 1 Aug 2012 15:44:12 +0530 Subject: [RFT/PATCH] serial: omap: Fix N800 serial init issue. This patch might solve the N800 serial init issue. This patch will also give pointers if there is any mux settings issue with N800 OR a mismatch between the initial harware state, runtime PM state and omap hwmod state. I don't have a N800 schematics to check about the mux settings getting used. The observation on beagle board XM with this patch on different boards looks flaky, so your feedback on beagle board will also be very helpful. Cc: Felipe Balbi Signed-off-by: Sourav Poddar --- drivers/tty/serial/omap-serial.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) pm_runtime_set_autosuspend_delay(&pdev->dev, diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c index 6ede6fd..3fbc7f7 100644 --- a/drivers/tty/serial/omap-serial.c +++ b/drivers/tty/serial/omap-serial.c @@ -1414,6 +1414,7 @@ static int __devinit serial_omap_probe(struct platform_device *pdev) INIT_WORK(&up->qos_work, serial_omap_uart_qos_work); platform_set_drvdata(pdev, up); + pm_runtime_set_active(&pdev->dev); pm_runtime_enable(&pdev->dev); pm_runtime_use_autosuspend(&pdev->dev);