From patchwork Mon Oct 29 17:12:33 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vikram Narayanan X-Patchwork-Id: 1664781 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 95CE93FCF7 for ; Mon, 29 Oct 2012 17:14:56 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TSstM-0007RR-EE; Mon, 29 Oct 2012 17:12:48 +0000 Received: from mail-pa0-f49.google.com ([209.85.220.49]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TSstH-0007Px-Mn for linux-arm-kernel@lists.infradead.org; Mon, 29 Oct 2012 17:12:44 +0000 Received: by mail-pa0-f49.google.com with SMTP id bi5so3250559pad.36 for ; Mon, 29 Oct 2012 10:12:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :content-type:content-transfer-encoding; bh=VfaZ4V7z7F68xKzDlV1JCMVVkkv1rS7cw3GNtzO/i2Y=; b=mYofWFSz0Kn1hiQrem3lzFMYE9bvQxEwzc2joCfmZ1MuloSVMjXYaU+jShYiDTQ6Ml XLG+Qk6Grr4ax84noyUyr3/cV1Hdzxgs5XYQRfxdREJ/AtKxhL+NtUr3cYKLKKnpP3ER jMv2AVKrn5EE0c1SVdmfVymUFEyzVrvDd+jHAa0/zYn8mvSYteqUtsGYMjUMv0dePZQY AqK2QQKEQyk4Pu0b/HOLGOb/OD0Q2tzQY/WunTShj/B12FfRbr9/a9YfA1XzZK6ZgbeU h+BEF/buPViHbObebFIRfjugBaJgYMnB786yU2RXtK7jG9rV0gs/p1eb6ygSrRcPzaHf XP6w== Received: by 10.68.230.135 with SMTP id sy7mr59766229pbc.76.1351530759616; Mon, 29 Oct 2012 10:12:39 -0700 (PDT) Received: from [115.241.29.148] ([115.241.29.148]) by mx.google.com with ESMTPS id j9sm6237888paw.2.2012.10.29.10.12.36 (version=SSLv3 cipher=OTHER); Mon, 29 Oct 2012 10:12:38 -0700 (PDT) Message-ID: <508EB901.1050303@gmail.com> Date: Mon, 29 Oct 2012 22:42:33 +0530 From: Vikram Narayanan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 MIME-Version: 1.0 To: LAK Subject: [PATCH] mfd/syscon: Fix compilation issue when built for imx X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.5 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.5 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.220.49 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (vikram186[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (vikram186[at]gmail.com) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: shawn.guo@linaro.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Compiling for a IMX6Q SoC with imx_v6_v7_defconfig results in the following error <<< drivers/mfd/syscon.c:94:15: error: variable 'syscon_regmap_config' has initializer but incomplete type drivers/mfd/syscon.c:95:2: error: unknown field 'reg_bits' specified in initializer drivers/mfd/syscon.c:95:2: warning: excess elements in struct initializer [enabled by default] drivers/mfd/syscon.c:95:2: warning: (near initialization for 'syscon_regmap_config') [enabled by default] drivers/mfd/syscon.c:96:2: error: unknown field 'val_bits' specified in initializer drivers/mfd/syscon.c:96:2: warning: excess elements in struct initializer [enabled by default] drivers/mfd/syscon.c:96:2: warning: (near initialization for 'syscon_regmap_config') [enabled by default] drivers/mfd/syscon.c:97:2: error: unknown field 'reg_stride' specified in initializer drivers/mfd/syscon.c:97:2: warning: excess elements in struct initializer [enabled by default] drivers/mfd/syscon.c:97:2: warning: (near initialization for 'syscon_regmap_config') [enabled by default] drivers/mfd/syscon.c: In function 'syscon_probe': drivers/mfd/syscon.c:124:2: error: invalid use of undefined type 'struct regmap_config' drivers/mfd/syscon.c:125:2: error: implicit declaration of function 'devm_regmap_init_mmio' [-Werror=implicit-function-declaration] drivers/mfd/syscon.c:125:17: warning: assignment makes pointer from integer without a cast [enabled by default] cc1: some warnings being treated as errors >>> The datastructures are guarded with CONFIG_REGMAP in linux/regmap.h Selecting REGMAP solves the compilation error. Signed-off-by: Vikram Narayanan Cc: Shawn Guo --- I'm not sure whether this is the right way to fix, or this is already fixed. Please keep me in Cc while replying. I'm not subscribed to the list. drivers/mfd/Kconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) -- diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index acab3ef..641d191 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -1029,6 +1029,7 @@ config MFD_STA2X11 config MFD_SYSCON bool "System Controller Register R/W Based on Regmap" depends on OF + select REGMAP select REGMAP_MMIO help Select this option to enable accessing system control registers