| Message ID | 509e6047.a766980a.0f91.14f6@mx.google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Andrey, On Saturday 10 of November 2012 18:07:57 dron0gus@gmail.com wrote: > From: Andrey Gusakov <dron_gus@mail.ru> > > The "camera" clock have only one parent. Define it staticly and > remove unused source clock list. > > Signed-off-by: Andrey Gusakov <dron0gus@gmail.com> > --- > arch/arm/mach-s3c64xx/clock.c | 12 +----------- > 1 files changed, 1 insertions(+), 11 deletions(-) > > diff --git a/arch/arm/mach-s3c64xx/clock.c > b/arch/arm/mach-s3c64xx/clock.c index b2d08fa..19228f3 100644 > --- a/arch/arm/mach-s3c64xx/clock.c > +++ b/arch/arm/mach-s3c64xx/clock.c > @@ -677,15 +677,6 @@ static struct clksrc_sources clkset_audio2 = { > .nr_sources = ARRAY_SIZE(clkset_audio2_list), > }; > > -static struct clk *clkset_camif_list[] = { > - &clk_h2, > -}; > - > -static struct clksrc_sources clkset_camif = { > - .sources = clkset_camif_list, > - .nr_sources = ARRAY_SIZE(clkset_camif_list), > -}; > - > static struct clk *clkset_mfc_list[] = { > &clk_h2, > &clk_mout_epll.clk, > @@ -750,10 +741,9 @@ static struct clksrc_clk clksrcs[] = { > .name = "camera", > .ctrlbit = S3C_CLKCON_SCLK_CAM, > .enable = s3c64xx_sclk_ctrl, > + .parent = &clk_h2, > }, > .reg_div = { .reg = S3C_CLK_DIV0, .shift = 20, .size = 4 }, > - .reg_src = { .reg = NULL, .shift = 0, .size = 0 }, > - .sources = &clkset_camif, > }, { > .clk = { > .name = "sclk_mfc", Reviewed-by: Tomasz Figa <tomasz.figa@gmail.com> Best regards, Tomasz Figa
On 11/10/2012 03:07 PM, dron0gus@gmail.com wrote: > From: Andrey Gusakov<dron_gus@mail.ru> > > The "camera" clock have only one parent. Define it staticly and > remove unused source clock list. > > Signed-off-by: Andrey Gusakov<dron0gus@gmail.com> Reviewed-by: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
On 11/10/2012 10:13 PM, Sylwester Nawrocki wrote: > On 11/10/2012 03:07 PM, dron0gus@gmail.com wrote: >> From: Andrey Gusakov<dron_gus@mail.ru> >> >> The "camera" clock have only one parent. Define it staticly and Forgot to point out a small typo here: staticly -> statically. >> remove unused source clock list. >> >> Signed-off-by: Andrey Gusakov<dron0gus@gmail.com> > > Reviewed-by: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
Sylwester Nawrocki wrote: > > On 11/10/2012 10:13 PM, Sylwester Nawrocki wrote: > > On 11/10/2012 03:07 PM, dron0gus@gmail.com wrote: > >> From: Andrey Gusakov<dron_gus@mail.ru> > >> > >> The "camera" clock have only one parent. Define it staticly and > > Forgot to point out a small typo here: staticly -> statically. > Thanks for pointing out. I fixed it when I applied. > >> remove unused source clock list. > >> > >> Signed-off-by: Andrey Gusakov<dron0gus@gmail.com> > > > > Reviewed-by: Sylwester Nawrocki <sylvester.nawrocki@gmail.com> Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.
diff --git a/arch/arm/mach-s3c64xx/clock.c b/arch/arm/mach-s3c64xx/clock.c index b2d08fa..19228f3 100644 --- a/arch/arm/mach-s3c64xx/clock.c +++ b/arch/arm/mach-s3c64xx/clock.c @@ -677,15 +677,6 @@ static struct clksrc_sources clkset_audio2 = { .nr_sources = ARRAY_SIZE(clkset_audio2_list), }; -static struct clk *clkset_camif_list[] = { - &clk_h2, -}; - -static struct clksrc_sources clkset_camif = { - .sources = clkset_camif_list, - .nr_sources = ARRAY_SIZE(clkset_camif_list), -}; - static struct clk *clkset_mfc_list[] = { &clk_h2, &clk_mout_epll.clk, @@ -750,10 +741,9 @@ static struct clksrc_clk clksrcs[] = { .name = "camera", .ctrlbit = S3C_CLKCON_SCLK_CAM, .enable = s3c64xx_sclk_ctrl, + .parent = &clk_h2, }, .reg_div = { .reg = S3C_CLK_DIV0, .shift = 20, .size = 4 }, - .reg_src = { .reg = NULL, .shift = 0, .size = 0 }, - .sources = &clkset_camif, }, { .clk = { .name = "sclk_mfc",