From patchwork Sun Nov 18 20:18:37 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Larry Finger X-Patchwork-Id: 1761471 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id 810C2DF23A for ; Sun, 18 Nov 2012 20:20:33 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TaBKJ-00047o-5M; Sun, 18 Nov 2012 20:18:47 +0000 Received: from mail-ie0-f177.google.com ([209.85.223.177]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TaBKF-00047V-GD for linux-arm-kernel@lists.infradead.org; Sun, 18 Nov 2012 20:18:44 +0000 Received: by mail-ie0-f177.google.com with SMTP id e14so5728478iej.36 for ; Sun, 18 Nov 2012 12:18:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=t7hrjUxC3q6nq++g1qaeaf7c/ED7UUoFVdeMfgRCKH4=; b=Gd3V1fqeO8L3QTfvy+oeKbI6UU59k8njyrTBCMEPEytmnji/Evw1EP+CFihDQREkUU 69ma3s5gsnTkqwJWHR7oGbakkJCfFkk9gPezcl6E5mSQqpsr0R0MPw06SeoBRRo0cmaq uxglIYNCYh9V5O0/thlxnG4pB4M6nkUj1YQwc7L2lW14ePU7RZ5/Io+1kJLma3Jzpp1N K5zr3Z4qIfNInvdHSN8ioMf9xDvk5E+GQ3O6MeVdaglFjC+Yz7ts7XFTDjZEb23J5209 l4d28cPblYwMWZoVG8qu1z4B8Iy7oZoDzDxOszLwkDuwcX6sSRhT7SsEp4GseR87o1PR AwdA== Received: by 10.50.104.232 with SMTP id gh8mr4921751igb.45.1353269921286; Sun, 18 Nov 2012 12:18:41 -0800 (PST) Received: from larrylap.site (CPE-75-81-36-228.kc.res.rr.com. [75.81.36.228]) by mx.google.com with ESMTPS id az6sm5409883igb.11.2012.11.18.12.18.38 (version=SSLv3 cipher=OTHER); Sun, 18 Nov 2012 12:18:40 -0800 (PST) Message-ID: <50A9429D.1010908@lwfinger.net> Date: Sun, 18 Nov 2012 14:18:37 -0600 From: Larry Finger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121025 Thunderbird/16.0.2 MIME-Version: 1.0 To: Andrew Lunn Subject: Re: [Patch v1 1/1] RTL8712 alignment bug in 3.6.5 on ARM References: <20121118181140.GC14643@lunn.ch> In-Reply-To: <20121118181140.GC14643@lunn.ch> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20121118_151843_644101_3FE96FB4 X-CRM114-Status: GOOD ( 14.36 ) X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.223.177 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (larry.finger[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: devel@driverdev.osuosl.org, florian.c.schilhabel@googlemail.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Josh Coombs , wlanfae@realtek.com, linux ARM X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org On 11/18/2012 12:11 PM, Andrew Lunn wrote: > > Just to clarify the issue here: > > union pn48 { > u64 val; > #if defined(__BIG_ENDIAN) > struct { > u8 TSC7; > u8 TSC6; > > Any instance of pn48 needs to be 64 bit aligned when the val member of > the union is used. The structure sta_info contains two such pn48s, so > the code allocating the pool of these needs to ensure it allocated > them 64 bit aligned, not 32bit aligned as it currently is. Andrew, For my education, would the following patch ensure 64-bit alignment for the pn48 instances, or is more needed? Thanks, Larry Index: staging/drivers/staging/rtl8712/rtl871x_security.h =================================================================== --- staging.orig/drivers/staging/rtl8712/rtl871x_security.h +++ staging/drivers/staging/rtl8712/rtl871x_security.h @@ -89,6 +89,8 @@ struct RT_PMKID_LIST { }; struct security_priv { + union pn48 Grptxpn; /* PN48 used for Grp Key xmit. */ + union pn48 Grprxpn; /* PN48 used for Grp Key recv. */ u32 AuthAlgrthm; /* 802.11 auth, could be open, shared, * 8021x and authswitch */ u32 PrivacyAlgrthm; /* This specify the privacy for shared @@ -104,8 +106,6 @@ struct security_priv { * inx0 and inx1 */ union Keytype XGrptxmickey[2]; union Keytype XGrprxmickey[2]; - union pn48 Grptxpn; /* PN48 used for Grp Key xmit. */ - union pn48 Grprxpn; /* PN48 used for Grp Key recv. */ u8 wps_hw_pbc_pressed;/*for hw pbc pressed*/ u8 wps_phase;/*for wps*/ u8 wps_ie[MAX_WPA_IE_LEN<<2];