From patchwork Fri Mar 8 01:14:01 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 2234101 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id 5FC79DF5B1 for ; Fri, 8 Mar 2013 01:17:20 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UDlsw-0001AO-3A; Fri, 08 Mar 2013 01:14:10 +0000 Received: from wolverine01.qualcomm.com ([199.106.114.254]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UDlsq-00018o-Gr for linux-arm-kernel@lists.infradead.org; Fri, 08 Mar 2013 01:14:05 +0000 X-IronPort-AV: E=Sophos;i="4.84,806,1355126400"; d="scan'208";a="27895420" Received: from pdmz-ns-mip.qualcomm.com (HELO mostmsg01.qualcomm.com) ([199.106.114.10]) by wolverine01.qualcomm.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 07 Mar 2013 17:14:02 -0800 Received: from [10.46.166.8] (pdmz-ns-snip_218_1.qualcomm.com [192.168.218.1]) by mostmsg01.qualcomm.com (Postfix) with ESMTPA id 7EC0510004B6; Thu, 7 Mar 2013 17:14:02 -0800 (PST) Message-ID: <51393B59.3070200@codeaurora.org> Date: Thu, 07 Mar 2013 17:14:01 -0800 From: Stephen Boyd User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:17.0) Gecko/20130215 Thunderbird/17.0.3 MIME-Version: 1.0 To: Tony Lindgren Subject: Re: [PATCH 03/10] ARM: smp_twd: Divorce smp_twd from local timer API References: <1362614646-24113-1-git-send-email-sboyd@codeaurora.org> <1362614646-24113-4-git-send-email-sboyd@codeaurora.org> <20130308004011.GD11806@atomide.com> In-Reply-To: <20130308004011.GD11806@atomide.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130307_201404_739545_CF6BFD38 X-CRM114-Status: GOOD ( 13.60 ) X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-4.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, medium trust [199.106.114.254 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: linux-arm-msm@vger.kernel.org, Russell King , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org On 03/07/13 16:40, Tony Lindgren wrote: > Hi, > > * Stephen Boyd [130306 17:53]: >> Separate the smp_twd timers from the local timer API. This will >> allow us to remove ARM local timer support in the near future and >> gets us closer to moving this driver to drivers/clocksource. > Looks like applying this patch makes omap4 to stop booting for > some reason. > > Hm... Perhaps you need the clock? diff --git a/arch/arm/kernel/smp_twd.c b/arch/arm/kernel/smp_twd.c index 2439843..081de6f 100644 --- a/arch/arm/kernel/smp_twd.c +++ b/arch/arm/kernel/smp_twd.c @@ -345,11 +345,11 @@ static int __init twd_local_timer_common_register(struct device_node *np) if (err) goto out_irq; + twd_get_clock(np); + /* Immediately configure the timer on the boot CPU */ twd_timer_setup(this_cpu_ptr(twd_evt)); - twd_get_clock(np); - return 0; out_irq: