From patchwork Fri Mar 15 14:17:35 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sekhar Nori X-Patchwork-Id: 2278131 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id D1DC6DF24C for ; Fri, 15 Mar 2013 14:21:08 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UGVSS-00054H-4q; Fri, 15 Mar 2013 14:18:08 +0000 Received: from comal.ext.ti.com ([198.47.26.152]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UGVSP-00053x-9s for linux-arm-kernel@lists.infradead.org; Fri, 15 Mar 2013 14:18:05 +0000 Received: from dbdp20.itg.ti.com ([172.24.170.38]) by comal.ext.ti.com (8.13.7/8.13.7) with ESMTP id r2FEI2sW001792; Fri, 15 Mar 2013 09:18:02 -0500 Received: from DBDE70.ent.ti.com (localhost [127.0.0.1]) by dbdp20.itg.ti.com (8.13.8/8.13.8) with ESMTP id r2FEHw4h001319; Fri, 15 Mar 2013 19:47:58 +0530 (IST) Received: from dbdp32.itg.ti.com (172.24.170.251) by dbde70.ent.ti.com (172.24.170.148) with Microsoft SMTP Server id 14.1.323.3; Fri, 15 Mar 2013 19:47:58 +0530 Received: from [172.24.81.195] (smtpvbd.itg.ti.com [172.24.170.250]) by dbdp32.itg.ti.com (8.13.8/8.13.8) with ESMTP id r2FEHf3S001050; Fri, 15 Mar 2013 19:47:47 +0530 Message-ID: <51432D7F.4090001@ti.com> Date: Fri, 15 Mar 2013 19:47:35 +0530 From: Sekhar Nori User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20130307 Thunderbird/17.0.4 MIME-Version: 1.0 To: Prabhakar Lad Subject: Re: DaVinci platform unable to boot via NFS References: In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130315_101805_449389_FD374514 X-CRM114-Status: GOOD ( 14.39 ) X-Spam-Score: -9.3 (---------) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-9.3 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high trust [198.47.26.152 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -2.4 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: mugunthanvnm@ti.com, dlos , netdev@vger.kernel.org, Daniel Mack , Mark Jackson , LAK X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Prabhakar, On 3/15/2013 7:11 PM, Prabhakar Lad wrote: > Hi Mugunthan, > > With 3.9 release I am not able to boot any davinci board via nfs, finally > digging Into I found that there were recent changes for Ethernet davinci. > Finally I reverting this to some safe commit I was able to boot via nfs. > I reverted back as following:- > git checkout f9a8f83b04e0c362a2fc660dbad980d24af209fc drivers/net/ethernet/ti/ > > Can you please take a look at and fix it. > > Cheers, > --Prabhakar Lad > http://in.linkedin.com/pub/prabhakar-lad/19/92b/955 > A similar bug was reported on cpsw and the following patch from Daniel seems to have helped. https://git.kernel.org/cgit/linux/kernel/git/davem/net.git/commit/?id=d35162f89b8f00537d7b240b76d2d0e8b8d29aa0 I made a similar fix for davinci_emac.c and the resulting diff is below (not tested or built). Can you please check if this helps in DaVinci case? Thanks, Sekhar ----8<---- diff --git a/drivers/net/ethernet/ti/davinci_emac.c b/drivers/net/ethernet/ti/davinci_emac.c index 52c0536..ae1b77a 100644 --- a/drivers/net/ethernet/ti/davinci_emac.c +++ b/drivers/net/ethernet/ti/davinci_emac.c @@ -1102,7 +1102,7 @@ static int emac_dev_xmit(struct sk_buff *skb, struct net_device *ndev) /* If there is no more tx desc left free then we need to * tell the kernel to stop sending us tx frames. */ - if (unlikely(cpdma_check_free_tx_desc(priv->txchan))) + if (unlikely(!cpdma_check_free_tx_desc(priv->txchan))) netif_stop_queue(ndev); return NETDEV_TX_OK;