From patchwork Thu Mar 28 07:29:46 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Santosh Shilimkar X-Patchwork-Id: 2355031 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 4D1843FDDA for ; Thu, 28 Mar 2013 07:31:29 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UL7Fg-0005rp-UG; Thu, 28 Mar 2013 07:28:00 +0000 Received: from arroyo.ext.ti.com ([192.94.94.40]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UL7Fd-0005r9-2Z for linux-arm-kernel@lists.infradead.org; Thu, 28 Mar 2013 07:27:58 +0000 Received: from dbdp20.itg.ti.com ([172.24.170.38]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id r2S7RqNR016717; Thu, 28 Mar 2013 02:27:53 -0500 Received: from DBDE70.ent.ti.com (localhost [127.0.0.1]) by dbdp20.itg.ti.com (8.13.8/8.13.8) with ESMTP id r2S7Rnrj022158; Thu, 28 Mar 2013 12:57:50 +0530 (IST) Received: from dbdp33.itg.ti.com (172.24.170.252) by dbde70.ent.ti.com (172.24.170.148) with Microsoft SMTP Server id 14.1.323.3; Thu, 28 Mar 2013 12:57:49 +0530 Received: from [172.24.136.207] (smtpvbd.itg.ti.com [172.24.170.250]) by dbdp33.itg.ti.com (8.13.8/8.13.8) with ESMTP id r2S7RjF6019653; Thu, 28 Mar 2013 12:57:47 +0530 Message-ID: <5153F16A.5070307@ti.com> Date: Thu, 28 Mar 2013 12:59:46 +0530 From: Santosh Shilimkar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Subject: Re: [PATCH 4/9] ARM: OMAP4+: Remove the un-necessary cache flush from hotplug code References: <1361373527-21695-1-git-send-email-santosh.shilimkar@ti.com> <1361373527-21695-5-git-send-email-santosh.shilimkar@ti.com> <87ehf07kfn.fsf@linaro.org> <51535AF4.3090607@ti.com> In-Reply-To: <51535AF4.3090607@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130328_032757_202350_7BF93408 X-CRM114-Status: GOOD ( 16.62 ) X-Spam-Score: -8.2 (--------) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-8.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high trust [192.94.94.40 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.3 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: tony@atomide.com, Kevin Hilman , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org On Thursday 28 March 2013 02:17 AM, Santosh Shilimkar wrote: > On Thursday 28 March 2013 12:13 AM, Kevin Hilman wrote: >> Santosh Shilimkar writes: >> >>> This was added with intial port where OMAP PM support wasn't existing >>> and only simple WFI based hooks were used. >>> >>> This should have been cleaned up while adding the PM support but some >>> how fall through cracks. >> >> Changelog describes a bit of history, but does not it's no longer >> needed. >> > I thought "This should have been cleaned up while adding PM support" > means its no longer needed. At least I meant that way. > > Anyway I will just make it explicit. > For record, patch with updated changelog end of email. Regards, Santosh From 4df9c29bf6eec23e99e83c9e1531603af69b4b42 Mon Sep 17 00:00:00 2001 From: Santosh Shilimkar Date: Sun, 10 Feb 2013 13:14:17 +0530 Subject: [PATCH v2 4/9] ARM: OMAP4+: Remove the un-necessary cache flush from hotplug code This was added with intial port where OMAP PM support wasn't existing and only simple WFI based hooks were used. This should have been cleaned up while adding the PM support but some how fall through cracks. So remove the cache flush code which is no longer needed now. Signed-off-by: Santosh Shilimkar --- arch/arm/mach-omap2/omap-hotplug.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/arch/arm/mach-omap2/omap-hotplug.c b/arch/arm/mach-omap2/omap-hotplug.c index e712d17..458f72f 100644 --- a/arch/arm/mach-omap2/omap-hotplug.c +++ b/arch/arm/mach-omap2/omap-hotplug.c @@ -19,11 +19,8 @@ #include #include -#include #include "omap-wakeupgen.h" - #include "common.h" - #include "powerdomain.h" /* @@ -35,9 +32,6 @@ void __ref omap4_cpu_die(unsigned int cpu) unsigned int boot_cpu = 0; void __iomem *base = omap_get_wakeupgen_base(); - flush_cache_all(); - dsb(); - /* * we're ready for shutdown now, so do it */