From patchwork Thu May 2 17:07:49 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eduardo Valentin X-Patchwork-Id: 2512851 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) by patchwork2.kernel.org (Postfix) with ESMTP id EC1CADF215 for ; Thu, 2 May 2013 17:08:55 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UXx02-00065S-7N; Thu, 02 May 2013 17:08:54 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UXwzz-0005Ev-OX; Thu, 02 May 2013 17:08:51 +0000 Received: from arroyo.ext.ti.com ([192.94.94.40]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UXwzw-0005EZ-8t for linux-arm-kernel@lists.infradead.org; Thu, 02 May 2013 17:08:49 +0000 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id r42H85g1024172; Thu, 2 May 2013 12:08:05 -0500 Received: from DLEE70.ent.ti.com (dlee70.ent.ti.com [157.170.170.113]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id r42H85Ht029178; Thu, 2 May 2013 12:08:05 -0500 Received: from dlelxv22.itg.ti.com (172.17.1.197) by DLEE70.ent.ti.com (157.170.170.113) with Microsoft SMTP Server id 14.2.342.3; Thu, 2 May 2013 12:08:05 -0500 Received: from [172.24.68.12] (h68-12.vpn.ti.com [172.24.68.12]) by dlelxv22.itg.ti.com (8.13.8/8.13.8) with ESMTP id r42H7xuF022623; Thu, 2 May 2013 12:08:00 -0500 Message-ID: <51829D65.7040109@ti.com> Date: Thu, 2 May 2013 13:07:49 -0400 From: Eduardo Valentin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130308 Thunderbird/17.0.4 MIME-Version: 1.0 To: Tony Lindgren Subject: Re: Latest build results - errors/warnings - lots of them References: <20130430081739.GP14496@n2100.arm.linux.org.uk> <20130502082218.GA21614@n2100.arm.linux.org.uk> <20130502153834.GR28721@atomide.com> In-Reply-To: <20130502153834.GR28721@atomide.com> X-Enigmail-Version: 1.5.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130502_130848_412866_4742C848 X-CRM114-Status: GOOD ( 25.12 ) X-Spam-Score: -9.4 (---------) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-9.4 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high trust [192.94.94.40 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -2.5 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Russell King - ARM Linux , Arnd Bergmann , Nicolas Pitre , Neil Brown , Eduardo Valentin , Durgadoss R , "Zhang, Rui" , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Arnd, Tony, On 02-05-2013 11:38, Tony Lindgren wrote: > * Russell King - ARM Linux [130502 01:27]: >> On Tue, Apr 30, 2013 at 09:17:39AM +0100, Russell King - ARM Linux wrote: >>> Latest nightly build of 3.9+my for-next+arm-soc's for-next results in a >>> great load of new warnings and errors. arch/arm/common/mcpm_head.S, >>> arch/arm/common/mcpm_platsmp.c, arch/arm/common/vlock.S are the biggest >>> source of errors. >>> >>> OMAP stuff needs a serious look at too - much Kconfig madness there >>> caused by over-use of select, which then goes on to cause build errors >>> because it assumes some stuff is always enabled. >>> >>> There's also warnings about of_device_id from include/linux/of_platform.h >>> via from arch/arm/kernel/setup.c which feature in all the non-OF builds >>> too which need addressing. >>> >>> See todays http://www.arm.linux.org.uk/developer/build/ results for all >>> the details and configs. Not pushing my tree until some of this stuff >>> gets fixed. >> >> And now we have a new bunch of warnings from OMAP stuff which weren't >> previously there... >> >> arch/arm/mach-omap2/omap_device.c: In function 'omap_device_get_by_hwmod_name': >> arch/arm/mach-omap2/omap_device.c:821:3: warning: return makes pointer from integer without a cast >> arch/arm/mach-omap2/omap_device.c:826:3: warning: return makes pointer from integer without a cast > > Hmm these I already fixed earlier along with a merge resolution, and > I'm not seeing them in next/master or arm-soc/for-next. What do you > have merged into your current tree? > >> drivers/power/twl4030_charger.c: In function 'twl4030_charger_enable_usb': >> drivers/power/twl4030_charger.c:192:20: warning: ignoring return value of 'regulator_enable', declared with attribute warn_unused_result > > Neil, care to provide a fix for this? It's from your commit ab37813 > (twl4030_charger: Allow charger to control the regulator that feeds it). > >> include/linux/thermal.h:254:12: warning: 'thermal_generate_netlink_event' defined but not used > > Eduardo, can you fix that one? It seems to be from your commit 8ab3e6a > (thermal: Use thermal zone device id in netlink messages). Yeah sure I can fix it. As simple as the following: From c04244c87312f5bfc61d9e12ba3fbaa0fdd81adb Mon Sep 17 00:00:00 2001 From: Eduardo Valentin Date: Thu, 2 May 2013 12:58:20 -0400 Subject: [PATCH 1/1] thermal: remove stub for thermal_generate_netlink_event This patch removes the stub for thermal_generate_netlink_event because this function is not used anywhere inside the kernel. In case CONFIG_NET is not set we get: include/linux/thermal.h:254:12: warning: 'thermal_generate_netlink_event' defined but not used Thus removing it. Signed-off-by: Eduardo Valentin --- include/linux/thermal.h | 6 ------ 1 file changed, 6 deletions(-) #endif /* __THERMAL_H__ */ diff --git a/include/linux/thermal.h b/include/linux/thermal.h index e3c0ae9..e3f3cba 100644 --- a/include/linux/thermal.h +++ b/include/linux/thermal.h @@ -250,12 +250,6 @@ void thermal_unregister_governor(struct thermal_governor *); #ifdef CONFIG_NET extern int thermal_generate_netlink_event(struct thermal_zone_device *tz, enum events event); -#else -static int thermal_generate_netlink_event(struct thermal_zone_device *tz, - enum events event) -{ - return 0; -} #endif