From patchwork Fri May 24 12:53:07 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Emilio_L=C3=B3pez?= X-Patchwork-Id: 2611191 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) by patchwork1.kernel.org (Postfix) with ESMTP id 0BA8540077 for ; Fri, 24 May 2013 12:53:50 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UfrV9-0007Ym-SP; Fri, 24 May 2013 12:53:44 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UfrV4-0006g7-Nb; Fri, 24 May 2013 12:53:38 +0000 Received: from [2606:3f00:60:21c:d00d:c0de:4:f00d] (helo=zetta.elopez.com.ar) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UfrV1-0006fP-PH for linux-arm-kernel@lists.infradead.org; Fri, 24 May 2013 12:53:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=elopez.com.ar; s=mail; h=Content-Type:In-Reply-To:References:Subject:CC:To:MIME-Version:From:Date:Message-ID; bh=6CYriafxqN9xpbUnnQ8UpqKyMAJ1cwCziT4mcMilvVA=; b=YxQYnFVQSGDgAtjIVM9uf37NgfpFB7afYrzPqO/nxxbqJzufYwEas0MWMkkR0EYkrI/0TPlVUx19/DKPXkPecgD3hCoEhwlSYdZy+a1VRSFlSe5cJwHwy5IA/pM670C1+nwTLM6c4X7DW+HLQ5jXq9X4rN9chue6OZfxr/dUD8YcIyAtk5B4XyMhOGQCIsvml5dMcgeTyQ91GVvEH1vcMk5RGiTjgKrh4O2Ta625mMkfFGCQa+mNiCvAA0/nN3ULUu/o+oOXFu06+VFy5oTkCmCMzVsF0YH4HKGBL7WmqFjbQl36Pi8zOusUdeGtedHh7t8BftIPmankl30LZF07UQ==; Received: from [181.164.109.61] (helo=[192.168.1.103]) by zetta.elopez.com.ar with esmtpsa (TLS1.0:DHE_RSA_CAMELLIA_256_CBC_SHA1:256) (Exim 4.80) id 1UfrUe-0000Jl-7x; Fri, 24 May 2013 09:53:12 -0300 Message-ID: <519F62B3.8090302@elopez.com.ar> Date: Fri, 24 May 2013 09:53:07 -0300 From: =?ISO-8859-1?Q?Emilio_L=F3pez?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: Maxime Ripard Subject: Re: [PATCHv3 5/6] ARM: cubieboard: Enable ethernet (EMAC) support in dts References: <1369387394-9453-1-git-send-email-maxime.ripard@free-electrons.com> <1369387394-9453-6-git-send-email-maxime.ripard@free-electrons.com> In-Reply-To: <1369387394-9453-6-git-send-email-maxime.ripard@free-electrons.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130524_085335_913494_B2E89798 X-CRM114-Status: GOOD ( 12.49 ) X-Spam-Score: -1.2 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.8 RDNS_NONE Delivered to internal network by a host with no rDNS Cc: kevin@allwinnertech.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net, sunny@allwinnertech.com, shuge@allwinnertech.com, Stefan Roese , Florian Fainelli , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Hi, El 24/05/13 06:23, Maxime Ripard escribió: > From: Stefan Roese > > Signed-off-by: Stefan Roese > --- > arch/arm/boot/dts/sun4i-a10-cubieboard.dts | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm/boot/dts/sun4i-a10-cubieboard.dts b/arch/arm/boot/dts/sun4i-a10-cubieboard.dts > index b70fe0d..32d9b18 100644 > --- a/arch/arm/boot/dts/sun4i-a10-cubieboard.dts > +++ b/arch/arm/boot/dts/sun4i-a10-cubieboard.dts > @@ -27,6 +27,21 @@ > }; > > soc@01c20000 { > + emac: ethernet@01c0b000 { > + pinctrl-names = "default"; > + pinctrl-0 = <&emac_pins_a>; > + phy = <&phy0>; > + status = "okay"; > + }; > + > + mdio@01c0b080 { > + status = "okay"; > + > + phy0: ethernet-phy@0 { > + reg = <0>; > + }; During my testing I found out that I needed to use 1 as reg for the driver to work. You can find a fixup patch enclosed that changes this; it's possible that some extra changes may also be needed (s/phy0/phy1/ on the node?) Cheers, Emilio From f8a76c66fff0700e3c87f89b8b250effc0f2b37f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Emilio=20L=C3=B3pez?= Date: Fri, 17 May 2013 10:11:48 -0300 Subject: [PATCH] fixup! ARM: cubieboard: Enable ethernet (EMAC) support in dts --- arch/arm/boot/dts/sun4i-a10-cubieboard.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/sun4i-a10-cubieboard.dts b/arch/arm/boot/dts/sun4i-a10-cubieboard.dts index cd69799..21f0197 100644 --- a/arch/arm/boot/dts/sun4i-a10-cubieboard.dts +++ b/arch/arm/boot/dts/sun4i-a10-cubieboard.dts @@ -38,7 +38,7 @@ status = "okay"; phy0: ethernet-phy@0 { - reg = <0>; + reg = <1>; }; }; -- 1.8.1.6