From patchwork Mon May 27 02:00:12 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chen Gang X-Patchwork-Id: 2617171 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) by patchwork2.kernel.org (Postfix) with ESMTP id 54015DFB79 for ; Mon, 27 May 2013 02:01:32 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Ugmkb-0003Wj-Rd; Mon, 27 May 2013 02:01:30 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UgmkZ-00053J-81; Mon, 27 May 2013 02:01:27 +0000 Received: from intranet.asianux.com ([58.214.24.6]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UgmkW-00052W-2F for linux-arm-kernel@lists.infradead.org; Mon, 27 May 2013 02:01:24 +0000 Received: by intranet.asianux.com (Postfix, from userid 103) id D558918402F4; Mon, 27 May 2013 10:01:01 +0800 (CST) X-Spam-Score: -100.8 X-Spam-Checker-Version: SpamAssassin 3.1.9 (2007-02-13) on intranet.asianux.com X-Spam-Level: X-Spam-Status: No, score=-100.8 required=5.0 tests=AWL,BAYES_00, RATWARE_GECKO_BUILD,USER_IN_WHITELIST autolearn=no version=3.1.9 Received: from [10.1.0.143] (unknown [219.143.36.82]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by intranet.asianux.com (Postfix) with ESMTP id 5907D18402E8; Mon, 27 May 2013 10:01:01 +0800 (CST) Message-ID: <51A2BE2C.2000004@asianux.com> Date: Mon, 27 May 2013 10:00:12 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Catalin Marinas , Will Deacon , vgupta@synopsys.com, Tony Lindgren , Santosh Shilimkar Subject: [PATCH v2] arch: arm64: kernel: sprintf(), 'str' needs additional 1 byte for failure processing References: <51A1E3B3.4060901@asianux.com> In-Reply-To: <51A1E3B3.4060901@asianux.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130526_220124_369663_DCEC1C8B X-CRM114-Status: GOOD ( 13.03 ) X-Spam-Score: -3.0 (---) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-3.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -1.1 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Linux-Arch , Andrew Morton , Rusty Russell , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org When failure occurs at the last looping cycle (when 'i == 0'), it will print "bad PC value" instead of "(%08x) ", which needs additional 1 byte. If not add 1 byte, the 'str' may be memory overflow. Signed-off-by: Chen Gang --- arch/arm64/kernel/traps.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm64/kernel/traps.c b/arch/arm64/kernel/traps.c index 61d7dd2..c2f68d2 100644 --- a/arch/arm64/kernel/traps.c +++ b/arch/arm64/kernel/traps.c @@ -100,7 +100,7 @@ static void dump_instr(const char *lvl, struct pt_regs *regs) { unsigned long addr = instruction_pointer(regs); mm_segment_t fs; - char str[sizeof("00000000 ") * 5 + 2 + 1], *p = str; + char str[sizeof("00000000 ") * 5 + 2 + 1 + 1], *p = str; int i; /*