From patchwork Wed Jun 5 12:50:44 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 2669711 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) by patchwork1.kernel.org (Postfix) with ESMTP id C9A6540077 for ; Wed, 5 Jun 2013 12:51:33 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UkDBT-0003Pj-B0; Wed, 05 Jun 2013 12:51:23 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UkDBM-00027b-V0; Wed, 05 Jun 2013 12:51:16 +0000 Received: from mail-bk0-x229.google.com ([2a00:1450:4008:c01::229]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UkDBF-000262-IZ for linux-arm-kernel@lists.infradead.org; Wed, 05 Jun 2013 12:51:10 +0000 Received: by mail-bk0-f41.google.com with SMTP id jc3so878348bkc.28 for ; Wed, 05 Jun 2013 05:50:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding :x-gm-message-state; bh=ltg00rr2z6pTBP6TtDhwc1AaF2ANYs+9pxvRCbIJAas=; b=K14tsGPqyXeIs0LjP/knC9EEJS7T6Chk9fyHc++lbruf0Gf23MXzMNRXHz/3q3rZOQ 1sbG9rK/MemjeMFqsectl5FghF+p6rqFR9quIgsoeTlsuGgsqvFoeQ/F+W1PwPXiX61Z 7LH+9REOb3WLejeZi6gEilFevQuJPRNvv4gcCe6IXxJ+yVoCwMLHHADVSnAqNb047Rxx OhUGTkOX3ufGzVqRa+ZoZ08vo71veyUSh9xYVxdLxLog3/tehwrNi2jEd5RkEvteUqfP PXemP22uL1j3OIbxvZTMC62mrEg0O9A+8Vqu3dTtvkm0adYca9oOxKbVVySimRyMjh6Z g4mA== X-Received: by 10.204.239.9 with SMTP id ku9mr9678523bkb.51.1370436644631; Wed, 05 Jun 2013 05:50:44 -0700 (PDT) Received: from [192.168.1.150] (AToulouse-654-1-485-200.w92-146.abo.wanadoo.fr. [92.146.76.200]) by mx.google.com with ESMTPSA id so13sm25680483bkb.15.2013.06.05.05.50.42 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 05 Jun 2013 05:50:43 -0700 (PDT) Message-ID: <51AF3424.5060200@linaro.org> Date: Wed, 05 Jun 2013 14:50:44 +0200 From: Daniel Lezcano User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Arnd Bergmann Subject: Re: [PATCH] cpuidle: move ARCH_NEEDS_CPU_IDLE_COUPLED Kconfig option References: <1460854.rT4b7LefMM@wuerfel> In-Reply-To: <1460854.rT4b7LefMM@wuerfel> X-Gm-Message-State: ALoCoQnO59ncqBR1jTAAVTMIlf5wLnX6dNF66nGxre4BPp1nXxw+B2M3TigcLAJbpYbB1uLs7amu X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130605_085109_805151_BB0B6719 X-CRM114-Status: GOOD ( 11.62 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: "Rafael J. Wysocki" , linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org On 06/05/2013 02:38 PM, Arnd Bergmann wrote: > There is no reason why ARCH_NEEDS_CPU_IDLE_COUPLED needs to be > hidden inside of "if CPU_IDLE", since it is a silent option. > Moving it outside lets platforms select this symbol unconditionally, > which avoid a warning from the ARM omap2plus_defconfig build: > > warning: (ARCH_OMAP4 && ARCH_TEGRA_2x_SOC) selects > ARCH_NEEDS_CPU_IDLE_COUPLED which has unmet direct > dependencies (CPU_IDLE) IMHO, this option depends on CPU_IDLE and thus must be kept inside the CPU_IDLE menuconfig. The warning raised here is because this option is selected by the arch Kconfig without checking if CPU_IDLE is set or not. I am in favor to change the OMAP / TEGRA Kconfigs instead, in this way: diff --git a/drivers/cpuidle/Kconfig b/drivers/cpuidle/Kconfig [ ... ] diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig index f49cd51..831e89e 100644 --- a/arch/arm/mach-omap2/Kconfig +++ b/arch/arm/mach-omap2/Kconfig @@ -83,7 +83,7 @@ config ARCH_OMAP4 depends on ARCH_OMAP2PLUS depends on ARCH_MULTI_V7 select ARCH_HAS_OPP - select ARCH_NEEDS_CPU_IDLE_COUPLED if SMP + select ARCH_NEEDS_CPU_IDLE_COUPLED if (SMP && CPU_IDLE) select ARM_CPU_SUSPEND if PM select ARM_ERRATA_720789 select ARM_GIC diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig index 84d72fc..04c6221 100644 --- a/arch/arm/mach-tegra/Kconfig +++ b/arch/arm/mach-tegra/Kconfig @@ -23,7 +23,7 @@ menu "NVIDIA Tegra options" config ARCH_TEGRA_2x_SOC bool "Enable support for Tegra20 family" - select ARCH_NEEDS_CPU_IDLE_COUPLED if SMP + select ARCH_NEEDS_CPU_IDLE_COUPLED if (SMP && CPU_IDLE) select ARM_ERRATA_720789 select ARM_ERRATA_754327 if SMP select ARM_ERRATA_764369 if SMP