From patchwork Thu Jun 20 13:02:19 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Roger Quadros X-Patchwork-Id: 2755731 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 2E51D9F39E for ; Thu, 20 Jun 2013 13:03:04 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 624CC20446 for ; Thu, 20 Jun 2013 13:02:59 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B668420434 for ; Thu, 20 Jun 2013 13:02:57 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UpeVo-0003BF-D4; Thu, 20 Jun 2013 13:02:52 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UpeVl-0006Cp-M4; Thu, 20 Jun 2013 13:02:49 +0000 Received: from arroyo.ext.ti.com ([192.94.94.40]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UpeVi-0006CO-7E for linux-arm-kernel@lists.infradead.org; Thu, 20 Jun 2013 13:02:47 +0000 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id r5KD2MQH020734; Thu, 20 Jun 2013 08:02:22 -0500 Received: from DFLE73.ent.ti.com (dfle73.ent.ti.com [128.247.5.110]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id r5KD2MW7005750; Thu, 20 Jun 2013 08:02:22 -0500 Received: from dlelxv22.itg.ti.com (172.17.1.197) by DFLE73.ent.ti.com (128.247.5.110) with Microsoft SMTP Server id 14.2.342.3; Thu, 20 Jun 2013 08:02:22 -0500 Received: from [172.24.0.243] (h0-243.vpn.ti.com [172.24.0.243]) by dlelxv22.itg.ti.com (8.13.8/8.13.8) with ESMTP id r5KD2J8G005455; Thu, 20 Jun 2013 08:02:19 -0500 Message-ID: <51C2FD5B.1090508@ti.com> Date: Thu, 20 Jun 2013 16:02:19 +0300 From: Roger Quadros User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121011 Thunderbird/16.0.1 MIME-Version: 1.0 To: Kevin Hilman Subject: Re: [RFC PATCH 5/6] ARM: dts: omap3beagle-xm: Add idle state pins for USB host References: <1371650753-11452-1-git-send-email-rogerq@ti.com> <1371650753-11452-6-git-send-email-rogerq@ti.com> <87obb26ixm.fsf@linaro.org> <51C2EDB1.3080801@ti.com> <51C2EF50.3070707@ti.com> In-Reply-To: <51C2EF50.3070707@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130620_090246_349577_CDA3AE43 X-CRM114-Status: GOOD ( 16.31 ) X-Spam-Score: -8.2 (--------) Cc: linux-usb@vger.kernel.org, =?UTF-8?B?QmVub8OudCBDb3Vzc29u?= , tony@atomide.com, ruslan.bilovol@ti.com, linux-kernel@vger.kernel.org, balbi@ti.com, stern@rowland.harvard.edu, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 06/20/2013 03:02 PM, Roger Quadros wrote: > On 06/20/2013 02:55 PM, Roger Quadros wrote: >> On 06/19/2013 09:42 PM, Kevin Hilman wrote: >>> Roger Quadros writes: >>> >>>> Add the Idle state pins for USB host and enable WAKEUP on >>>> DIR, DAT0-3, so that the PHY can wakeup the OMAP SoC from >>>> sleep on any USB activity (e.g. remote wakeup or connect/disconnect). >>>> >>>> CC: Benoît Cousson >>>> Signed-off-by: Roger Quadros >>> >>> This one doesn't apply... >>> >>>> --- >>>> arch/arm/boot/dts/omap3-beagle-xm.dts | 29 +++++++++++++++++++++++------ >>>> 1 files changed, 23 insertions(+), 6 deletions(-) >>>> >>>> diff --git a/arch/arm/boot/dts/omap3-beagle-xm.dts b/arch/arm/boot/dts/omap3-beagle-xm.dts >>>> index d3808ed..f1d56c2 100644 >>>> --- a/arch/arm/boot/dts/omap3-beagle-xm.dts >>>> +++ b/arch/arm/boot/dts/omap3-beagle-xm.dts >>>> @@ -89,12 +89,7 @@ >>>> }; >>>> >>>> &omap3_pmx_core { >>>> - pinctrl-names = "default"; >>>> - pinctrl-0 = < >>>> - &hsusbb2_pins >>>> - >; >>>> - >>>> - hsusbb2_pins: pinmux_hsusbb2_pins { >>> >>> This omap3_pmx_core section doesn't exist upstream in the xM DTS file >>> (but does in omap3-beagle.dts.) >>> >>> Is there a dependency patch missing? >>> >> >> Sorry for not mentioning it earlier. This is based on Benoit's tree [1] >> and you need these patches >> >> http://thread.gmane.org/gmane.linux.drivers.devicetree/38383 > > Just noticed that this no longer applies today. I'll send a revision soon. > OK. In case you are eager to test, please use the series [1] on l-o on top of Benoit's for_3.11/_dts branch and then the $subject series with the updated patch 5 below [2]. [1] - [PATCH v5 0/2] ARM: dts: Add USB host support for Beagle-xm [2] - Updated Patch 5 From b712a1fb936f65fa05f21fcd2c62fff5628d0628 Mon Sep 17 00:00:00 2001 From: Roger Quadros Date: Wed, 19 Jun 2013 11:14:35 +0300 Subject: [PATCH] ARM: dts: omap3beagle-xm: Add idle state pins for USB host MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Add the Idle state pins for USB host and enable WAKEUP on DIR, DAT0-3, so that the PHY can wakeup the OMAP SoC from sleep on any USB activity (e.g. remote wakeup or connect/disconnect). CC: Benoît Cousson Signed-off-by: Roger Quadros --- arch/arm/boot/dts/omap3-beagle-xm.dts | 29 +++++++++++++++++++++++------ 1 files changed, 23 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts/omap3-beagle-xm.dts b/arch/arm/boot/dts/omap3-beagle-xm.dts index 371b1e2..91d19fa 100644 --- a/arch/arm/boot/dts/omap3-beagle-xm.dts +++ b/arch/arm/boot/dts/omap3-beagle-xm.dts @@ -113,11 +113,6 @@ }; &omap3_pmx_core { - pinctrl-names = "default"; - pinctrl-0 = < - &hsusbb2_pins - >; - uart3_pins: pinmux_uart3_pins { pinctrl-single,pins = < 0x16e (PIN_INPUT | PIN_OFF_WAKEUPENABLE | MUX_MODE0) /* uart3_rx_irrx.uart3_rx_irrx */ @@ -125,7 +120,7 @@ >; }; - hsusbb2_pins: pinmux_hsusbb2_pins { + hsusb2_pins: pinmux_hsusb2_pins { pinctrl-single,pins = < 0x5c0 (PIN_OUTPUT | MUX_MODE3) /* etk_d10.hsusb2_clk */ 0x5c2 (PIN_OUTPUT | MUX_MODE3) /* etk_d11.hsusb2_stp */ @@ -141,6 +136,25 @@ 0x1ae (PIN_INPUT_PULLDOWN | MUX_MODE3) /* mcspi2_cs1.hsusb2_data3 */ >; }; + + /* WAKEUP enabled on DIR, DAT0-3 */ + hsusb2_idle_pins: pinmux_hsusb2_idle_pins { + pinctrl-single,pins = < + 0x5c0 (PIN_OUTPUT | MUX_MODE3) /* etk_d10.hsusb2_clk */ + 0x5c2 (PIN_OUTPUT | MUX_MODE3) /* etk_d11.hsusb2_stp */ + 0x5c4 (PIN_INPUT_PULLDOWN | WAKEUP_EN | MUX_MODE3) /* etk_d12.hsusb2_dir */ + 0x5c6 (PIN_INPUT_PULLDOWN | MUX_MODE3) /* etk_d13.hsusb2_nxt */ + 0x5c8 (PIN_INPUT_PULLDOWN | WAKEUP_EN | MUX_MODE3) /* etk_d14.hsusb2_data0 */ + 0x5cA (PIN_INPUT_PULLDOWN | WAKEUP_EN | MUX_MODE3) /* etk_d15.hsusb2_data1 */ + 0x1a4 (PIN_INPUT_PULLDOWN | MUX_MODE3) /* mcspi1_cs3.hsusb2_data2 */ + 0x1a6 (PIN_INPUT_PULLDOWN | MUX_MODE3) /* mcspi2_clk.hsusb2_data7 */ + 0x1a8 (PIN_INPUT_PULLDOWN | MUX_MODE3) /* mcspi2_simo.hsusb2_data4 */ + 0x1aa (PIN_INPUT_PULLDOWN | MUX_MODE3) /* mcspi2_somi.hsusb2_data5 */ + 0x1ac (PIN_INPUT_PULLDOWN | MUX_MODE3) /* mcspi2_cs0.hsusb2_data6 */ + 0x1ae (PIN_INPUT_PULLDOWN | WAKEUP_EN | MUX_MODE3) /* mcspi2_cs1.hsusb2_data3 */ + >; + interrupts = <77>; /* route padconf wakeup to EHCI IRQ */ + }; }; &i2c1 { @@ -223,6 +237,9 @@ }; &usbhshost { + pinctrl-names = "default", "idle"; + pinctrl-0 = <&hsusb2_pins>; + pinctrl-1 = <&hsusb2_idle_pins>; port2-mode = "ehci-phy"; };