From patchwork Wed Jul 24 14:16:52 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roger Quadros X-Patchwork-Id: 2832824 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id AE9D5C0319 for ; Wed, 24 Jul 2013 14:22:30 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2B73A202E6 for ; Wed, 24 Jul 2013 14:22:29 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9E2A2202DB for ; Wed, 24 Jul 2013 14:22:27 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1V1zxQ-00008l-GJ; Wed, 24 Jul 2013 14:22:24 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1V1zsY-0004uJ-O2; Wed, 24 Jul 2013 14:17:22 +0000 Received: from devils.ext.ti.com ([198.47.26.153]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1V1zsU-0004tI-E8 for linux-arm-kernel@lists.infradead.org; Wed, 24 Jul 2013 14:17:19 +0000 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id r6OEGt3m013706; Wed, 24 Jul 2013 09:16:55 -0500 Received: from DFLE72.ent.ti.com (dfle72.ent.ti.com [128.247.5.109]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id r6OEGtoY018431; Wed, 24 Jul 2013 09:16:55 -0500 Received: from dlelxv22.itg.ti.com (172.17.1.197) by DFLE72.ent.ti.com (128.247.5.109) with Microsoft SMTP Server id 14.2.342.3; Wed, 24 Jul 2013 09:16:54 -0500 Received: from [172.24.113.24] (h113-24.vpn.ti.com [172.24.113.24]) by dlelxv22.itg.ti.com (8.13.8/8.13.8) with ESMTP id r6OEGq8l019194; Wed, 24 Jul 2013 09:16:52 -0500 Message-ID: <51EFE1D4.8090307@ti.com> Date: Wed, 24 Jul 2013 17:16:52 +0300 From: Roger Quadros User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121011 Thunderbird/16.0.1 MIME-Version: 1.0 To: Tero Kristo Subject: Re: [PATCHv4 00/33] ARM: OMAP: clock conversion to DT References: <1374564028-11352-1-git-send-email-t-kristo@ti.com> In-Reply-To: <1374564028-11352-1-git-send-email-t-kristo@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130724_101718_561206_2CDAFD75 X-CRM114-Status: GOOD ( 22.79 ) X-Spam-Score: -6.9 (------) Cc: nm@ti.com, paul@pwsan.com, khilman@linaro.org, mturquette@linaro.org, tony@atomide.com, devicetree-discuss@lists.ozlabs.org, rnayak@ti.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 07/23/2013 10:19 AM, Tero Kristo wrote: > Hi, > > Changes compared to previous version: > > - Clock init files moved from mach-omap2/ to drivers/clk/omap/ > - AM33xx support added [patches 15-20] > - OMAP3 support added [patches 21-29] > - DRA7 APLL support added (thanks Keerthy) [patches 30-33] > > Test branch on top of 3.11-rc1 available here: > > git://gitorious.org/~kristo/omap-pm/omap-pm-work.git > branch: mainline-3.11-rc1-omap-dt-clks > > Testing done: > > - boot + suspend tested on OMAP3 beagle C4 (omap3530) > - boot + suspend tested on OMAP4 panda ES (omap4460) > - boot tested on beagle bone (am335x) > > A boot test was also executed for DRA7 and OMAP5 on a separate branch > (mainline does not have OMAP5 / DRA7 support so far.) Thanks to your hints, I was able to get this to work with 3.11-rc1 on omap5 uevm using the following 3 patches. Please include them in your series. Thanks. cheers, -roger From 8836bc00aea3c97206244c3f8a66e2726c835854 Mon Sep 17 00:00:00 2001 From: Roger Quadros Date: Wed, 24 Jul 2013 16:30:55 +0300 Subject: [PATCH 3/3] CLK: omap5: Initialize USB_DPLL at boot USB_DPLL must be initialized and locked at boot so that USB modules can work. Signed-off-by: Roger Quadros --- drivers/clk/omap/clk-54xx.c | 13 ++++++++++++- 1 files changed, 12 insertions(+), 1 deletions(-) diff --git a/drivers/clk/omap/clk-54xx.c b/drivers/clk/omap/clk-54xx.c index ade0481..a0b3c14 100644 --- a/drivers/clk/omap/clk-54xx.c +++ b/drivers/clk/omap/clk-54xx.c @@ -19,6 +19,12 @@ #define OMAP5_DPLL_ABE_DEFFREQ 98304000 +/* + * OMAP543x TRM, section "3.6.3.9.5 DPLL_USB Preferred Settings" + * states it must be at 960MHz + */ +#define OMAP5_DPLL_USB_DEFFREQ 960000000 + static struct omap_dt_clk omap54xx_clks[] = { DT_CLK(NULL, "timer_32k_ck", "sys_32k_ck"), DT_CLK("omap_timer.1", "sys_ck", "sys_clkin"), @@ -37,7 +43,7 @@ static struct omap_dt_clk omap54xx_clks[] = { int __init omap5xxx_clk_init(void) { int rc; - struct clk *abe_dpll_ref, *abe_dpll, *sys_32k_ck; + struct clk *abe_dpll_ref, *abe_dpll, *sys_32k_ck, *usb_dpll; dt_omap_clk_init(); @@ -54,5 +60,10 @@ int __init omap5xxx_clk_init(void) if (rc) pr_err("%s: failed to configure ABE DPLL!\n", __func__); + usb_dpll = clk_get_sys(NULL, "dpll_usb_ck"); + rc = clk_set_rate(usb_dpll, OMAP5_DPLL_USB_DEFFREQ); + if (rc) + pr_err("%s: failed to configure USB DPLL!\n", __func__); + return 0; } -- 1.7.4.1