From patchwork Thu Jul 25 20:59:25 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Santosh Shilimkar X-Patchwork-Id: 2833674 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 5B4D6C0319 for ; Thu, 25 Jul 2013 20:59:59 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4C1EF201D5 for ; Thu, 25 Jul 2013 20:59:58 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6D6A220190 for ; Thu, 25 Jul 2013 20:59:55 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1V2Sdd-0006ji-1M; Thu, 25 Jul 2013 20:59:53 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1V2Sda-0005in-RO; Thu, 25 Jul 2013 20:59:50 +0000 Received: from devils.ext.ti.com ([198.47.26.153]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1V2SdX-0005iQ-T4 for linux-arm-kernel@lists.infradead.org; Thu, 25 Jul 2013 20:59:48 +0000 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id r6PKxQRN011263; Thu, 25 Jul 2013 15:59:26 -0500 Received: from DLEE70.ent.ti.com (dlee70.ent.ti.com [157.170.170.113]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id r6PKxQga010131; Thu, 25 Jul 2013 15:59:26 -0500 Received: from dlelxv22.itg.ti.com (172.17.1.197) by DLEE70.ent.ti.com (157.170.170.113) with Microsoft SMTP Server id 14.2.342.3; Thu, 25 Jul 2013 15:59:25 -0500 Received: from [158.218.103.117] (ula0393909.am.dhcp.ti.com [158.218.103.117]) by dlelxv22.itg.ti.com (8.13.8/8.13.8) with ESMTP id r6PKxP0e004251; Thu, 25 Jul 2013 15:59:25 -0500 Message-ID: <51F191AD.9020108@ti.com> Date: Thu, 25 Jul 2013 16:59:25 -0400 From: Santosh Shilimkar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Sekhar Nori Subject: Re: [PATCH 1/2] i2c: davinci: remove useless mach/hardware include References: <1374712099-32095-1-git-send-email-santosh.shilimkar@ti.com> <1374712099-32095-2-git-send-email-santosh.shilimkar@ti.com> <51F0F283.5080900@ti.com> In-Reply-To: <51F0F283.5080900@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130725_165948_025333_3B8EDF20 X-CRM114-Status: GOOD ( 14.83 ) X-Spam-Score: -6.9 (------) Cc: linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Wolfram Sang X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Thursday 25 July 2013 05:40 AM, Sekhar Nori wrote: > On Thursday 25 July 2013 05:58 AM, Santosh Shilimkar wrote: >> This driver no longer uses definitions from mach/hardware.h. >> On the other hand, including this header breaks this driver >> on non-davinci platforms which don't have such a header. >> >> Fix it. >> >> Cc: Sekhar Nori >> Cc: Wolfram Sang >> >> Signed-off-by: Santosh Shilimkar > > Acked-by: Sekhar Nori > > One minor nit: > >> --- >> drivers/i2c/busses/i2c-davinci.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c >> index fa55605..ddaa2a3 100644 >> --- a/drivers/i2c/busses/i2c-davinci.c >> +++ b/drivers/i2c/busses/i2c-davinci.c >> @@ -41,7 +41,6 @@ >> #include >> #include >> > > You can now remove this empty line too. > Yes. Updated patch below with your ack added. Regards, Santosh From d7ae1c488ebae19028f33abff76c4d684271a7fb Mon Sep 17 00:00:00 2001 From: Santosh Shilimkar Date: Tue, 23 Jul 2013 15:40:46 -0400 Subject: [PATCH 1/2] i2c: davinci: remove useless mach/hardware include This driver no longer uses definitions from mach/hardware.h. On the other hand, including this header breaks this driver on non-davinci platforms which don't have such a header. Fix it. Cc: Wolfram Sang Acked-by: Sekhar Nori Signed-off-by: Santosh Shilimkar --- drivers/i2c/busses/i2c-davinci.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c index fa55605..5898df3 100644 --- a/drivers/i2c/busses/i2c-davinci.c +++ b/drivers/i2c/busses/i2c-davinci.c @@ -40,8 +40,6 @@ #include #include #include - -#include #include /* ----- global defines ----------------------------------------------- */