diff mbox

[3.10-stable] at91sam9x5 rtc causes damage

Message ID 52027AB3.1040806@interlog.com (mailing list archive)
State New, archived
Headers show

Commit Message

Douglas Gilbert Aug. 7, 2013, 4:49 p.m. UTC
This one probably needs more sign-offs but some folks seem to be
away. It is pretty simple and fixed in the current lk 3.11.0-rc
series. So it just impacts the lk 3.10 series including lk 3.10.5 .

ChangeLog:
   - without this patch members of the at91sam9x5 family (e.g.
     at91sam9g25) that use the RTC will receive an unhandled
     interrupt whenever they try to write to the RTC. In the
     case of 9x5 SoCs that is the SYS interrupt shared with
     several other things such as the debug port. Thereafter
     the debug port becomes useless (for input), the RTC doesn't
     work ...

Signed-off-by: Douglas Gilbert <dgilbert@interlog.com>

Comments

Greg KH Aug. 7, 2013, 7:08 p.m. UTC | #1
On Wed, Aug 07, 2013 at 12:49:55PM -0400, Douglas Gilbert wrote:
> This one probably needs more sign-offs but some folks seem to be
> away. It is pretty simple and fixed in the current lk 3.11.0-rc
> series. So it just impacts the lk 3.10 series including lk 3.10.5 .
> 
> ChangeLog:
>   - without this patch members of the at91sam9x5 family (e.g.
>     at91sam9g25) that use the RTC will receive an unhandled
>     interrupt whenever they try to write to the RTC. In the
>     case of 9x5 SoCs that is the SYS interrupt shared with
>     several other things such as the debug port. Thereafter
>     the debug port becomes useless (for input), the RTC doesn't
>     work ...
> 
> Signed-off-by: Douglas Gilbert <dgilbert@interlog.com>

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
for how to do this properly.

</formletter>
Douglas Gilbert Aug. 7, 2013, 7:24 p.m. UTC | #2
On 13-08-07 03:08 PM, Greg KH wrote:
> On Wed, Aug 07, 2013 at 12:49:55PM -0400, Douglas Gilbert wrote:
>> This one probably needs more sign-offs but some folks seem to be
>> away. It is pretty simple and fixed in the current lk 3.11.0-rc
>> series. So it just impacts the lk 3.10 series including lk 3.10.5 .
>>
>> ChangeLog:
>>    - without this patch members of the at91sam9x5 family (e.g.
>>      at91sam9g25) that use the RTC will receive an unhandled
>>      interrupt whenever they try to write to the RTC. In the
>>      case of 9x5 SoCs that is the SYS interrupt shared with
>>      several other things such as the debug port. Thereafter
>>      the debug port becomes useless (for input), the RTC doesn't
>>      work ...
>>
>> Signed-off-by: Douglas Gilbert <dgilbert@interlog.com>
>
> <formletter>
>
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
> for how to do this properly.
>
> </formletter>

Fine. I'll leave it.

Doug Gilbert
Greg KH Aug. 7, 2013, 7:34 p.m. UTC | #3
On Wed, Aug 07, 2013 at 03:24:39PM -0400, Douglas Gilbert wrote:
> On 13-08-07 03:08 PM, Greg KH wrote:
> >On Wed, Aug 07, 2013 at 12:49:55PM -0400, Douglas Gilbert wrote:
> >>This one probably needs more sign-offs but some folks seem to be
> >>away. It is pretty simple and fixed in the current lk 3.11.0-rc
> >>series. So it just impacts the lk 3.10 series including lk 3.10.5 .
> >>
> >>ChangeLog:
> >>   - without this patch members of the at91sam9x5 family (e.g.
> >>     at91sam9g25) that use the RTC will receive an unhandled
> >>     interrupt whenever they try to write to the RTC. In the
> >>     case of 9x5 SoCs that is the SYS interrupt shared with
> >>     several other things such as the debug port. Thereafter
> >>     the debug port becomes useless (for input), the RTC doesn't
> >>     work ...
> >>
> >>Signed-off-by: Douglas Gilbert <dgilbert@interlog.com>
> >
> ><formletter>
> >
> >This is not the correct way to submit patches for inclusion in the
> >stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
> >for how to do this properly.
> >
> ></formletter>
> 
> Fine. I'll leave it.

Leave what?  Did you read the above file that shows how to get a patch
into the stable tree?  Follow that and all should be fine.

thanks,

greg k-h
diff mbox

Patch

diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi
index d1b5199..4227464 100644
--- a/arch/arm/boot/dts/at91sam9x5.dtsi
+++ b/arch/arm/boot/dts/at91sam9x5.dtsi
@@ -643,7 +643,7 @@ 
 			};
 
 			rtc@fffffeb0 {
-				compatible = "atmel,at91rm9200-rtc";
+				compatible = "atmel,at91sam9x5-rtc";
 				reg = <0xfffffeb0 0x40>;
 				interrupts = <1 4 7>;
 				status = "disabled";