From patchwork Tue Dec 3 09:36:57 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roger Quadros X-Patchwork-Id: 3275271 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 9CE15C0D4A for ; Tue, 3 Dec 2013 10:37:07 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8EAF420270 for ; Tue, 3 Dec 2013 10:37:06 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DF2092034B for ; Tue, 3 Dec 2013 10:37:04 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VnmQL-0005sz-AH; Tue, 03 Dec 2013 09:37:45 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VnmQ4-00068t-Gi; Tue, 03 Dec 2013 09:37:28 +0000 Received: from devils.ext.ti.com ([198.47.26.153]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VnmQ1-00067m-MO for linux-arm-kernel@lists.infradead.org; Tue, 03 Dec 2013 09:37:26 +0000 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id rB39b117000750; Tue, 3 Dec 2013 03:37:01 -0600 Received: from DLEE71.ent.ti.com (dlee71.ent.ti.com [157.170.170.114]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id rB39b0b5014650; Tue, 3 Dec 2013 03:37:01 -0600 Received: from dlep33.itg.ti.com (157.170.170.75) by DLEE71.ent.ti.com (157.170.170.114) with Microsoft SMTP Server id 14.2.342.3; Tue, 3 Dec 2013 03:37:00 -0600 Received: from [172.24.112.111] (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id rB39avDK014572; Tue, 3 Dec 2013 03:36:58 -0600 Message-ID: <529DA639.8000905@ti.com> Date: Tue, 3 Dec 2013 11:36:57 +0200 From: Roger Quadros User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 MIME-Version: 1.0 To: Laurent Pinchart Subject: Re: [PATCH] ARM: dts: omap3-beagle: Fix USB host on beagle boards (for 3.13) References: <1385387745-7162-1-git-send-email-rogerq@ti.com> <3636447.xncPcCYRzc@avalon> In-Reply-To: <3636447.xncPcCYRzc@avalon> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20131203_043725_799442_CDCC0F90 X-CRM114-Status: GOOD ( 13.65 ) X-Spam-Score: -6.9 (------) Cc: nm@ti.com, devicetree@vger.kernel.org, tony@atomide.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, balbi@ti.com, bcousson@baylibre.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Laurent, On 12/03/2013 05:54 AM, Laurent Pinchart wrote: > Hi Roger, > > On Monday 25 November 2013 15:55:45 Roger Quadros wrote: >> Beagle (rev. C4) and Beagle-XM (all revs) need VAUX2 1.8V supply >> for the USB PHY. >> >> As the generic PHY driver can't handle more than one supply >> at the moment, we configure this supply to be always on. >> This will cause a very small power impact if the USB host subsystem >> is not in use, about 76.86 micro-W + LDO power. >> >> Older Beagle boards (prior to C4) don't have VAUX2 connected anywhere, >> so there won't be any functional impact on those boards other than >> some additional LDO power consumption. > > Do I need any patch other than this one (on top of v3.13-rc1) to enable the > ethernet port on a Beagleboard-xM rev B ? Here's what the kernel reports at > boot (with ignore_loglevel set on the command line). > It seems on Rev A/B, the power enable line for the USB hub has reversed polarity than Rev C. Does the below patch work for you? If yes, how do we account for it? Do we add a new file "omap3-beagle-xm-ab.dts" for rev A/B boards? cheers, -roger diff --git a/arch/arm/boot/dts/omap3-beagle-xm.dts b/arch/arm/boot/dts/omap3-beagle-xm.dts index b39918e..434d903 100644 --- a/arch/arm/boot/dts/omap3-beagle-xm.dts +++ b/arch/arm/boot/dts/omap3-beagle-xm.dts @@ -78,6 +78,7 @@ regulator-max-microvolt = <3300000>; gpio = <&twl_gpio 18 0>; /* GPIO LEDA */ startup-delay-us = <70000>; + enable-active-high; }; /* HS USB Host PHY on PORT 2 */