From patchwork Fri May 9 08:23:32 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roger Quadros X-Patchwork-Id: 4140741 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 37AD0BFF02 for ; Fri, 9 May 2014 08:26:33 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 412ED202DD for ; Fri, 9 May 2014 08:26:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2DE13201DE for ; Fri, 9 May 2014 08:26:31 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Wig6I-00024s-2r; Fri, 09 May 2014 08:24:14 +0000 Received: from arroyo.ext.ti.com ([192.94.94.40]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Wig6E-0001uH-CV for linux-arm-kernel@lists.infradead.org; Fri, 09 May 2014 08:24:12 +0000 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id s498NaLo019136; Fri, 9 May 2014 03:23:37 -0500 Received: from DFLE73.ent.ti.com (dfle73.ent.ti.com [128.247.5.110]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id s498Nak3006640; Fri, 9 May 2014 03:23:36 -0500 Received: from dflp33.itg.ti.com (10.64.6.16) by DFLE73.ent.ti.com (128.247.5.110) with Microsoft SMTP Server id 14.3.174.1; Fri, 9 May 2014 03:23:36 -0500 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id s498NWlu020553; Fri, 9 May 2014 03:23:33 -0500 Message-ID: <536C9084.50209@ti.com> Date: Fri, 9 May 2014 11:23:32 +0300 From: Roger Quadros User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Kevin Hilman , Tony Lindgren Subject: Re: omap4-panda-es boot issues with v3.15-rc4 References: <536B7E44.2040303@ti.com> <7hppjos2w2.fsf@paris.lan> <20140508165558.GB2198@atomide.com> <20140508184055.GC2198@atomide.com> <7hha4zsyro.fsf@paris.lan> In-Reply-To: <7hha4zsyro.fsf@paris.lan> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140509_012410_564414_D58B23B9 X-CRM114-Status: GOOD ( 14.28 ) X-Spam-Score: -5.7 (-----) Cc: "Menon, Nishanth" , Paul Walmsley , Grygorii Strashko , "Rafael J. Wysocki" , Paul Burton , Taras Kondratiuk , Daniel Lezcano , "Kristo, Tero" , "Shilimkar, Santosh" , "linux-omap@vger.kernel.org" , Linux ARM Kernel Mailing List X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Kevin, On 05/09/2014 01:15 AM, Kevin Hilman wrote: > Tony Lindgren writes: > > [...] > >> ..but I think I found the cause for recent hangs on panda, just a wild >> guess based on looking at the recent cpuidle patches after v3.14. >> >> Looks like reverting 0b89e9aa2856 (cpuidle: delay enabling interrupts >> until all coupled CPUs leave idle) makes booting work reliably again >> on panda. >> >> Can you guys confirm, so far no issues here after few boot tests, >> but it might be too early to tell. > > Reverting that makes things a bit more stable, but it still eventually > fails in the same way. For me it took 8 boots for it to eventually > fail. > > However, if I build with CONFIG_CPU_IDLE=n, it becomes much more stable > (20+ boots in a row and still going.) > Can you please test with CPU_IDLE enabled but C3 disabled as in below patch? It worked for me 10/10 boots. diff --git a/arch/arm/mach-omap2/cpuidle44xx.c b/arch/arm/mach-omap2/cpuidle44xx.c index 01fc710..99362ff 100644 --- a/arch/arm/mach-omap2/cpuidle44xx.c +++ b/arch/arm/mach-omap2/cpuidle44xx.c @@ -206,7 +206,12 @@ static struct cpuidle_driver omap4_idle_driver = { .desc = "CPUx OFF, MPUSS OSWR", }, }, - .state_count = ARRAY_SIZE(omap4_idle_data), +/* + * Disable C3 state since it is unstable + * + * .state_count = ARRAY_SIZE(omap4_idle_data), + */ + .state_count = 2, .safe_state_index = 0, };