From patchwork Wed Jul 2 06:00:33 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tushar Behera X-Patchwork-Id: 4463581 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id A3A8CBEEAA for ; Wed, 2 Jul 2014 06:03:41 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DF3B420222 for ; Wed, 2 Jul 2014 06:03:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1F55720211 for ; Wed, 2 Jul 2014 06:03:40 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1X2DbL-0007f6-Fm; Wed, 02 Jul 2014 06:01:03 +0000 Received: from mail-pd0-x236.google.com ([2607:f8b0:400e:c02::236]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1X2DbI-0007d9-Vg for linux-arm-kernel@lists.infradead.org; Wed, 02 Jul 2014 06:01:01 +0000 Received: by mail-pd0-f182.google.com with SMTP id y13so11432192pdi.27 for ; Tue, 01 Jul 2014 23:00:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=mFycfn/EnaMSHBgvOjHwot6eVqX62r+oXH+F6Lf80Zc=; b=KlKH68FderrCizDCffEVsxq/80iS2zrw3CDpQZNV8JtSURjeke/FDupzLVIRe/VeZB VLyfGAUBIb1kLHrEBFQ1KY04FleOzCpJ5Kt/J9VY3dVRaSX1ueOmO2zqqSv2Yrp43MlI DRw2GnmCzBQ6iPOXpUFtniV9s70oa3RpmWCr1kLFb3MlAYj5v3+SWnqSFJiIHxJUV4oy 22nQxmK6SnAazSj30ESIjcjBL424x0I0tOGakTj4WKHT9QtjyZfEiTlaEbCdkdZTW7+8 onGrDmbc/zzDhaNopTCZjM1lHs8sXSG63GPCrwrBDV/h8opMuW+cHs1bxuWj3tiARqAJ I5og== X-Received: by 10.66.254.37 with SMTP id af5mr1597924pad.113.1404280838511; Tue, 01 Jul 2014 23:00:38 -0700 (PDT) Received: from [10.10.10.29] ([14.140.216.146]) by mx.google.com with ESMTPSA id jb5sm35377053pbd.73.2014.07.01.23.00.34 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 01 Jul 2014 23:00:37 -0700 (PDT) Message-ID: <53B3A001.1090909@gmail.com> Date: Wed, 02 Jul 2014 11:30:33 +0530 From: Tushar Behera User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Laura Abbott , Russell King , Kevin Hilman , Grant Likely , Rob Herring Subject: Re: [PATCHv2 1/3] of: Split early_init_dt_scan into two parts References: <1404266608-3274-1-git-send-email-lauraa@codeaurora.org> In-Reply-To: <1404266608-3274-1-git-send-email-lauraa@codeaurora.org> X-Enigmail-Version: 1.6 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140701_230101_035237_B9A5A809 X-CRM114-Status: GOOD ( 14.90 ) X-Spam-Score: -0.8 (/) Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linaro-kernel@lists.linaro.org, linux-arm-kernel@lists.infradead.org, afaerber@suse.de X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 07/02/2014 07:33 AM, Laura Abbott wrote: > Currently, early_init_dt_scan validates the header, sets the > boot params, and scans for chosen/memory all in one function. > Split this up into two separate functions (validation/setting > boot params in one, scanning in another) to allow for > additional setup between boot params and scanning the memory. > > Signed-off-by: Laura Abbott > --- Tested the patchset on top of Linus' tree. Verified after enabling following debug message. Output before: memory scan node memory, reg size 96, data: 20 10 30 10, Output after: memory scan node memory, reg size 64, data: 20 10 30 10, Tested-by: Tushar Behera One minor nit below ... > drivers/of/fdt.c | 18 +++++++++++++++++- > include/linux/of_fdt.h | 2 ++ > 2 files changed, 19 insertions(+), 1 deletion(-) > > diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c > index c4cddf0..55bfca9 100644 > --- a/drivers/of/fdt.c > +++ b/drivers/of/fdt.c > @@ -922,7 +922,7 @@ int __init __weak early_init_dt_reserve_memory_arch(phys_addr_t base, > } > #endif > > -bool __init early_init_dt_scan(void *params) > +bool __init early_init_dt_verify(void *params) > { > if (!params) > return false; > @@ -936,6 +936,12 @@ bool __init early_init_dt_scan(void *params) > return false; > } > > + return true; > +} > + > + Extra blank line here. Can be removed. --- a/drivers/of/fdt.c +++ b/drivers/of/fdt.c @@ -865,7 +865,7 @@ int __init early_init_dt_scan_memory(unsigned long node, const char *uname, endp = reg + (l / sizeof(__be32)); - pr_debug("memory scan node %s, reg size %d, data: %x %x %x %x,\n", + pr_err("memory scan node %s, reg size %d, data: %x %x %x %x,\n",