From patchwork Fri Aug 1 10:26:23 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudeep Holla X-Patchwork-Id: 4662291 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id ABE9CC0338 for ; Fri, 1 Aug 2014 10:28:12 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D20B42020F for ; Fri, 1 Aug 2014 10:28:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D9AE82020A for ; Fri, 1 Aug 2014 10:28:10 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1XDA2N-0003x5-R3; Fri, 01 Aug 2014 10:26:11 +0000 Received: from service87.mimecast.com ([91.220.42.44]) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1XDA2H-0003re-68 for linux-arm-kernel@lists.infradead.org; Fri, 01 Aug 2014 10:26:06 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Fri, 01 Aug 2014 11:25:39 +0100 Received: from [10.1.207.61] ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Fri, 1 Aug 2014 11:25:39 +0100 Message-ID: <53DB6B4F.9080605@arm.com> Date: Fri, 01 Aug 2014 11:26:23 +0100 From: Sudeep Holla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Olof Johansson , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH] ARM: multi_v7_defconfig: major refresh References: <1406052070-6207-1-git-send-email-olof@lixom.net> In-Reply-To: <1406052070-6207-1-git-send-email-olof@lixom.net> X-OriginalArrivalTime: 01 Aug 2014 10:25:39.0343 (UTC) FILETIME=[F0B6E9F0:01CFAD72] X-MC-Unique: 114080111253901601 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140801_032605_524541_67E5EF06 X-CRM114-Status: GOOD ( 15.41 ) X-Spam-Score: -2.3 (--) Cc: "arm@kernel.org" , Pawel Moll , "kgene.kim@gmail.com" , Sudeep Holla , "lee.jones@linaro.org" , "maxime.coquelin@st.com" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 22/07/14 19:01, Olof Johansson wrote: > This is a major refresh of the multi_v7_defconfig: > > - Bring over a bunch of Samsung drivers to make ODROID-U3 and Chromebooks usable > * Enable big.LITTLE > * MCPM > * CYAPA touchpad > * Samsung-related MTD/regulator/clk/pinmux drivers > * Add some of the CrOS EC drivers > - Turn on TPM, HW_RANDOM > - OMAP_USB3 -> TI_PIPE3 option rename > - Enable MCPM/b.L for VEXPRESS > - Add new CONFIG_MTD_SPI_NOR since it otherwise masks off SPI NOR drivers > - CONFIG_LOGO, because penguins. > > I took care to keep the new options that have been added for whose the > drivers are not yet in our for-next branch. This was pretty awkward so > we should sort out how to handle those better in the future. > > Signed-off-by: Olof Johansson > --- > arch/arm/configs/multi_v7_defconfig | 74 +++++++++++++++++++++++++++-------- > 1 file changed, 58 insertions(+), 16 deletions(-) > > diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig > index 16518a7..c7654cf 100644 > --- a/arch/arm/configs/multi_v7_defconfig > +++ b/arch/arm/configs/multi_v7_defconfig > @@ -50,6 +50,7 @@ CONFIG_MACH_SPEAR1310=y > CONFIG_MACH_SPEAR1340=y > CONFIG_ARCH_STI=y > CONFIG_ARCH_EXYNOS=y > +CONFIG_EXYNOS5420_MCPM=y > CONFIG_ARCH_SUNXI=y > CONFIG_ARCH_SIRF=y > CONFIG_ARCH_TEGRA=y > @@ -57,21 +58,23 @@ CONFIG_ARCH_TEGRA_2x_SOC=y > CONFIG_ARCH_TEGRA_3x_SOC=y > CONFIG_ARCH_TEGRA_114_SOC=y > CONFIG_ARCH_TEGRA_124_SOC=y > -CONFIG_TEGRA_EMC_SCALING_ENABLE=y > CONFIG_ARCH_U8500=y > CONFIG_MACH_HREFV60=y > CONFIG_MACH_SNOWBALL=y > -CONFIG_MACH_UX500_DT=y > CONFIG_ARCH_VEXPRESS=y > CONFIG_ARCH_VEXPRESS_CA9X4=y > +CONFIG_ARCH_VEXPRESS_DCSCB=y > +CONFIG_ARCH_VEXPRESS_TC2_PM=y > CONFIG_ARCH_WM8850=y > CONFIG_ARCH_ZYNQ=y > -CONFIG_TRUSTED_FOUNDATIONS=y > CONFIG_PCI=y > CONFIG_PCI_MSI=y > CONFIG_PCI_MVEBU=y > CONFIG_PCI_TEGRA=y > CONFIG_SMP=y > +CONFIG_BIG_LITTLE=y > +CONFIG_BL_SWITCHER=y IIUC, this will enable switcher code by default. I am not sure if this is intentional ? E.g.: After this I can have only 2 active cpus instead of 5 on my Vexpress TC2 platform. IMO we can keep this enabled by default in the build, but disabled by default on boot. One way to achieve this: (There's sysfs to re-enable it runtime) -->8 static int __init bL_switcher_init(void) --- > +CONFIG_BL_SWITCHER_DUMMY_IF=y This was added only for debugging purposes, again not sure if you want this enabled by default. Ideally it should be triggered by CPUFreq. Regards, Sudeep diff --git a/arch/arm/common/bL_switcher.c b/arch/arm/common/bL_switcher.c index 490f3dced749..f4c36e70166a 100644 --- a/arch/arm/common/bL_switcher.c +++ b/arch/arm/common/bL_switcher.c @@ -794,7 +794,7 @@ static int bL_switcher_hotplug_callback(struct notifier_block *nfb, return NOTIFY_DONE; } -static bool no_bL_switcher; +static bool no_bL_switcher = true; core_param(no_bL_switcher, no_bL_switcher, bool, 0644);