From patchwork Wed Sep 3 16:35:37 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Niebel X-Patchwork-Id: 4835781 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 3BC1DC0338 for ; Wed, 3 Sep 2014 16:33:07 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 24EAC2021F for ; Wed, 3 Sep 2014 16:33:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C78472021A for ; Wed, 3 Sep 2014 16:33:04 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1XPDL5-0003XH-K2; Wed, 03 Sep 2014 16:23:19 +0000 Received: from smtprelay01.ispgateway.de ([80.67.31.28]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XPDL1-0003LR-9Z for linux-arm-kernel@lists.infradead.org; Wed, 03 Sep 2014 16:23:16 +0000 Received: from [89.246.71.91] (helo=mail6.tqsc.de) by smtprelay01.ispgateway.de with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.68) (envelope-from ) id 1XPDKY-00039W-Fo for linux-arm-kernel@lists.infradead.org; Wed, 03 Sep 2014 18:22:46 +0200 Received: from sc1209091.tqsc.de ([192.168.168.49] helo=[127.0.0.1]) by mail6.tqsc.de with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.69) (envelope-from ) id 1XPDKY-0004ab-2c for linux-arm-kernel@lists.infradead.org; Wed, 03 Sep 2014 18:22:46 +0200 Message-ID: <54074359.5090500@tqsc.de> Date: Wed, 03 Sep 2014 18:35:37 +0200 From: Markus Niebel Organization: TQ Systems GmbH User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: linux-arm-kernel@lists.infradead.org Subject: [BUG] staging: imx-drm: clock reparent fails for LDB channel 1 on i.MX53 X-Df-Sender: MTQ1NzgzNQ== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140903_092315_698691_7688DF8B X-CRM114-Status: UNSURE ( 8.69 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.0 (/) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hello, playing with LVDS channel 1 on a TQMa53 with MBa53 mainboard we see error imx-ldb 53fa8008.ldb: unable to set di0 parent clock to ldb_di1 this comes from imx_ldb_set_clock with mux = 0. If setting mux parameter hard to "1" LVDS on channel 1 works just fine. The value of the mux param comes from device tree port settings. The following device tree change fixes the issue, but im not sure if this is the correct way. In my understanding the i.MX53 has no multiplexer for the input, so DI1 -> LVDS1 in case of single channel or separate channels Markus Niebel diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi index 6456a00..acdfabf 100644 --- a/arch/arm/boot/dts/imx53.dtsi +++ b/arch/arm/boot/dts/imx53.dtsi @@ -419,10 +419,14 @@ status = "disabled"; lvds-channel@0 { + #address-cells = <1>; + #size-cells = <0>; reg = <0>; status = "disabled"; port { + reg = <0>; + lvds0_in: endpoint { remote-endpoint = <&ipu_di0_lvds0>; }; @@ -430,10 +434,14 @@ }; lvds-channel@1 { + #address-cells = <1>; + #size-cells = <0>; reg = <1>; status = "disabled"; port { + reg = <1>; + lvds1_in: endpoint { remote-endpoint = <&ipu_di1_lvds1>; };