[Part2,v4,00/31] Enable hierarchy irqdomian on x86 platforms

Commit Message

Jiang Liu Nov. 5, 2014, 10:28 a.m. UTC

Hi Joerg,
	Seems like a silly bug, could you please help to try this
fix?
Regards!
Gerry
        list_for_each_entry(msidesc, &dev->msi_list, list)

On 2014/11/5 17:58, Joerg Roedel wrote:
> On Wed, Nov 05, 2014 at 05:41:50PM +0800, Jiang Liu wrote:
>> 	Could you please help to apply the attached patch and send me
>> console outputs?
> 
> Sure, here it is.
>

Comments

Joerg Roedel Nov. 5, 2014, 11:10 a.m. UTC | #1

Hi Jiang,

On Wed, Nov 05, 2014 at 06:28:45PM +0800, Jiang Liu wrote:
> diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
> index 7423ee16972f..62ba8a6f6e79 100644
> --- a/drivers/pci/msi.c
> +++ b/drivers/pci/msi.c
> @@ -1211,7 +1211,7 @@ int msi_irq_domain_alloc_irqs(struct irq_domain
> *domain, int type,
>                                 msidesc->nvec_used > 1) ?  1 : -ENOSPC;
>                 }
>                 for (i = 0; i < msidesc->nvec_used; i++)
> -                       irq_set_msi_desc_off(virq + i, i, msidesc);
> +                       irq_set_msi_desc_off(virq, i, msidesc);
>         }
> 
>         list_for_each_entry(msidesc, &dev->msi_list, list)

Yes, this fixes the issue, thanks :)


	Joerg

Patch

diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
index 7423ee16972f..62ba8a6f6e79 100644
--- a/drivers/pci/msi.c
+++ b/drivers/pci/msi.c
@@ -1211,7 +1211,7 @@  int msi_irq_domain_alloc_irqs(struct irq_domain
*domain, int type,
                                msidesc->nvec_used > 1) ?  1 : -ENOSPC;
                }
                for (i = 0; i < msidesc->nvec_used; i++)
-                       irq_set_msi_desc_off(virq + i, i, msidesc);
+                       irq_set_msi_desc_off(virq, i, msidesc);
        }