From patchwork Tue Nov 11 02:20:01 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Rowand X-Patchwork-Id: 5270281 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 56E77C11AC for ; Tue, 11 Nov 2014 02:22:49 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 865162012F for ; Tue, 11 Nov 2014 02:22:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A93102010F for ; Tue, 11 Nov 2014 02:22:47 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Xo14F-0005Jn-NE; Tue, 11 Nov 2014 02:20:27 +0000 Received: from mail-pa0-x22d.google.com ([2607:f8b0:400e:c03::22d]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Xo14D-0004z5-9y for linux-arm-kernel@lists.infradead.org; Tue, 11 Nov 2014 02:20:26 +0000 Received: by mail-pa0-f45.google.com with SMTP id lf10so9556905pab.4 for ; Mon, 10 Nov 2014 18:20:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:reply-to:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=F52Y5bxTL2okUTg/f9Vtdk2CVBwW8EbN2JNjmurT+R8=; b=gRZso9EQ/lIqLkIHkjOb51B2F/Q02OzVn1xp6hZ6YEtLL/Z5TU3JioZPIQgnrIdxOX yYoHhn/Pe3tx7dwlnS/71GIfNP6YmSGh/GyIbPOM1YlEVknqgboVmNzS+1MrH3/IOOn/ dvbHpGZbWsvpm2OQuCtZ16TgZ4/dqIU0+l8JfISj+XVIMKQXXtY7m/0i2Dnghhzl3eO5 S5d5Kfkmu6q0ozvdSb8SUEq1Wv4CtjwRWJjxsxKc16aJdUxFu/nYstlqqTeEZv3E9b69 cPlLRJfa4Hdp29Eq/kSkElQfx95utBjb+fLtI8D+wp/M72eragW5hCWMmkKU4WKa1qXh O1zQ== X-Received: by 10.68.131.133 with SMTP id om5mr35995966pbb.41.1415672404316; Mon, 10 Nov 2014 18:20:04 -0800 (PST) Received: from [192.168.1.62] (c-76-21-77-187.hsd1.ca.comcast.net. [76.21.77.187]) by mx.google.com with ESMTPSA id 16sm17753587pdj.42.2014.11.10.18.20.02 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 10 Nov 2014 18:20:03 -0800 (PST) Message-ID: <54617251.10306@gmail.com> Date: Mon, 10 Nov 2014 18:20:01 -0800 From: Frank Rowand User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: frowand.list@gmail.com Subject: Re: [PATCH] tty: serial: msm_serial: Use DT aliases References: <1414024381-12204-1-git-send-email-sboyd@codeaurora.org> <545C4E1F.4060401@gmail.com> In-Reply-To: <545C4E1F.4060401@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20141110_182025_452709_D294A4F7 X-CRM114-Status: GOOD ( 11.36 ) X-Spam-Score: -0.8 (/) Cc: Greg Kroah-Hartman , Stephen Boyd , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: frowand.list@gmail.com Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Frank Rowand v2, changes from v1: - The patch this documents was updated to make the serialN alias optional instead of required. Update devicetree binding for msm_serial to reflect msm_serial_probe() getting line id from the serial alias. Signed-off-by: Frank Rowand Reviewed-by: Stephen Boyd --- Documentation/devicetree/bindings/serial/qcom,msm-uartdm.txt | 15 +++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) Index: linux/Documentation/devicetree/bindings/serial/qcom,msm-uartdm.txt =================================================================== --- linux.orig/Documentation/devicetree/bindings/serial/qcom,msm-uartdm.txt +++ linux/Documentation/devicetree/bindings/serial/qcom,msm-uartdm.txt @@ -27,11 +27,21 @@ Optional properties: - dmas: Should contain dma specifiers for transmit and receive channels - dma-names: Should contain "tx" for transmit and "rx" for receive channels +Note: Each UART port should have an alias correctly numbered in the +"aliases" node, according to serialN format, where N is the port number +(non-negative decimal integer). If the aliases are not present then +the port numbers will be 0..(number of UARTS - 1), assigned in the driver +probe order. + Examples: A uartdm v1.4 device with dma capabilities. -serial@f991e000 { +aliases { + serial0 = &serial0; +}; + +serial0: serial@f991e000 { compatible = "qcom,msm-uartdm-v1.4", "qcom,msm-uartdm"; reg = <0xf991e000 0x1000>; interrupts = <0 108 0x0>; @@ -43,7 +53,11 @@ serial@f991e000 { A uartdm v1.3 device without dma capabilities and part of a GSBI complex. -serial@19c40000 { +aliases { + serial0 = &serial0; +}; + +serial0: serial@19c40000 { compatible = "qcom,msm-uartdm-v1.3", "qcom,msm-uartdm"; reg = <0x19c40000 0x1000>, <0x19c00000 0x1000>;