From patchwork Mon Dec 29 08:04:46 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 5548891 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 870CCBF6C3 for ; Mon, 29 Dec 2014 08:07:52 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 665F32011E for ; Mon, 29 Dec 2014 08:07:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 218CA20117 for ; Mon, 29 Dec 2014 08:07:50 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Y5VKa-0001hY-OI; Mon, 29 Dec 2014 08:05:36 +0000 Received: from comal.ext.ti.com ([198.47.26.152]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Y5VKW-0001dd-NM for linux-arm-kernel@lists.infradead.org; Mon, 29 Dec 2014 08:05:33 +0000 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by comal.ext.ti.com (8.13.7/8.13.7) with ESMTP id sBT84psL001576; Mon, 29 Dec 2014 02:04:51 -0600 Received: from DLEE70.ent.ti.com (dlee70.ent.ti.com [157.170.170.113]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id sBT84pJW009338; Mon, 29 Dec 2014 02:04:51 -0600 Received: from dflp33.itg.ti.com (10.64.6.16) by DLEE70.ent.ti.com (157.170.170.113) with Microsoft SMTP Server id 14.3.174.1; Mon, 29 Dec 2014 02:04:50 -0600 Received: from [172.22.232.70] (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id sBT84k6T004241; Mon, 29 Dec 2014 02:04:47 -0600 Message-ID: <54A10B1E.7030800@ti.com> Date: Mon, 29 Dec 2014 10:04:46 +0200 From: Tomi Valkeinen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Aaro Koskinen , Pavel Machek Subject: Re: v3.19-rc1 regression(?) on N900 References: <549B44E2.6080202@ti.com> <201412250932.40403@pali> <20141225091121.GA20355@amd> <20141225222122.GB582@fuloong-minipc.musicnaut.iki.fi> In-Reply-To: <20141225222122.GB582@fuloong-minipc.musicnaut.iki.fi> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20141229_000532_870291_A1008131 X-CRM114-Status: GOOD ( 14.60 ) X-Spam-Score: -5.0 (-----) Cc: Nishanth Menon , ivo.g.dimitrov.75@gmail.com, Tony Lindgren , sre@debian.org, linux-kernel@vger.kernel.org, sre@ring0.de, =?windows-1252?Q?Pali_Roh=E1r?= , linux-omap , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi, On 26/12/14 00:21, Aaro Koskinen wrote: > ...however, I can confirm that framebuffer is broken: > > [ 8.230743] omapfb omapfb: no displays > [ 8.255584] omapfb omapfb: failed to setup omapfb > [ 8.260620] platform omapfb: Driver omapfb requests probe deferral > [ 8.284118] of_get_named_gpiod_flags: parsed 'reset-gpios' property of node > '/ocp/spi@48098000/acx565akm@2[0]' - status (0) > [ 8.284271] acx565akm spi1.2: failed to find video source > [ 8.290069] spi spi1.2: Driver acx565akm requests probe deferral > > I bisected it to ef691ff48bc8 (OMAPDSS: DT: Get source endpoint > by matching reg-id). When I revert that, also FB works with 3.19-rc1. I've attached a patch for this. Only hack-tested on OMAP3 beagle, so please report if it works. Tomi Tested-by: Pavel Machek From fe3e8dde8eae80541a3f3b39c421428ebd02955f Mon Sep 17 00:00:00 2001 From: Tomi Valkeinen Date: Mon, 29 Dec 2014 09:57:11 +0200 Subject: [PATCH] OMAPDSS: SDI: fix output port_num After the commit ef691ff48bc8 (OMAPDSS: DT: Get source endpoint by matching reg-id) we look for the SDI output using the port number. However, the SDI driver doesn't set the port number, which causes the SDI display to not initialize. Fix this by setting the SDI port number to 1. We use a hardcoded value, as SDI was used only on OMAP3 and it's always port number 1 there. Reported-by: Aaro Koskinen Reported-by: Pavel Machek Signed-off-by: Tomi Valkeinen --- drivers/video/fbdev/omap2/dss/sdi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/video/fbdev/omap2/dss/sdi.c b/drivers/video/fbdev/omap2/dss/sdi.c index d51a983075bc..5c2ccab5a958 100644 --- a/drivers/video/fbdev/omap2/dss/sdi.c +++ b/drivers/video/fbdev/omap2/dss/sdi.c @@ -342,6 +342,8 @@ static void sdi_init_output(struct platform_device *pdev) out->output_type = OMAP_DISPLAY_TYPE_SDI; out->name = "sdi.0"; out->dispc_channel = OMAP_DSS_CHANNEL_LCD; + /* We have SDI only on OMAP3, where it's on port 1 */ + out->port_num = 1; out->ops.sdi = &sdi_ops; out->owner = THIS_MODULE; -- 2.2.1