From patchwork Thu Mar 12 12:23:18 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vince Hsu X-Patchwork-Id: 5994191 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id DB69EBF910 for ; Thu, 12 Mar 2015 12:44:10 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 108692041F for ; Thu, 12 Mar 2015 12:44:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A6AAB203E5 for ; Thu, 12 Mar 2015 12:44:08 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YW2QU-00006U-GT; Thu, 12 Mar 2015 12:41:22 +0000 Received: from hqemgate15.nvidia.com ([216.228.121.64]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YW296-0005sD-H9 for linux-arm-kernel@lists.infradead.org; Thu, 12 Mar 2015 12:23:25 +0000 Received: from hqnvupgp07.nvidia.com (Not Verified[216.228.121.13]) by hqemgate15.nvidia.com id ; Thu, 12 Mar 2015 05:23:40 -0700 Received: from hqemhub02.nvidia.com ([172.20.150.31]) by hqnvupgp07.nvidia.com (PGP Universal service); Thu, 12 Mar 2015 05:21:25 -0700 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Thu, 12 Mar 2015 05:21:25 -0700 Received: from HKMAIL104.nvidia.com (10.18.16.13) by hqemhub02.nvidia.com (172.20.150.31) with Microsoft SMTP Server (TLS) id 8.3.342.0; Thu, 12 Mar 2015 05:22:59 -0700 Received: from [10.19.108.63] (10.19.108.63) by HKMAIL104.nvidia.com (10.18.16.13) with Microsoft SMTP Server (TLS) id 15.0.847.32; Thu, 12 Mar 2015 12:22:38 +0000 Message-ID: <55018536.2050904@nvidia.com> Date: Thu, 12 Mar 2015 20:23:18 +0800 From: Vince Hsu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Tejun Heo Subject: Re: [PATCH v2 14/17] ata: ahci_tegra: remove power sequence from driver References: <1426162518-7405-1-git-send-email-vinceh@nvidia.com> <1426162518-7405-15-git-send-email-vinceh@nvidia.com> <20150312121912.GJ25944@htj.duckdns.org> In-Reply-To: <20150312121912.GJ25944@htj.duckdns.org> X-Originating-IP: [10.19.108.63] X-ClientProxiedBy: DRBGMAIL101.nvidia.com (10.18.16.20) To HKMAIL104.nvidia.com (10.18.16.13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150312_052324_666088_388D34E8 X-CRM114-Status: GOOD ( 13.34 ) X-Spam-Score: -2.7 (--) Cc: mark.rutland@arm.com, pgaikwad@nvidia.com, airlied@linux.ie, rjw@rjwysocki.net, will.deacon@arm.com, bhelgaas@google.com, thierry.reding@gmail.com, linux-pm@vger.kernel.org, gnurou@gmail.com, mturquette@linaro.org, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, viresh.kumar@linaro.org, tbergstrom@nvidia.com, robh@kernel.org, devicetree@vger.kernel.org, jroedel@suse.de, arnd@arndb.de, swarren@wwwdotorg.org, hdegoede@redhat.com, robh+dt@kernel.org, linux-tegra@vger.kernel.org, linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org, pdeschrijver@nvidia.com, sboyd@codeaurora.org, linux-kernel@vger.kernel.org, p.zabel@pengutronix.de, galak@codeaurora.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, TVD_SUBJ_WIPE_DEBT, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Cc'd Hans. Thanks, Vince On 03/12/2015 08:19 PM, Tejun Heo wrote: > On Thu, Mar 12, 2015 at 08:15:15PM +0800, Vince Hsu wrote: >> We have the generic PM domain support for Tegra SoCs now. So remove the >> duplicated sequence here. >> >> Signed-off-by: Vince Hsu > Can you please repost this patch w/ Hans de Goede > cc'd? Just reposting the patch as a reply to > itself w/ the cc added should do. > > Thanks. > Acked-by: Hans de Goede From afff7ff2011f2c3f159726ffddeaeec8f62f013e Mon Sep 17 00:00:00 2001 From: Vince Hsu Date: Wed, 14 Jan 2015 11:01:06 +0800 Subject: [PATCH v2 14/17] ata: ahci_tegra: remove power sequence from driver X-NVConfidentiality: public We have the generic PM domain support for Tegra SoCs now. So remove the duplicated sequence here. Signed-off-by: Vince Hsu --- drivers/ata/ahci_tegra.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/drivers/ata/ahci_tegra.c b/drivers/ata/ahci_tegra.c index 3a62eb246d80..8151587ddb70 100644 --- a/drivers/ata/ahci_tegra.c +++ b/drivers/ata/ahci_tegra.c @@ -120,12 +120,6 @@ static int tegra_ahci_power_on(struct ahci_host_priv *hpriv) if (ret) return ret; - ret = tegra_powergate_sequence_power_up(TEGRA_POWERGATE_SATA, - tegra->sata_clk, - tegra->sata_rst); - if (ret) - goto disable_regulators; - reset_control_assert(tegra->sata_oob_rst); reset_control_assert(tegra->sata_cold_rst); @@ -140,10 +134,6 @@ static int tegra_ahci_power_on(struct ahci_host_priv *hpriv) disable_power: clk_disable_unprepare(tegra->sata_clk); - - tegra_powergate_power_off(TEGRA_POWERGATE_SATA); - -disable_regulators: regulator_bulk_disable(ARRAY_SIZE(tegra->supplies), tegra->supplies); return ret; @@ -160,7 +150,6 @@ static void tegra_ahci_power_off(struct ahci_host_priv *hpriv) reset_control_assert(tegra->sata_cold_rst); clk_disable_unprepare(tegra->sata_clk); - tegra_powergate_power_off(TEGRA_POWERGATE_SATA); regulator_bulk_disable(ARRAY_SIZE(tegra->supplies), tegra->supplies); } -- 2.1.4