| Message ID | 55143CA1.7000606@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, On Thu, Mar 26, 2015 at 05:06:41PM +0000, Iain Paton wrote: > configure regulators as per the manufacturers recomendations from their > 3.4.x fex file. > > this is necessary to prevent operating points in the dtsi selecting > inappropriate values and causing the board to lockup > > Signed-off-by: Iain Paton <ipaton0@gmail.com> > --- > arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 34 +++++++++++++++++-------- > 1 file changed, 24 insertions(+), 10 deletions(-) > > diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts > index 5e57157..704df28 100644 > --- a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts > +++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts > @@ -123,41 +123,55 @@ > ldo24in-supply = <®_axp_ipsout>; > ldo3in-supply = <®_axp_ipsout>; > > + x-powers,dcdc-freq = <1500>; > + > regulators { > vdd_rtc: ldo1 { > regulator-min-microvolt = <1300000>; > regulator-max-microvolt = <1300000>; > regulator-always-on; > + regulator-name="vdd_rtc"; > }; > > avcc: ldo2 { > - regulator-min-microvolt = <1800000>; > - regulator-max-microvolt = <3300000>; > + regulator-min-microvolt = <3000000>; > + regulator-max-microvolt = <3000000>; > regulator-always-on; > + regulator-name="avcc"; > }; > > vcc_csi0: ldo3 { > - regulator-min-microvolt = <700000>; > - regulator-max-microvolt = <3500000>; > + regulator-min-microvolt = <2800000>; > + regulator-max-microvolt = <2800000>; > regulator-always-on; > + regulator-name="vcc_csi0"; > }; > > vcc_csi1: ldo4 { > - regulator-min-microvolt = <1250000>; > - regulator-max-microvolt = <3300000>; > + regulator-min-microvolt = <2800000>; > + regulator-max-microvolt = <2800000>; > regulator-always-on; > + regulator-name="vcc_csi1"; > + }; > + > + ldo5 { > + regulator-min-microvolt = <2800000>; > + regulator-max-microvolt = <2800000>; > + regulator-name="reg_unused"; > }; > > vdd_cpu: dcdc2 { > - regulator-min-microvolt = <700000>; > - regulator-max-microvolt = <2275000>; > + regulator-min-microvolt = <1050000>; > + regulator-max-microvolt = <1450000>; > regulator-always-on; > + regulator-name="vdd_cpu"; > }; > > vdd_int: dcdc3 { > - regulator-min-microvolt = <700000>; > - regulator-max-microvolt = <3500000>; > + regulator-min-microvolt = <1300000>; > + regulator-max-microvolt = <1300000>; > regulator-always-on; > + regulator-name="vdd_int"; Could you use the axp DTSI please? That will remove most of the chunk defined in there. Thanks! Maxime
On 31/03/15 00:13, Maxime Ripard wrote: > Hi, > > On Thu, Mar 26, 2015 at 05:06:41PM +0000, Iain Paton wrote: >> configure regulators as per the manufacturers recomendations from their >> 3.4.x fex file. >> >> this is necessary to prevent operating points in the dtsi selecting >> inappropriate values and causing the board to lockup > Could you use the axp DTSI please? > > That will remove most of the chunk defined in there. No. See my other reply. The regulators are even more board specific than the opp data and the interaction between the two is hard to handle at the best of times. Using the axp dtsi means that the board dts really has to override every single possible item that could ever be added to the dtsi just to ensure stability. This won't remove anything, it'll just add extra unnecessary stuff to the mix as well as the additional burden on people taking care of a board watching the axp dtsi to catch any additions there casuing further problems. Wishing these things were suitable for a common dtsi unfortunately doesn't change the reality whatsoever. I'm with you that exploiting commonality is generally a good thing. It's just not appropriate here. It also seems that most other boards have realised that the pmic setup is board specific and keep it in the appropriate place in the dts. The only other obvious example I can find apart from sunxi is TI, everyone else is doing the opposite. So why the resistance? A repeat of the label based syntax / alphabetical ordering thing? Rgds, Iain
On Sat, Apr 04, 2015 at 10:16:49AM +0100, Iain Paton wrote: > On 31/03/15 00:13, Maxime Ripard wrote: > > Hi, > > > > On Thu, Mar 26, 2015 at 05:06:41PM +0000, Iain Paton wrote: > >> configure regulators as per the manufacturers recomendations from their > >> 3.4.x fex file. > >> > >> this is necessary to prevent operating points in the dtsi selecting > >> inappropriate values and causing the board to lockup > > > Could you use the axp DTSI please? > > > > That will remove most of the chunk defined in there. > > No. See my other reply. The regulators are even more board specific > than the opp data and the interaction between the two is hard to > handle at the best of times. > > Using the axp dtsi means that the board dts really has to override > every single possible item that could ever be added to the dtsi just > to ensure stability. Every single possible item it actually uses. Which should be defined anyway in the board DTS anyway. The *only* difference being that you won't have to define all the regulators in your board DTS to have the *unused* ones disabled. > This won't remove anything, it'll just add extra unnecessary stuff > to the mix as well as the additional burden on people taking care of > a board watching the axp dtsi to catch any additions there casuing > further problems. Again, it actually removes the fact that you have to declare all the regulators in all the boards DTS, even if there not used at all on the board. So the fact is it removes that churn > Wishing these things were suitable for a common dtsi unfortunately > doesn't change the reality whatsoever. The reality being in this case that you defined an incomplete set of regulators? Fair enough. > I'm with you that exploiting commonality is generally a good thing. It's > just not appropriate here. > > It also seems that most other boards have realised that the pmic > setup is board specific and keep it in the appropriate place in the > dts. > > The only other obvious example I can find apart from sunxi is TI, > everyone else is doing the opposite. Which means what exactly? Apart from being the only two users, I mean? > So why the resistance? You won't have to maintain these changes, I will. More uselessly duplicated code means more useless effort, and I'm not really fond of wasting my time. > A repeat of the label based syntax / alphabetical ordering thing? How is that even related? Maxime
diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts index 5e57157..704df28 100644 --- a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts +++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts @@ -123,41 +123,55 @@ ldo24in-supply = <®_axp_ipsout>; ldo3in-supply = <®_axp_ipsout>; + x-powers,dcdc-freq = <1500>; + regulators { vdd_rtc: ldo1 { regulator-min-microvolt = <1300000>; regulator-max-microvolt = <1300000>; regulator-always-on; + regulator-name="vdd_rtc"; }; avcc: ldo2 { - regulator-min-microvolt = <1800000>; - regulator-max-microvolt = <3300000>; + regulator-min-microvolt = <3000000>; + regulator-max-microvolt = <3000000>; regulator-always-on; + regulator-name="avcc"; }; vcc_csi0: ldo3 { - regulator-min-microvolt = <700000>; - regulator-max-microvolt = <3500000>; + regulator-min-microvolt = <2800000>; + regulator-max-microvolt = <2800000>; regulator-always-on; + regulator-name="vcc_csi0"; }; vcc_csi1: ldo4 { - regulator-min-microvolt = <1250000>; - regulator-max-microvolt = <3300000>; + regulator-min-microvolt = <2800000>; + regulator-max-microvolt = <2800000>; regulator-always-on; + regulator-name="vcc_csi1"; + }; + + ldo5 { + regulator-min-microvolt = <2800000>; + regulator-max-microvolt = <2800000>; + regulator-name="reg_unused"; }; vdd_cpu: dcdc2 { - regulator-min-microvolt = <700000>; - regulator-max-microvolt = <2275000>; + regulator-min-microvolt = <1050000>; + regulator-max-microvolt = <1450000>; regulator-always-on; + regulator-name="vdd_cpu"; }; vdd_int: dcdc3 { - regulator-min-microvolt = <700000>; - regulator-max-microvolt = <3500000>; + regulator-min-microvolt = <1300000>; + regulator-max-microvolt = <1300000>; regulator-always-on; + regulator-name="vdd_int"; }; }; };
configure regulators as per the manufacturers recomendations from their 3.4.x fex file. this is necessary to prevent operating points in the dtsi selecting inappropriate values and causing the board to lockup Signed-off-by: Iain Paton <ipaton0@gmail.com> --- arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 34 +++++++++++++++++-------- 1 file changed, 24 insertions(+), 10 deletions(-)