From patchwork Thu Dec 17 16:09:25 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 7874201 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id E66179F387 for ; Thu, 17 Dec 2015 16:11:36 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id CDE572045E for ; Thu, 17 Dec 2015 16:11:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 26B1C20444 for ; Thu, 17 Dec 2015 16:11:30 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1a9b85-0001aA-Vw; Thu, 17 Dec 2015 16:10:09 +0000 Received: from mout.kundenserver.de ([212.227.126.133]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1a9b81-0000fT-IO for linux-arm-kernel@lists.infradead.org; Thu, 17 Dec 2015 16:10:07 +0000 Received: from wuerfel.localnet ([134.3.118.24]) by mrelayeu.kundenserver.de (mreue002) with ESMTPSA (Nemesis) id 0ME6mN-1ZzQUn3DTT-00HNw2; Thu, 17 Dec 2015 17:09:30 +0100 From: Arnd Bergmann To: Russell King - ARM Linux Subject: Re: [PATCH 00/10] ARM: debug-ll fixes Date: Thu, 17 Dec 2015 17:09:25 +0100 Message-ID: <5578564.K6FPRZSZVM@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20151217105020.GH8644@n2100.arm.linux.org.uk> References: <1449268242-808553-1-git-send-email-arnd@arndb.de> <20151217105020.GH8644@n2100.arm.linux.org.uk> MIME-Version: 1.0 X-Provags-ID: V03:K0:mle3xtju/7WhPpSwPXqJhR8tTDyJYl889dWnufbdYS8gWf7FlNY 52JDCjDeJMmKnC+YZXXJWaG9neCbzXujpmcCU5JvqXg6aZvHT9Si++FePGgJjMOBPcjSdYq 6O7oEaqX74G8FYBg4n604V4caNkPWMPjGzd0D4rUbfplerqXncW9XNOEo5pjEULCi+Bmhbd tWvjgFwWXREalFSRj8M5w== X-UI-Out-Filterresults: notjunk:1; V01:K0:UQGdBWpGvW8=:6Z5R6CMW75I8NXXwolcLoX FCESlT5ZCv/12zoO25vVFjHmKsx3QTJBEPVyl7JHHeupuy508B5wUbNZZyXOkQ11Rv1NS/iR0 Bpbkmt6mWAoF3MYA08xc5Vg+1WOr/jkV7SqXGOTed+vb1hKaf2Ntl5KoAHNtCPJlWNDhcLrFc sKX6v2Ic8yeDmIvAZvJeacQcLLo/lPD6n1L3rNrUEp8eFMDz3F81PI6S8KnMGQVnT/RnOyAHp LMtwf37c895/oOta75kY4T3qKdOQCQTZme08QxWUMceGuSkrlUQfuLKpIn3uHNjxozueEaELV WuYVvYWUirYGI0b5afxd/Ool1B8e519G/JpnX0Qjsfzsq5S8bDgcqkb1K124pVW6N8TdjB5R8 8LiKU8B+JF8i5meNgkzdw7dl5rfgHyvbUMKRZakLh0OK8wdEKWZaPAnO4VbuXd+Sx/wjOKn+U +RFS2j7FM+J/QJ5Z3rkAsbleE7pHQuy0Dle78vjoxkI8x3TtqWuJ6FxyUVZToVe2ht89eyyN8 E0k2XwwK8/uZ+M1X2IAMspAvBjf8Wt/qQHPjIAEpPuJjmxvZUgcJFpz4SB77s15spVww1cqj/ i2HCFzntrKApxsfYAV7hQAtSyfyWVuyNyJsh3IXUS6FBlsWCwCc2L0zS0mREPqaU15FPmAvWA 4LTALsOZA50d25HXN6LhvgHw/6oAXcJgdDtmO+6ToiWIEiSyi24j6/7niXqKy3aU71QYaimFe uzUKuxHKKXjfsK2N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20151217_081006_070327_9BF167C9 X-CRM114-Status: GOOD ( 28.95 ) X-Spam-Score: -1.9 (-) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: andrew@lunn.ch, daniel.thompson@linaro.org, jason@lakedaemon.net, linus.walleij@linaro.org, spear-devel@list.st.com, vz@mleia.com, arm@kernel.org, gregory.clement@free-electrons.com, ulli.kroll@googlemail.com, linux-arm-kernel@lists.infradead.org, sebastian.hesselbarth@gmail.com Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Thursday 17 December 2015 10:50:20 Russell King - ARM Linux wrote: > On Fri, Dec 04, 2015 at 11:30:32PM +0100, Arnd Bergmann wrote: > > Hi everyone, > > > > I've carried most of these patches for a very long time in > > my randconfig tree, and they follow up on work that Daniel > > Thompson did last year. Most of the changes are really trivial, > > and I'd like to put them into my next/randconfig branch in > > arm-soc for merging in 4.5. > > Given the amount of breakage that we're now seeing, I'd say that this > is not true. I don't believe it's been properly tested: it may have > been tested against some old kernel version, but certainly not against > current kernels. > > It's very obvious that it's broken: running 'make defconfig' and then > trying to build the resulting configuration causes errors. I've found out what happened now, and added a fix on top to get linux-next to build again. Do you agree with the change? I'm still trying to figure out how to change my build test setup to avoid running into this error (or similar ones) again. I generally tend to build everything with my randconfig series applied on top, to avoid running into known bugs, but this time I got bitten by this because one of my workarounds prevented the compiler from producing the correct error message. I'd prefer to not fold the patch into the series now, because that would require redoing a number of merges I've done on top, but I can do that if necessary. Arnd From e45a1e18a57ccc2457429f3bd42d93330c0fee3c Mon Sep 17 00:00:00 2001 From: Arnd Bergmann Date: Thu, 17 Dec 2015 16:35:20 +0100 Subject: [PATCH] ARM: defconfig: use correct debug_ll settings The debug-ll infrastructure can be configured in two ways, either by selecting a platform specific debug option, or by picking one of the generic options (8250 or pl01x typically). For compatibility with multiplatform kernels, we have changed a couple of platforms to use the former method now when they used to use the latter. Unfortunately, this broke the defconfigs because now they still enable CONFIG_DEBUG_LL_UART_PL01X or CONFIG_DEBUG_LL_UART_8250, and we no longer configure the correct register addresses automatically. Embarrassingly, this was only found in linux-next when the defconfig builds turned up errors for multiple people, and I had not caught those in my own tests, which were done using the randconfig fixes patchset on top, and that has a workaround to avoid a build error when the addresses are not configured. The error was something like: .config:2010:warning: symbol value '' invalid for DEBUG_UART_PHYS .config:2011:warning: symbol value '' invalid for DEBUG_UART_VIRT This patch avoids the problem by removing the respective statements from the defconfig files. Any out of tree defconfig files on the platforms I have changed will have to do the same change or run into the build error above. Any users that have a full .config already set the correct DEBUG_UART_PHYS/VIRT addresses and do not need to change anything. Signed-off-by: Arnd Bergmann Fixes: 4db22c1 ("ARM: debug-ll: rework integrator/versatile handling") Fixes: f06455f ("ARM: debug-ll: rework ep93xx handling") Fixes: c047f52 ("ARM: debug-ll: reorganize mvebu debug uart config") Fixes: 59bd4c3 ("ARM: debug-ll: rework lpc32xx handling") diff --git a/arch/arm/configs/ep93xx_defconfig b/arch/arm/configs/ep93xx_defconfig index a7846d6..158dde8 100644 --- a/arch/arm/configs/ep93xx_defconfig +++ b/arch/arm/configs/ep93xx_defconfig @@ -132,6 +132,5 @@ CONFIG_DEBUG_SPINLOCK=y CONFIG_DEBUG_MUTEXES=y CONFIG_DEBUG_USER=y CONFIG_DEBUG_LL=y -CONFIG_DEBUG_LL_UART_PL01X=y # CONFIG_CRYPTO_ANSI_CPRNG is not set CONFIG_LIBCRC32C=y diff --git a/arch/arm/configs/lpc32xx_defconfig b/arch/arm/configs/lpc32xx_defconfig index c100b7d..9f56ca3 100644 --- a/arch/arm/configs/lpc32xx_defconfig +++ b/arch/arm/configs/lpc32xx_defconfig @@ -204,7 +204,6 @@ CONFIG_DEBUG_INFO=y # CONFIG_FTRACE is not set # CONFIG_ARM_UNWIND is not set CONFIG_DEBUG_LL=y -CONFIG_DEBUG_LL_UART_8250=y CONFIG_EARLY_PRINTK=y CONFIG_CRYPTO_ANSI_CPRNG=y # CONFIG_CRYPTO_HW is not set diff --git a/arch/arm/configs/mv78xx0_defconfig b/arch/arm/configs/mv78xx0_defconfig index fcdffa7..a0345e1 100644 --- a/arch/arm/configs/mv78xx0_defconfig +++ b/arch/arm/configs/mv78xx0_defconfig @@ -135,7 +135,6 @@ CONFIG_SYSCTL_SYSCALL_CHECK=y CONFIG_DEBUG_USER=y CONFIG_DEBUG_ERRORS=y CONFIG_DEBUG_LL=y -CONFIG_DEBUG_LL_UART_8250=y CONFIG_CRYPTO_CBC=m CONFIG_CRYPTO_ECB=m CONFIG_CRYPTO_PCBC=m diff --git a/arch/arm/configs/orion5x_defconfig b/arch/arm/configs/orion5x_defconfig index 6ddca88..5876ce7 100644 --- a/arch/arm/configs/orion5x_defconfig +++ b/arch/arm/configs/orion5x_defconfig @@ -162,7 +162,6 @@ CONFIG_LATENCYTOP=y # CONFIG_FTRACE is not set CONFIG_DEBUG_USER=y CONFIG_DEBUG_LL=y -CONFIG_DEBUG_LL_UART_8250=y CONFIG_CRYPTO_CBC=m CONFIG_CRYPTO_ECB=m CONFIG_CRYPTO_PCBC=m diff --git a/arch/arm/configs/versatile_defconfig b/arch/arm/configs/versatile_defconfig index 01f402d..64bef977 100644 --- a/arch/arm/configs/versatile_defconfig +++ b/arch/arm/configs/versatile_defconfig @@ -82,6 +82,5 @@ CONFIG_MAGIC_SYSRQ=y CONFIG_DEBUG_KERNEL=y CONFIG_DEBUG_USER=y CONFIG_DEBUG_LL=y -CONFIG_DEBUG_LL_UART_PL01X=y CONFIG_FONTS=y CONFIG_FONT_ACORN_8x8=y