From patchwork Wed Jul 22 14:19:17 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudeep Holla X-Patchwork-Id: 6844771 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 2AD259F38B for ; Wed, 22 Jul 2015 14:21:53 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 35ECF206DB for ; Wed, 22 Jul 2015 14:21:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6BEAF206C7 for ; Wed, 22 Jul 2015 14:21:50 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZHusB-0007Xt-0u; Wed, 22 Jul 2015 14:19:51 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZHus2-00073l-Ps for linux-arm-kernel@lists.infradead.org; Wed, 22 Jul 2015 14:19:44 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 30E7F75; Wed, 22 Jul 2015 07:19:35 -0700 (PDT) Received: from [10.1.207.150] (e103737-lin.cambridge.arm.com [10.1.207.150]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BC9DD3F21A; Wed, 22 Jul 2015 07:19:18 -0700 (PDT) Message-ID: <55AFA665.4020906@arm.com> Date: Wed, 22 Jul 2015 15:19:17 +0100 From: Sudeep Holla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Stephen Boyd Subject: Re: [PATCH v4 3/8] clk: add support for clocks provided by SCP(System Control Processor) References: <1433760002-24120-1-git-send-email-sudeep.holla@arm.com> <1433760002-24120-4-git-send-email-sudeep.holla@arm.com> <20150702172310.GF4301@codeaurora.org> <5596A1B6.8020307@arm.com> <559ADC94.4080505@codeaurora.org> <559BF858.1020301@arm.com> <20150708014606.GH30412@codeaurora.org> <55A7D79B.3080305@arm.com> <20150716193114.GA17952@codeaurora.org> <55A8E434.2010709@arm.com> <55A945DF.3@codeaurora.org> <55ACB733.2080609@arm.com> <55AE8A02.9070801@codeaurora.org> In-Reply-To: <55AE8A02.9070801@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150722_071942_923422_F00BABFF X-CRM114-Status: GOOD ( 18.50 ) X-Spam-Score: -8.1 (--------) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Jon Medhurst \(Tixy\)" , Lorenzo Pieralisi , Arnd Bergmann , "linux-pm@vger.kernel.org" , Mike Turquette , Kevin Hilman , Liviu Dudau , "linux-kernel@vger.kernel.org" , Sudeep Holla , Olof Johansson , "linux-clk@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 21/07/15 19:05, Stephen Boyd wrote: > On 07/20/2015 01:54 AM, Sudeep Holla wrote: >> >> >> On 17/07/15 19:13, Stephen Boyd wrote: >>> On 07/17/2015 04:17 AM, Sudeep Holla wrote: >> >> [...] >> >>>> >>>> determine_rate change shouldn't affect SCPI clock driver but I remember >>>> seeing round_rate change too on the list which returns value using the >>>> argument from Boris. Is that planned for v4.3 ? I would need the stable >>>> branch from this clk_hw_set_rate_range if you decide to push. Let me >>>> know your preferences. I will post the updated version of the patch >>>> accordingly. >>>> >>> >>> We're not going to change round_rate() so it sounds like you don't need >>> a stable branch. But you would need this new consumer API. So you still >>> need a branch right? >>> >> >> I am fine either way. If no one else need the stable branch to be shared >> with arm-soc, I prefer to use clock consumer API for now to avoid all >> the troubles to you guys and switch to provider API later. I will post >> it once the both this driver and that provider API is merged, if that's >> fine with you ? > > Ok. Sounds fine as long as we don't forget. > It's ready indeed :), will post it when everything is in place. Regards, Sudeep --->8 From 3ddf7fe5b1286efa712d4f2ba8108ce1855f3e74 Mon Sep 17 00:00:00 2001 From: Sudeep Holla Date: Fri, 17 Jul 2015 12:19:54 +0100 Subject: [PATCH] clk: scpi: use provider clk_hw_set_rate_range API instead of consumer API SCPI clock provider uses the consumer API clk_set_rate_range to set min/max rate constraints on the clocks it provides. Commit c87c640f915a ("clk: Allow providers to configure min/max rates") added a separate provider API clk_hw_set_rate_range to set the min/max rate of a clock. This patch switches away from clk_set_rate_range consumer API to clk_hw_set_rate_range provider API. Cc: Stephen Boyd Signed-off-by: Sudeep Holla --- drivers/clk/clk-scpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/clk-scpi.c b/drivers/clk/clk-scpi.c index 06d0558e8f46..f7c8b7a03cfe 100644 --- a/drivers/clk/clk-scpi.c +++ b/drivers/clk/clk-scpi.c @@ -174,7 +174,7 @@ scpi_clk_ops_init(struct device *dev, const struct of_device_id *match, clk = devm_clk_register(dev, &sclk->hw); if (!IS_ERR(clk) && max) - clk_set_rate_range(clk, min, max); + clk_hw_set_rate_range(&sclk->hw, min, max); return clk; }