From patchwork Tue Oct 13 02:06:11 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaehoon Chung X-Patchwork-Id: 7380741 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 526B29F1B9 for ; Tue, 13 Oct 2015 02:08:42 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8343520986 for ; Tue, 13 Oct 2015 02:08:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7687620938 for ; Tue, 13 Oct 2015 02:08:40 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Zloz8-0000qF-Df; Tue, 13 Oct 2015 02:06:38 +0000 Received: from mailout4.samsung.com ([203.254.224.34]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Zloz4-0000mQ-Rx for linux-arm-kernel@lists.infradead.org; Tue, 13 Oct 2015 02:06:35 +0000 Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout4.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NW400UOCZ6CUP60@mailout4.samsung.com> for linux-arm-kernel@lists.infradead.org; Tue, 13 Oct 2015 11:06:12 +0900 (KST) Received: from epcpsbgm1new.samsung.com ( [172.20.52.112]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id 47.31.05385.4176C165; Tue, 13 Oct 2015 11:06:12 +0900 (KST) X-AuditID: cbfee691-f79d66d000001509-98-561c671492e3 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1new.samsung.com (EPCPMTA) with SMTP id 89.1C.23663.4176C165; Tue, 13 Oct 2015 11:06:12 +0900 (KST) Received: from [10.252.81.186] by mmp2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0NW4009I0Z6B29O0@mmp2.samsung.com>; Tue, 13 Oct 2015 11:06:12 +0900 (KST) Message-id: <561C6713.1070508@samsung.com> Date: Tue, 13 Oct 2015 11:06:11 +0900 From: Jaehoon Chung User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-version: 1.0 To: Krzysztof Kozlowski , Anand Moon , Anand Moon , Kukjin Kim , Javier Martinez Canillas , Lukasz Majewski Subject: Re: [PATCH 1/3] ARM: dts: exynos5422-odroidxu3: use cd-gpio method to detect sd-card References: <1444578364-1384-1-git-send-email-linux.amoon@gmail.com> <561B3739.4040701@samsung.com> <561B3A83.6090607@samsung.com> <1111856990.2419183.1444661252893.JavaMail.yahoo@mail.yahoo.com> <561C4C88.2040004@samsung.com> In-reply-to: <561C4C88.2040004@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrNIsWRmVeSWpSXmKPExsWyRsSkQFckXSbM4N1UMYv5R86xWrx5u4bJ 4vULQ4v+x6+ZLd483MxosenxNVaLy7vmsFnMOL+PyWLdxlvsFtfvT2N24PLYOesuu8emVZ1s HpuX1Hts6Qfy+rasYvT4vEnOY9asw0wB7FFcNimpOZllqUX6dglcGd9PH2IpeCRQsW3netYG xh7eLkZODgkBE4nrV1+yQdhiEhfurQeyuTiEBFYwSnxp7GOEKdq0/TAjRGIWo0Tb18csEM4D RonOw/1g7bwCWhJXeiawg9gsAqoS3x41gnWzCehIbP92nAnEFhUIk3iwbi8rRL2gxI/J98AG iQj8YZT4en4W2CBmgVlMEtMuJIDYwgLxEnMa7rFDbHvBKLG7bz9YN6eAtsTF9qVA3RxADeoS U6bkQvTKS2xe85YZpF5C4Cu7xMvbt1ghLhKQ+Db5EFi9hICsxKYDzBCvSUocXHGDZQKj2Cwk N81CmDoLydQFjMyrGEVTC5ILipPSi0z1ihNzi0vz0vWS83M3MQLj9PS/ZxN3MN4/YH2IUYCD UYmH90WkTJgQa2JZcWXuIUZToCMmMkuJJucDk0FeSbyhsZmRhamJqbGRuaWZkjivjvTPYCGB 9MSS1OzU1ILUovii0pzU4kOMTBycUg2MXjcyQwvkOJ/2BMXFMeyOiRDetcCqc6/y5/h9zy1T 1CvF/5lsl11061zz+v/RzxxU7krdllVbfUSO4apY+rybF6d1rnz9NP5Moa1+58+Y3af7r6S/ jUk/lmH/JrOWc0ObuaON72sLn2NJa1QWxfy43eEjPV+J43IW5y7+T83l6+p2dTZrzVVSYinO SDTUYi4qTgQAozli1c4CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupgleLIzCtJLcpLzFFi42I5/e+xoK5IukyYwfMZAhbzj5xjtXjzdg2T xesXhhb9j18zW7x5uJnRYtPja6wWl3fNYbOYcX4fk8W6jbfYLa7fn8bswOWxc9Zddo9NqzrZ PDYvqffY0g/k9W1ZxejxeZOcx6xZh5kC2KMaGG0yUhNTUosUUvOS81My89JtlbyD453jTc0M DHUNLS3MlRTyEnNTbZVcfAJ03TJzgM5TUihLzCkFCgUkFhcr6dthmhAa4qZrAdMYoesbEgTX Y2SABhLWMGZ8P32IpeCRQMW2netZGxh7eLsYOTkkBEwkNm0/zAhhi0lcuLeerYuRi0NIYBaj RNvXxywQzgNGic7D/WwgVbwCWhJXeiawg9gsAqoS3x41gnWzCehIbP92nAnEFhUIk3iwbi8r RL2gxI/J98AGiQj8YZT4en4W2CBmgVlMEtMuJIDYwgLxEnMa7rFDbHvBKLG7bz9YN6eAtsTF 9qVA3RxADeoSU6bkQvTKS2xe85Z5AiPQnQg7ZiFUzUJStYCReRWjRGpBckFxUnquYV5quV5x Ym5xaV66XnJ+7iZGcCp4JrWD8eAu90OMAhyMSjy8LyJlwoRYE8uKK3MPMUpwMCuJ8OYEA4V4 UxIrq1KL8uOLSnNSiw8xmgIDYSKzlGhyPjBN5ZXEGxqbmBlZGpkbWhgZmyuJ8944xBAmJJCe WJKanZpakFoE08fEwSnVwLg+bUm61A5fDcMKD9EFWZ/WVbrpfi2YsOVtu9T825+2Ltz6/t1C +bp2VakrWWFmDzhXOi6QuTHRNvty9ZbjZ1z+pc1/9W+Vzv2DP+30I6Y8mRHc//bH6RMv5nTK VPya+OnAQd0Ja5+eFFLY/W6fpzOf1OmQLB0Rn5iVB5Z68xZHfHc14Y5i/XJNiaU4I9FQi7mo OBEASFDV3xsDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20151012_190635_067764_123BF8AC X-CRM114-Status: GOOD ( 18.83 ) X-Spam-Score: -6.9 (------) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , "linux-samsung-soc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Dear, Anand. On 10/13/2015 09:12 AM, Krzysztof Kozlowski wrote: > On 12.10.2015 23:47, Anand Moon wrote: >>> >>> Anand, >>> >>> You essentially reverted here af6ad88acbd6 ("ARM: dts: Mux XMMCnDATA[0] >>> pad correctly for Exynos5420 boards"). Why? There is no explanation in >>> the commit message about this. >> >> I don't remember to send the patch relevant to this. Hmm... >> Well, Is this patch really signed-off by me? >> >> Best Regards, >> >> Jaehoon Chung >>> >>> Best regards, >>> Krzysztof >>> >> >>> >> >> >> Some how I don't receive these mail on my email id. >> >> I have picked up these changes from tizen repository for OdroidXU3. >> I have tested with this changes to detect UHS-I micro cd cards. >> That's the reason for this email. It seems to make manually, right? I have checked the tizen repository. The below is Best Regards, Jaehoon Chung > > ... and you applied it blindly without looking at actual existing > contents and at previous commits. > > That is not how patches from different repositories should be cherry picked. > > Best regards, > Krzysztof > > --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts @@ -335,7 +335,9 @@ samsung,dw-mshc-sdr-timing = <0 4>; samsung,dw-mshc-ddr-timing = <0 2>; pinctrl-names = "default"; - pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus1 &sd2_bus4>; + cd-gpios = <&gpc2 2 0>; + cd-inverted; + pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_bus1 &sd2_bus4>; bus-width = <4>; cap-sd-highspeed; }; Yours --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi @@ -352,8 +352,10 @@ samsung,dw-mshc-ciu-div = <3>; samsung,dw-mshc-sdr-timing = <0 4>; samsung,dw-mshc-ddr-timing = <0 2>; + cd-gpios = <&gpc2 2 GPIO_ACTIVE_HIGH>; + cd-inverted; pinctrl-names = "default"; - pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus1 &sd2_bus4>; + pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus4>; Did you know what differ? :)