| Message ID | 563BA50C.4060303@users.sourceforge.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Am 05.11.2015 19:50, schrieb SF Markus Elfring: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Thu, 5 Nov 2015 19:23:50 +0100 > > The variable "tsin" was checked three times in a loop iteration of the > c8sectpfe_tuner_unregister_frontend() function. > This implementation detail could be improved by the combination of the > involved statements into a single if block so that this variable will be > checked only once there. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/media/platform/sti/c8sectpfe/c8sectpfe-common.c | 17 +++++++++-------- > 1 file changed, 9 insertions(+), 8 deletions(-) > > diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-common.c b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-common.c > index 07fd6d9..2dfbe8a 100644 > --- a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-common.c > +++ b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-common.c > @@ -209,17 +209,18 @@ void c8sectpfe_tuner_unregister_frontend(struct c8sectpfe *c8sectpfe, > > tsin = fei->channel_data[n]; if you do "if (!tsin) continue ;" you can save one indent level re, wh > > - if (tsin && tsin->frontend) { > - dvb_unregister_frontend(tsin->frontend); > - dvb_frontend_detach(tsin->frontend); > - } > + if (tsin) { > + if (tsin->frontend) { > + dvb_unregister_frontend(tsin->frontend); > + dvb_frontend_detach(tsin->frontend); > + } > > - if (tsin) > i2c_put_adapter(tsin->i2c_adapter); > > - if (tsin && tsin->i2c_client) { > - module_put(tsin->i2c_client->dev.driver->owner); > - i2c_unregister_device(tsin->i2c_client); > + if (tsin->i2c_client) { > + module_put(tsin->i2c_client->dev.driver->owner); > + i2c_unregister_device(tsin->i2c_client); > + } > } > } >
diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-common.c b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-common.c index 07fd6d9..2dfbe8a 100644 --- a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-common.c +++ b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-common.c @@ -209,17 +209,18 @@ void c8sectpfe_tuner_unregister_frontend(struct c8sectpfe *c8sectpfe, tsin = fei->channel_data[n]; - if (tsin && tsin->frontend) { - dvb_unregister_frontend(tsin->frontend); - dvb_frontend_detach(tsin->frontend); - } + if (tsin) { + if (tsin->frontend) { + dvb_unregister_frontend(tsin->frontend); + dvb_frontend_detach(tsin->frontend); + } - if (tsin) i2c_put_adapter(tsin->i2c_adapter); - if (tsin && tsin->i2c_client) { - module_put(tsin->i2c_client->dev.driver->owner); - i2c_unregister_device(tsin->i2c_client); + if (tsin->i2c_client) { + module_put(tsin->i2c_client->dev.driver->owner); + i2c_unregister_device(tsin->i2c_client); + } } }