From patchwork Fri Jan 8 11:13:33 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Fuzzey X-Patchwork-Id: 7984551 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 82FAABEEE5 for ; Fri, 8 Jan 2016 11:15:28 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8AC1A2017D for ; Fri, 8 Jan 2016 11:15:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9B32D20172 for ; Fri, 8 Jan 2016 11:15:26 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aHUzZ-0003JO-8C; Fri, 08 Jan 2016 11:14:01 +0000 Received: from mail-wm0-x233.google.com ([2a00:1450:400c:c09::233]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aHUzV-0003C4-61 for linux-arm-kernel@lists.infradead.org; Fri, 08 Jan 2016 11:13:57 +0000 Received: by mail-wm0-x233.google.com with SMTP id u188so132795268wmu.1 for ; Fri, 08 Jan 2016 03:13:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=parkeon-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=Xz0wDkwashaZJBXbzALqCdS/rC+XFGtGxqbijur5OJg=; b=OpL2wxj9638F72OMvjQq+o4J+5OXbdlM4EjBoAZ2dGV3Jvttyz5r0knVgaqG4Rqovk JrTgWXLcsg8Ld2T8jCgygkaNx+A9gwqdtyyPzci8xA0dgAq88vRdChLoKHagKfqO2Te0 i5SNFawNsE/vHYTwWh/CeAfNstR58EmAQ30UhO5IUp0EYP8VyyQB5SCd9shaTw3tV9Eu QHYdqIhkAQfVVnQx0ZHTpvqtMO02LbukY0iW3Fpt4lh7L8qYS9CDmxhhAatKDrKyQVYI xhy6bk4ynb7toRf8mrugpO2tWjqpFAISY/HYjjGNkmQCBNYb+IkJ/vN0I5F9r+ZMOjpz YU+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=Xz0wDkwashaZJBXbzALqCdS/rC+XFGtGxqbijur5OJg=; b=DPkNY4AQWoFCBjKAaTAznlO/4Onfc1njfHcJlWW+ScBn43dcLLDBCcWeBQTVg9eE6T XXzx7wOJXNINUblu0NwZrMN+xs613Yn1Z/1nTKBamRGFldyY8aTfnoiIiggLqq9nrmp4 MmybM+wBy34OPLw4yS7GdcxM2iNVBVH+8WbmCA0SRuL3759ds0Zq5nrGPLuyBtNvAe5z 74HjBRX3Tz1BvZZYR+zJfO2xnJNi6FyJnSj+n+yVsc2VNrHPYaEWlSfRurfjEvDAOCm2 OQq5YrZM6rhzPyoGq6kyUzs1prM6124W0pfXD5aSaJTJmOutdp2Ci12PBJkMmgW+1Yrn UDfg== X-Gm-Message-State: ALoCoQmrpj52wbrVvcw2V3Qe8uYJVEH1QKqGQLd5n1ja44L2rC32WdCzDIO/id9YbnjICP2Y+UPY8yJjRs/SlrvfSZ3h9R5XLA== X-Received: by 10.194.87.170 with SMTP id az10mr117978282wjb.144.1452251615183; Fri, 08 Jan 2016 03:13:35 -0800 (PST) Received: from [10.32.51.9] (ip65.parkeon.com. [213.152.31.65]) by smtp.gmail.com with ESMTPSA id 67sm18090128wmp.20.2016.01.08.03.13.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Jan 2016 03:13:34 -0800 (PST) Subject: Re: [PATCH V2] serial: imx: Fix suspend / resume. To: Fabio Estevam References: <20160105155331.6024.7211.stgit@localhost> From: Martin Fuzzey Message-ID: <568F99DD.50809@parkeon.com> Date: Fri, 8 Jan 2016 12:13:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160108_031357_424254_4538BAF1 X-CRM114-Status: GOOD ( 15.82 ) X-Spam-Score: -2.6 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Russell King - ARM Linux , Sascha Hauer , Greg Kroah-Hartman , "linux-serial@vger.kernel.org" , Shawn Guo , "linux-arm-kernel@lists.infradead.org" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 08/01/16 00:51, Fabio Estevam wrote: > On Thu, Jan 7, 2016 at 9:17 PM, Fabio Estevam wrote: > >> [ 39.487313] [] (snd_soc_suspend) from [] > Ok, in this case it is an ALSA issue, so will start a thread at the > alsa mailing list. Ah, Just seen I have this in my tree for that: I have that in my old 3.19 tree too so it's not new. I didn't submit it because I haven't investigated further to see if it was just papering over the real problem.. Martin diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index a1305f8..a7ddf69 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -584,6 +584,9 @@ int snd_soc_suspend(struct device *dev) if (!card->instantiated) return 0; + if (!card->snd_card) + return 0; + /* Due to the resume being scheduled into a workqueue we could * suspend before that's finished - wait for it to complete. */ @@ -814,6 +817,9 @@ int snd_soc_resume(struct device *dev) if (!card->instantiated) return 0; + if (!card->snd_card) + return 0; + /* activate pins from sleep state */