From patchwork Wed Feb 17 10:10:00 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Morse X-Patchwork-Id: 8335931 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 93BD9C02AA for ; Wed, 17 Feb 2016 10:13:12 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A672C202EB for ; Wed, 17 Feb 2016 10:13:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C3158202BE for ; Wed, 17 Feb 2016 10:13:10 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aVz5A-0006Hm-RC; Wed, 17 Feb 2016 10:11:40 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aVz58-0006Bt-6F for linux-arm-kernel@lists.infradead.org; Wed, 17 Feb 2016 10:11:38 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2273E3A1; Wed, 17 Feb 2016 02:10:28 -0800 (PST) Received: from [10.1.209.158] (melchizedek.cambridge.arm.com [10.1.209.158]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A0CD43F21A; Wed, 17 Feb 2016 02:11:16 -0800 (PST) Message-ID: <56C446F8.3050906@arm.com> Date: Wed, 17 Feb 2016 10:10:00 +0000 From: James Morse User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0 MIME-Version: 1.0 To: Andrey Ryabinin , Mark Rutland Subject: Re: [PATCH v5sub1 7/8] arm64: move kernel image to base of vmalloc area References: <20160212151006.GJ31665@e104818-lin.cambridge.arm.com> <20160212152641.GK31665@e104818-lin.cambridge.arm.com> <56BDFC86.5010705@arm.com> <20160212160652.GL31665@e104818-lin.cambridge.arm.com> <56C1E072.2090909@virtuozzo.com> <20160215185957.GB19413@e104818-lin.cambridge.arm.com> <56C31D1D.50708@virtuozzo.com> <56C34204.60605@virtuozzo.com> <20160216164245.GC8022@leverpostej> <56C43A23.1020301@virtuozzo.com> In-Reply-To: <56C43A23.1020301@virtuozzo.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160217_021138_301951_C3AD257B X-CRM114-Status: GOOD ( 12.81 ) X-Spam-Score: -6.9 (------) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ard Biesheuvel , Marc Zyngier , Catalin Marinas , Will Deacon , Sudeep Holla , "linux-arm-kernel@lists.infradead.org" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 17/02/16 09:15, Andrey Ryabinin wrote: > On 02/16/2016 07:42 PM, Mark Rutland wrote: >> On Tue, Feb 16, 2016 at 06:36:36PM +0300, Andrey Ryabinin wrote: >>> You are right. >>> So we should write 'shadow_start' instead of 'i'. >> >> FWIW with the below patch I don't see any "screwed shadow mapping" >> warnings on my board, and still later see a tonne of KASAN splats in the >> scheduler. >> > > It is possible that I missed something, but I think it means that shadow is alright. > > I wonder whether this happens on 4.4. If not, than something in 4.5-rc1 caused this, and the obvious suspect > here is irq stack. This quick hack will prevent ever switching to the irq stack: ---------------------------%<--------------------------- ---------------------------%<--------------------------- James diff --git a/arch/arm64/kernel/entry.S b/arch/arm64/kernel/entry.S index 1f7f5a2b61bf..83ae736429b6 100644 --- a/arch/arm64/kernel/entry.S +++ b/arch/arm64/kernel/entry.S @@ -188,7 +188,7 @@ alternative_endif */ and x25, x19, #~(THREAD_SIZE - 1) cmp x25, tsk - b.ne 9998f + b 9998f this_cpu_ptr irq_stack, x25, x26 mov x26, #IRQ_STACK_START_SP