From patchwork Fri Sep 2 10:46:19 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: zhangjian X-Patchwork-Id: 9310701 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D6FDE607D2 for ; Fri, 2 Sep 2016 10:51:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C577D2977E for ; Fri, 2 Sep 2016 10:51:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B977329781; Fri, 2 Sep 2016 10:51:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E28442977E for ; Fri, 2 Sep 2016 10:51:37 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bfm2r-0005rx-Q0; Fri, 02 Sep 2016 10:50:01 +0000 Received: from szxga03-in.huawei.com ([119.145.14.66]) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bfm2m-0005Vq-8d for linux-arm-kernel@lists.infradead.org; Fri, 02 Sep 2016 10:49:58 +0000 Received: from 172.24.1.36 (EHLO szxeml433-hub.china.huawei.com) ([172.24.1.36]) by szxrg03-dlp.huawei.com (MOS 4.4.3-GA FastPath queued) with ESMTP id CHF91221; Fri, 02 Sep 2016 18:44:52 +0800 (CST) Received: from [10.110.52.23] (10.110.52.23) by szxeml433-hub.china.huawei.com (10.82.67.210) with Microsoft SMTP Server id 14.3.235.1; Fri, 2 Sep 2016 18:44:43 +0800 Message-ID: <57C9587B.9080006@huawei.com> Date: Fri, 2 Sep 2016 18:46:19 +0800 From: Bamvor Jian Zhang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Yury Norov , , , , , , , Subject: Re: [PATCH 12/18] arm64: ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it References: <1471434403-25291-1-git-send-email-ynorov@caviumnetworks.com> <1471434403-25291-13-git-send-email-ynorov@caviumnetworks.com> In-Reply-To: <1471434403-25291-13-git-send-email-ynorov@caviumnetworks.com> X-Originating-IP: [10.110.52.23] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A0B0201.57C95827.0049, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: c4225b133c684cc23854906aa6d582dd X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160902_034956_898126_F4875943 X-CRM114-Status: GOOD ( 19.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Pinski , heiko.carstens@de.ibm.com, cmetcalf@ezchip.com, Hanjun Guo , philipp.tomsich@theobroma-systems.com, joseph@codesourcery.com, chenjianguo 00365834 , zhouchengming1@huawei.com, jijun 00321192 , Prasun.Kapoor@caviumnetworks.com, agraf@suse.de, szabolcs.nagy@arm.com, geert@linux-m68k.org, kilobyte@angband.pl, manuel.montezelo@gmail.com, pinskia@gmail.com, linyongting@huawei.com, klimov.linux@gmail.com, broonie@kernel.org, zhangjian 00293696 , maxim.kuvyrkov@linaro.org, Nathan_Lynch@mentor.com, Andrew Pinski , schwidefsky@de.ibm.com, davem@davemloft.net, christoph.muellner@theobroma-systems.com Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Hi, Yury On 08/17/2016 07:46 PM, Yury Norov wrote: > From: Andrew Pinski > [...] > diff --git a/arch/arm64/kernel/sys_ilp32.c b/arch/arm64/kernel/sys_ilp32.c > new file mode 100644 > index 0000000..10fc0ca > --- /dev/null > +++ b/arch/arm64/kernel/sys_ilp32.c > @@ -0,0 +1,86 @@ > +/* > + * AArch64- ILP32 specific system calls implementation > + * > + * Copyright (C) 2016 Cavium Inc. > + * Author: Andrew Pinski > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program. If not, see . > + */ > + > +#define __SYSCALL_COMPAT > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +/* > + * Using aarch32 syscall handlerss where off_t is passed. > + */ > +#define compat_sys_fadvise64_64 compat_sys_fadvise64_64_wrapper > +#define compat_sys_fallocate compat_sys_fallocate_wrapper > +#define compat_sys_fcntl64 sys_fcntl > +#define compat_sys_ftruncate64 compat_sys_ftruncate64_wrapper > +#define compat_sys_pread64 compat_sys_pread64_wrapper > +#define compat_sys_pwrite64 compat_sys_pwrite64_wrapper > +#define compat_sys_readahead compat_sys_readahead_wrapper > +#define compat_sys_shmat sys_shmat > +#define compat_sys_sync_file_range compat_sys_sync_file_range2_wrapper > +#define compat_sys_truncate64 compat_sys_truncate64_wrapper When we test sync_file_range with our own testcase, we found that the parameter sequence is not correct for sync_file_range2 because glibc think kernel use the sync_file_range. So, in this patch we force to sync_file_range2. Is it make sense to you? Regards Bamvor From e730e4db23bca4dd0ff6bcca0bc4c04e5c13b5c7 Mon Sep 17 00:00:00 2001 From: Bamvor Jian Zhang Date: Sat, 27 Aug 2016 12:26:31 +0800 Subject: [PATCH] arm64:ilp32: force sync_file_range2 Define __ARCH_WANT_SYNC_FILE_RANGE2 in order to select correct sync_file_range parameters sequence in glibc and kernel. Tested-by: Jianguo Chen Signed-off-by: Bamvor Jian Zhang --- arch/arm64/include/uapi/asm/unistd.h | 5 +++++ arch/arm64/kernel/sys_ilp32.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/arch/arm64/include/uapi/asm/unistd.h b/arch/arm64/include/uapi/asm/unistd.h index 043d17a..78bea1d 100644 --- a/arch/arm64/include/uapi/asm/unistd.h +++ b/arch/arm64/include/uapi/asm/unistd.h @@ -16,4 +16,9 @@ #define __ARCH_WANT_RENAMEAT +/* We need to make sure it works for both userspace and kernel(sys_ilp32.c) */ +#if defined(__ILP32__) || defined(__SYSCALL_COMPAT) +#define __ARCH_WANT_SYNC_FILE_RANGE2 +#endif + #include diff --git a/arch/arm64/kernel/sys_ilp32.c b/arch/arm64/kernel/sys_ilp32.c index 10fc0ca..13c9c9d 100644 --- a/arch/arm64/kernel/sys_ilp32.c +++ b/arch/arm64/kernel/sys_ilp32.c @@ -42,7 +42,7 @@ #define compat_sys_pwrite64 compat_sys_pwrite64_wrapper #define compat_sys_readahead compat_sys_readahead_wrapper #define compat_sys_shmat sys_shmat -#define compat_sys_sync_file_range compat_sys_sync_file_range2_wrapper +#define compat_sys_sync_file_range2 compat_sys_sync_file_range2_wrapper #define compat_sys_truncate64 compat_sys_truncate64_wrapper #define sys_mmap2 compat_sys_mmap2_wrapper #define sys_ptrace compat_sys_ptrace