| Message ID | 584a2c53-100b-945b-d665-cef3fa856526@free.fr (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Apr 21, 2017 at 10:06:10AM +0200, Mason wrote: > The "pchans_used" field is an unsigned long array. > > for_each_clear_bit_from() expects an unsigned long pointer, > not an array address. > > $ make C=2 drivers/dma/sun4i-dma.o > CHECK drivers/dma/sun4i-dma.c > drivers/dma/sun4i-dma.c:241:9: warning: incorrect type in argument 1 (different base types) > drivers/dma/sun4i-dma.c:241:9: expected unsigned long const *p > drivers/dma/sun4i-dma.c:241:9: got unsigned long ( *<noident> )[1] The patch looks good... > Signed-off-by: Mason <slash.tmp@free.fr> However this doesn't. See https://www.kernel.org/doc/html/latest/process/submitting-patches.html#developer-s-certificate-of-origin-1-1 Maxime
diff --git a/drivers/dma/sun4i-dma.c b/drivers/dma/sun4i-dma.c index 57aa227bfadb..f4ed3f17607c 100644 --- a/drivers/dma/sun4i-dma.c +++ b/drivers/dma/sun4i-dma.c @@ -238,7 +238,7 @@ static struct sun4i_dma_pchan *find_and_use_pchan(struct sun4i_dma_dev *priv, } spin_lock_irqsave(&priv->lock, flags); - for_each_clear_bit_from(i, &priv->pchans_used, max) { + for_each_clear_bit_from(i, priv->pchans_used, max) { pchan = &pchans[i]; pchan->vchan = vchan; set_bit(i, priv->pchans_used);
The "pchans_used" field is an unsigned long array. for_each_clear_bit_from() expects an unsigned long pointer, not an array address. $ make C=2 drivers/dma/sun4i-dma.o CHECK drivers/dma/sun4i-dma.c drivers/dma/sun4i-dma.c:241:9: warning: incorrect type in argument 1 (different base types) drivers/dma/sun4i-dma.c:241:9: expected unsigned long const *p drivers/dma/sun4i-dma.c:241:9: got unsigned long ( *<noident> )[1] Signed-off-by: Mason <slash.tmp@free.fr> --- drivers/dma/sun4i-dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)